From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] libext2fs: don't use O_DIRECT for files on tmpfs
Date: Sat, 7 Mar 2020 11:17:05 -0500 [thread overview]
Message-ID: <20200307161705.GA99899@mit.edu> (raw)
In-Reply-To: <20200221214056.39993-1-adilger@whamcloud.com>
On Fri, Feb 21, 2020 at 02:40:56PM -0700, Andreas Dilger wrote:
> If a filesystem image is on tmpfs, opening it with O_DIRECT for
> reading the MMP will fail. This is unnecessary, since the image
> file can't really be open on another node at this point. If the
> open with O_DIRECT fails, retry without it when plausible.
>
> Remove the special-casing of tmpfs from the mmp test cases.
>
> Change-Id: I41f4b31657b06f62f10be8d6e524d303dd36a321
> Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2020-03-07 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 21:40 [PATCH] libext2fs: don't use O_DIRECT for files on tmpfs Andreas Dilger
2020-03-07 16:17 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200307161705.GA99899@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.