All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libglib2: bump to version 2.64.0
Date: Sat, 7 Mar 2020 22:28:43 +0100	[thread overview]
Message-ID: <20200307222843.6889675c@gmx.net> (raw)
In-Reply-To: <20200307220648.7df62529@windsurf.home>

Hello Thomas,

On Sat, 7 Mar 2020 22:06:48 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> On Fri,  6 Mar 2020 14:14:58 -0700
> James Hilliard <james.hilliard1@gmail.com> wrote:
>
> >  ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBMOUNT),y)
> > -LIBGLIB2_CONF_OPTS += -Dlibmount=true
> > +LIBGLIB2_CONF_OPTS += -Dlibmount=enabled
> >  LIBGLIB2_DEPENDENCIES += util-linux
> >  else
> > -LIBGLIB2_CONF_OPTS += -Dlibmount=false
> > +LIBGLIB2_CONF_OPTS += -Dlibmount=disabled
> >  endif
>
> Any reason for this change ? It is not explained in the commit log, and
> it's not obvious why it is needed.
>
> Could you give a few more details?

The option was changed from type boolean to type feature:

-- build/libglib2-2.62.4/meson_options.txt	2019-12-19 17:33:15.000000000 +0100
+++ build/libglib2-2.64.0/meson_options.txt	2020-02-27 17:12:52.000000000 +0100
@@ -30,8 +30,8 @@
        description : 'build with xattr support')

 option('libmount',
-       type : 'boolean',
-       value : true,
+       type : 'feature',
+       value : 'auto',
        description : 'build with libmount support')

 option('internal_pcre',

Regards,
Peter

>
> Thanks,
>
> Thomas

  reply	other threads:[~2020-03-07 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06 21:14 [Buildroot] [PATCH 1/1] package/libglib2: bump to version 2.64.0 James Hilliard
2020-03-07 21:06 ` Thomas Petazzoni
2020-03-07 21:28   ` Peter Seiderer [this message]
2020-03-12 20:47 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200307222843.6889675c@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.