From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:4942:0:0:0:0:0 with SMTP id o2csp6144552lfi; Sat, 7 Mar 2020 23:56:46 -0800 (PST) X-Google-Smtp-Source: ADFU+vt0oe72XwncOi4jn/QegqvUR7fV7FmTTlM/JUA7r5SmiDzSAWj/bbTRsw7NVs1ybabdMke5 X-Received: by 2002:a0c:ec02:: with SMTP id y2mr3975865qvo.171.1583654206277; Sat, 07 Mar 2020 23:56:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583654206; cv=none; d=google.com; s=arc-20160816; b=ldNbcK8fiqDAgxI9Ae3/QNGuCKyrugwvgltckIFe7tvd7gNi9KXdqCtHUml2TdJAE0 UGA4SbJVr3AK301sAVeim2l7txqkhSDyrtwl2gBwY/u70B/SVY5sLdcfcu09XstXf6nn /7s92c99NTg5R+JrgV5G74zBdl6ZgYkTf8d73b2pSiMq8OdZiQ4ho6lyXRS5mhVzPekZ tzwpFOC4RxNAoCnr3QEobybOrJTiJw3Tz5F269LsEarC0xmDrjjbrxOwM6N4WNE4BXhS OeAVGfdZQeOlYsLu7Q7uapjid1l10+N9b/DVyeqGKHGq2PFIGw8EIWO5niFtW0LG+5D0 44Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-disposition :content-transfer-encoding:in-reply-to:mime-version:references :message-id:subject:to:from:date:dkim-signature; bh=ynFyiQeM454w8E0H4H7s8WljySZMe1a49ecpNjlpYQM=; b=YGEeKf61n0vqa2LOYHt8vXvkpIC5eKe151kESXNvzFQFFOtOvZd9WQ+ZOxqwXWGOoF 9FYhsApVwJr4VHmk0sKrrPCVpV5rkY4PuuvNDoKCBrnxP8i8u8zCSiUX/pcXJ/soWBT7 tC5LUBPRzAsXbyeIDtL4oJNtUhxfsz8cuhQFEXdygUQtRbfCiLuTiVNfT68/cPxAQOeF XijZnMfvB9th+ENdYeSQHnTebe3Sjk5kE7CiSH8BuUY9CeKQJu4sKJngIfZ3vwFekk2W 0sjboROJEBpiGmcPqnnqhKdlyXsBjGMKlQK/4MpbIuUxI7VJj+f3e13zVnK8FZKeRer4 holQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=e0i5cehi; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e28si4401979qkl.165.2020.03.07.23.56.46 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Mar 2020 23:56:46 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=e0i5cehi; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:55714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAqnl-0000c3-LO for alex.bennee@linaro.org; Sun, 08 Mar 2020 03:56:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46330) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAqnY-0000Yl-3N for qemu-arm@nongnu.org; Sun, 08 Mar 2020 03:56:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAqnW-0001ng-8j for qemu-arm@nongnu.org; Sun, 08 Mar 2020 03:56:32 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:32390 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jAqnW-0001nV-3w for qemu-arm@nongnu.org; Sun, 08 Mar 2020 03:56:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583654189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ynFyiQeM454w8E0H4H7s8WljySZMe1a49ecpNjlpYQM=; b=e0i5cehiLuL2uCYC5518ZvID5Dbwy44ZToGOlkTEs/l/FLu4SeXtSXmOrhSjbogrFqbSyk nB5i50hFe0ksRHtusNjpuc1MUd8RIfZfHXjUZ8nbli504Az0UiHH+MPuEBiAng2QZ97Byf Z5aXpv7AkwiW8E2v6iVtF28xJth+iUU= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-0TAStY7jNBK4xJ9p7QfnnA-1; Sun, 08 Mar 2020 03:56:27 -0400 X-MC-Unique: 0TAStY7jNBK4xJ9p7QfnnA-1 Received: by mail-qk1-f199.google.com with SMTP id d2so4998960qko.3 for ; Sat, 07 Mar 2020 23:56:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=eNlNeV0cCqtLqdRwzb8GyuXIKo2c9XoG4YAsMmS1GFs=; b=Ic4LpjQ22kOpuKGDkf+ZHpoHYZqQa5DZiEbnrswpUcwxoRRbidAlpXTU5pwaL0MCyG UQqQzSMSDUqDu1eeFshUnGSpagJsmdEPbo5WWFWL20VXP+wzJEttUfyEVb87PkuGgejR +V5TVMvfbOSI1eAYRVKbQzJai1lKxHquWELPZ0JX4msAPgayUC3ao+tshy8yTJy0dg5O 0r5qdgEbtRB6cw4VWdoQT8+/GW7iy/54qJj14oZ/o0wa64e/QbbOmmmzVIbiugza051y AuMR2uVTpjLWkJzRKpl6gYXlkzjRsBiufC1ZQ2+pSJDh/IPB/esxZFXapJmEEMyW0XGH 9AVg== X-Gm-Message-State: ANhLgQ2UXDmVlCn32W9Yuz+MhL1z4UiRJeBWhhEExG1JFu6p1/4aLHJ9 7e1TWH1WQ9ylR7PG9+zh5FHPNScv/fIUDOlbqmdPiWjyPWcgI3QSLN5K2Qed8LDHorTGwQomGQJ oqkhMeahisBH9 X-Received: by 2002:a37:b902:: with SMTP id j2mr8192010qkf.247.1583654187091; Sat, 07 Mar 2020 23:56:27 -0800 (PST) X-Received: by 2002:a37:b902:: with SMTP id j2mr8191977qkf.247.1583654186728; Sat, 07 Mar 2020 23:56:26 -0800 (PST) Received: from redhat.com (bzq-79-178-2-19.red.bezeqint.net. [79.178.2.19]) by smtp.gmail.com with ESMTPSA id t55sm21320959qte.24.2020.03.07.23.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2020 23:56:26 -0800 (PST) Date: Sun, 8 Mar 2020 03:56:16 -0400 From: "Michael S. Tsirkin" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v2 2/2] misc: Replace zero-length arrays with flexible array member (manual) Message-ID: <20200308035558-mutt-send-email-mst@kernel.org> References: <20200304153816.23636-1-philmd@redhat.com> <20200304153816.23636-3-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200304153816.23636-3-philmd@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Paul Durrant , Jason Wang , qemu-devel@nongnu.org, Gerd Hoffmann , Stefano Stabellini , qemu-block@nongnu.org, David Hildenbrand , "Gustavo A . R . Silva" , Halil Pasic , Christian Borntraeger , "Gonglei \(Arei\)" , Marcel Apfelbaum , Anthony Perard , xen-devel@lists.xenproject.org, Thomas Huth , Eduardo Habkost , Yuval Shaia , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Paolo Bonzini , John Snow , Richard Henderson , Kevin Wolf , Xiao Guangrong , Eric Auger , Cornelia Huck , Laurent Vivier , Max Reitz , Igor Mammedov Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 6Q7mQIj8/HfK On Wed, Mar 04, 2020 at 04:38:16PM +0100, Philippe Mathieu-Daud=E9 wrote: > Description copied from Linux kernel commit from Gustavo A. R. Silva > (see [3]): >=20 > --v-- description start --v-- >=20 > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to > declare variable-length types such as these ones is a flexible > array member [1], introduced in C99: >=20 > struct foo { > int stuff; > struct boo array[]; > }; >=20 > By making use of the mechanism above, we will get a compiler > warning in case the flexible array does not occur last in the > structure, which will help us prevent some kind of undefined > behavior bugs from being unadvertenly introduced [2] to the > Linux codebase from now on. >=20 > --^-- description end --^-- >=20 > Do the similar housekeeping in the QEMU codebase (which uses > C99 since commit 7be41675f7cb). >=20 > All these instances of code were found with the help of the > following command (then manual analysis, without modifying > structures only having a single flexible array member, such > QEDTable in block/qed.h): >=20 > git grep -F '[0];' >=20 > [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co= mmit/?id=3D76497732932f > [3] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/= commit/?id=3D17642a2fbd2c1 >=20 > Inspired-by: Gustavo A. R. Silva > Reviewed-by: David Hildenbrand > Signed-off-by: Philippe Mathieu-Daud=E9 Reviewed-by: Michael S. Tsirkin > --- > v2: Do not modify block/qed.h: >=20 > block/qed.h:106:14: error: flexible array member 'offsets' not allowed = in otherwise empty struct > uint64_t offsets[]; /* in bytes */ > ^ > --- > docs/interop/vhost-user.rst | 4 ++-- > include/hw/acpi/acpi-defs.h | 4 ++-- > include/hw/boards.h | 2 +- > include/hw/s390x/event-facility.h | 2 +- > include/hw/s390x/sclp.h | 8 ++++---- > block/vmdk.c | 2 +- > hw/char/sclpconsole-lm.c | 2 +- > hw/char/sclpconsole.c | 2 +- > hw/s390x/virtio-ccw.c | 2 +- > target/s390x/ioinst.c | 2 +- > 10 files changed, 15 insertions(+), 15 deletions(-) >=20 > diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst > index 401652397c..3b1b6602c7 100644 > --- a/docs/interop/vhost-user.rst > +++ b/docs/interop/vhost-user.rst > @@ -568,7 +568,7 @@ For split virtqueue, queue region can be implemented = as: > uint16_t used_idx; > =20 > /* Used to track the state of each descriptor in descriptor table = */ > - DescStateSplit desc[0]; > + DescStateSplit desc[]; > } QueueRegionSplit; > =20 > To track inflight I/O, the queue region should be processed as follows: > @@ -690,7 +690,7 @@ For packed virtqueue, queue region can be implemented= as: > uint8_t padding[7]; > =20 > /* Used to track the state of each descriptor fetched from descrip= tor ring */ > - DescStatePacked desc[0]; > + DescStatePacked desc[]; > } QueueRegionPacked; > =20 > To track inflight I/O, the queue region should be processed as follows: > diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h > index 19f7ba7b70..c13327fa78 100644 > --- a/include/hw/acpi/acpi-defs.h > +++ b/include/hw/acpi/acpi-defs.h > @@ -152,7 +152,7 @@ typedef struct AcpiSerialPortConsoleRedirection > */ > struct AcpiRsdtDescriptorRev1 { > ACPI_TABLE_HEADER_DEF /* ACPI common table header */ > - uint32_t table_offset_entry[0]; /* Array of pointers to other */ > + uint32_t table_offset_entry[]; /* Array of pointers to other */ > /* ACPI tables */ > } QEMU_PACKED; > typedef struct AcpiRsdtDescriptorRev1 AcpiRsdtDescriptorRev1; > @@ -162,7 +162,7 @@ typedef struct AcpiRsdtDescriptorRev1 AcpiRsdtDescrip= torRev1; > */ > struct AcpiXsdtDescriptorRev2 { > ACPI_TABLE_HEADER_DEF /* ACPI common table header */ > - uint64_t table_offset_entry[0]; /* Array of pointers to other */ > + uint64_t table_offset_entry[]; /* Array of pointers to other */ > /* ACPI tables */ > } QEMU_PACKED; > typedef struct AcpiXsdtDescriptorRev2 AcpiXsdtDescriptorRev2; > diff --git a/include/hw/boards.h b/include/hw/boards.h > index 9bc42dfb22..c96120d15f 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h > @@ -71,7 +71,7 @@ typedef struct CPUArchId { > */ > typedef struct { > int len; > - CPUArchId cpus[0]; > + CPUArchId cpus[]; > } CPUArchIdList; > =20 > /** > diff --git a/include/hw/s390x/event-facility.h b/include/hw/s390x/event-f= acility.h > index bdc32a3c09..700a610f33 100644 > --- a/include/hw/s390x/event-facility.h > +++ b/include/hw/s390x/event-facility.h > @@ -122,7 +122,7 @@ typedef struct MDBO { > =20 > typedef struct MDB { > MdbHeader header; > - MDBO mdbo[0]; > + MDBO mdbo[]; > } QEMU_PACKED MDB; > =20 > typedef struct SclpMsg { > diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h > index c54413b78c..cd7b24359f 100644 > --- a/include/hw/s390x/sclp.h > +++ b/include/hw/s390x/sclp.h > @@ -132,7 +132,7 @@ typedef struct ReadInfo { > uint16_t highest_cpu; > uint8_t _reserved5[124 - 122]; /* 122-123 */ > uint32_t hmfai; > - struct CPUEntry entries[0]; > + struct CPUEntry entries[]; > } QEMU_PACKED ReadInfo; > =20 > typedef struct ReadCpuInfo { > @@ -142,7 +142,7 @@ typedef struct ReadCpuInfo { > uint16_t nr_standby; /* 12-13 */ > uint16_t offset_standby; /* 14-15 */ > uint8_t reserved0[24-16]; /* 16-23 */ > - struct CPUEntry entries[0]; > + struct CPUEntry entries[]; > } QEMU_PACKED ReadCpuInfo; > =20 > typedef struct ReadStorageElementInfo { > @@ -151,7 +151,7 @@ typedef struct ReadStorageElementInfo { > uint16_t assigned; > uint16_t standby; > uint8_t _reserved0[16 - 14]; /* 14-15 */ > - uint32_t entries[0]; > + uint32_t entries[]; > } QEMU_PACKED ReadStorageElementInfo; > =20 > typedef struct AttachStorageElement { > @@ -159,7 +159,7 @@ typedef struct AttachStorageElement { > uint8_t _reserved0[10 - 8]; /* 8-9 */ > uint16_t assigned; > uint8_t _reserved1[16 - 12]; /* 12-15 */ > - uint32_t entries[0]; > + uint32_t entries[]; > } QEMU_PACKED AttachStorageElement; > =20 > typedef struct AssignStorage { > diff --git a/block/vmdk.c b/block/vmdk.c > index 20e909d997..8466051bc9 100644 > --- a/block/vmdk.c > +++ b/block/vmdk.c > @@ -187,7 +187,7 @@ typedef struct VmdkMetaData { > typedef struct VmdkGrainMarker { > uint64_t lba; > uint32_t size; > - uint8_t data[0]; > + uint8_t data[]; > } QEMU_PACKED VmdkGrainMarker; > =20 > enum { > diff --git a/hw/char/sclpconsole-lm.c b/hw/char/sclpconsole-lm.c > index c420dc066e..2b5f37b6a2 100644 > --- a/hw/char/sclpconsole-lm.c > +++ b/hw/char/sclpconsole-lm.c > @@ -31,7 +31,7 @@ > typedef struct OprtnsCommand { > EventBufferHeader header; > MDMSU message_unit; > - char data[0]; > + char data[]; > } QEMU_PACKED OprtnsCommand; > =20 > /* max size for line-mode data in 4K SCCB page */ > diff --git a/hw/char/sclpconsole.c b/hw/char/sclpconsole.c > index 1fa124dab9..5c7664905e 100644 > --- a/hw/char/sclpconsole.c > +++ b/hw/char/sclpconsole.c > @@ -25,7 +25,7 @@ > =20 > typedef struct ASCIIConsoleData { > EventBufferHeader ebh; > - char data[0]; > + char data[]; > } QEMU_PACKED ASCIIConsoleData; > =20 > /* max size for ASCII data in 4K SCCB page */ > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c > index 50cf95b781..64f928fc7d 100644 > --- a/hw/s390x/virtio-ccw.c > +++ b/hw/s390x/virtio-ccw.c > @@ -193,7 +193,7 @@ typedef struct VirtioThinintInfo { > typedef struct VirtioRevInfo { > uint16_t revision; > uint16_t length; > - uint8_t data[0]; > + uint8_t data[]; > } QEMU_PACKED VirtioRevInfo; > =20 > /* Specify where the virtqueues for the subchannel are in guest memory. = */ > diff --git a/target/s390x/ioinst.c b/target/s390x/ioinst.c > index c437a1d8c6..0e840cc579 100644 > --- a/target/s390x/ioinst.c > +++ b/target/s390x/ioinst.c > @@ -347,7 +347,7 @@ typedef struct ChscResp { > uint16_t len; > uint16_t code; > uint32_t param; > - char data[0]; > + char data[]; > } QEMU_PACKED ChscResp; > =20 > #define CHSC_MIN_RESP_LEN 0x0008 > --=20 > 2.21.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F9F1C18E5F for ; Sun, 8 Mar 2020 07:56:46 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB7FB20663 for ; Sun, 8 Mar 2020 07:56:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e0i5cehi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB7FB20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jAqnY-0000Ra-Vf; Sun, 08 Mar 2020 07:56:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jAqnY-0000RT-3N for xen-devel@lists.xenproject.org; Sun, 08 Mar 2020 07:56:32 +0000 X-Inumbo-ID: 51d797bd-6112-11ea-ab0a-12813bfff9fa Received: from us-smtp-1.mimecast.com (unknown [207.211.31.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 51d797bd-6112-11ea-ab0a-12813bfff9fa; Sun, 08 Mar 2020 07:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583654189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ynFyiQeM454w8E0H4H7s8WljySZMe1a49ecpNjlpYQM=; b=e0i5cehiLuL2uCYC5518ZvID5Dbwy44ZToGOlkTEs/l/FLu4SeXtSXmOrhSjbogrFqbSyk nB5i50hFe0ksRHtusNjpuc1MUd8RIfZfHXjUZ8nbli504Az0UiHH+MPuEBiAng2QZ97Byf Z5aXpv7AkwiW8E2v6iVtF28xJth+iUU= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-pZMqIM3xMumoCij1Lisxng-1; Sun, 08 Mar 2020 03:56:27 -0400 X-MC-Unique: pZMqIM3xMumoCij1Lisxng-1 Received: by mail-qv1-f71.google.com with SMTP id d7so4623200qvq.12 for ; Sat, 07 Mar 2020 23:56:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=eNlNeV0cCqtLqdRwzb8GyuXIKo2c9XoG4YAsMmS1GFs=; b=G6c7WOjFwwcpl65ptjVhhFkfypDrfucXKG0HiC93s4COUnalprNBrqYiquRMyyzIMY jrGhjDXIHwH8CjBbfhHU9Gvija8Pv2x1TaGK1oUwXYThV5MIhjxmVRtmnaVRbrJ0VOlS gWqEfEgUHPkCjxa0gW4uxPltRkwM+3DnaT/U5ZH9V9eKwo9sYpkLpOf9G9TVJqSLEPvS V2f8qYOTZaj1bCVruo/PNY+G92Zj34W5iQPXkMGdxjRG7NPSQlmcXKzxzhGsAXq4sz1P 1PzO43LmfYGCBLPOJoHe51qHAIOt4sUwG3UEgnCoZMjKz4X7h2wDFooVHb5H9e6iSd4+ oB5Q== X-Gm-Message-State: ANhLgQ1eFYhNkBARORTkzAPqbRKVRicGVViYgfyCULF5vAPg87q0VFem +QCy++cMavJBRAl/WfYl7+0UjEzEcNAGK2mXDfrhIg4O+wVFKvYvmQZcN8JKjb7wv5bhPMd4l1v UnDHIk9qBLThTZJrDBKhIs4xP2uI= X-Received: by 2002:a37:b902:: with SMTP id j2mr8192014qkf.247.1583654187092; Sat, 07 Mar 2020 23:56:27 -0800 (PST) X-Google-Smtp-Source: ADFU+vuID5MQrlw0vlf04kMS2QniRJdQNH+wTNGYgD6Nv71XEqwNm6ZQGuLqxsUZ0Nu+o3VWZWrGcw== X-Received: by 2002:a37:b902:: with SMTP id j2mr8191977qkf.247.1583654186728; Sat, 07 Mar 2020 23:56:26 -0800 (PST) Received: from redhat.com (bzq-79-178-2-19.red.bezeqint.net. [79.178.2.19]) by smtp.gmail.com with ESMTPSA id t55sm21320959qte.24.2020.03.07.23.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2020 23:56:26 -0800 (PST) Date: Sun, 8 Mar 2020 03:56:16 -0400 From: "Michael S. Tsirkin" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Message-ID: <20200308035558-mutt-send-email-mst@kernel.org> References: <20200304153816.23636-1-philmd@redhat.com> <20200304153816.23636-3-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200304153816.23636-3-philmd@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Subject: Re: [Xen-devel] [PATCH v2 2/2] misc: Replace zero-length arrays with flexible array member (manual) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Paul Durrant , Jason Wang , qemu-devel@nongnu.org, Gerd Hoffmann , Stefano Stabellini , qemu-block@nongnu.org, David Hildenbrand , "Gustavo A . R . Silva" , Halil Pasic , Christian Borntraeger , "Gonglei \(Arei\)" , Marcel Apfelbaum , Anthony Perard , xen-devel@lists.xenproject.org, Thomas Huth , Eduardo Habkost , Yuval Shaia , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Paolo Bonzini , John Snow , Richard Henderson , Kevin Wolf , Xiao Guangrong , Eric Auger , Cornelia Huck , Laurent Vivier , Max Reitz , Igor Mammedov Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gV2VkLCBNYXIgMDQsIDIwMjAgYXQgMDQ6Mzg6MTZQTSArMDEwMCwgUGhpbGlwcGUgTWF0aGll dS1EYXVkw6kgd3JvdGU6Cj4gRGVzY3JpcHRpb24gY29waWVkIGZyb20gTGludXgga2VybmVsIGNv bW1pdCBmcm9tIEd1c3Rhdm8gQS4gUi4gU2lsdmEKPiAoc2VlIFszXSk6Cj4gCj4gLS12LS0gZGVz Y3JpcHRpb24gc3RhcnQgLS12LS0KPiAKPiAgIFRoZSBjdXJyZW50IGNvZGViYXNlIG1ha2VzIHVz ZSBvZiB0aGUgemVyby1sZW5ndGggYXJyYXkgbGFuZ3VhZ2UKPiAgIGV4dGVuc2lvbiB0byB0aGUg QzkwIHN0YW5kYXJkLCBidXQgdGhlIHByZWZlcnJlZCBtZWNoYW5pc20gdG8KPiAgIGRlY2xhcmUg dmFyaWFibGUtbGVuZ3RoIHR5cGVzIHN1Y2ggYXMgdGhlc2Ugb25lcyBpcyBhIGZsZXhpYmxlCj4g ICBhcnJheSBtZW1iZXIgWzFdLCBpbnRyb2R1Y2VkIGluIEM5OToKPiAKPiAgIHN0cnVjdCBmb28g ewo+ICAgICAgIGludCBzdHVmZjsKPiAgICAgICBzdHJ1Y3QgYm9vIGFycmF5W107Cj4gICB9Owo+ IAo+ICAgQnkgbWFraW5nIHVzZSBvZiB0aGUgbWVjaGFuaXNtIGFib3ZlLCB3ZSB3aWxsIGdldCBh IGNvbXBpbGVyCj4gICB3YXJuaW5nIGluIGNhc2UgdGhlIGZsZXhpYmxlIGFycmF5IGRvZXMgbm90 IG9jY3VyIGxhc3QgaW4gdGhlCj4gICBzdHJ1Y3R1cmUsIHdoaWNoIHdpbGwgaGVscCB1cyBwcmV2 ZW50IHNvbWUga2luZCBvZiB1bmRlZmluZWQKPiAgIGJlaGF2aW9yIGJ1Z3MgZnJvbSBiZWluZyB1 bmFkdmVydGVubHkgaW50cm9kdWNlZCBbMl0gdG8gdGhlCj4gICBMaW51eCBjb2RlYmFzZSBmcm9t IG5vdyBvbi4KPiAKPiAtLV4tLSBkZXNjcmlwdGlvbiBlbmQgLS1eLS0KPiAKPiBEbyB0aGUgc2lt aWxhciBob3VzZWtlZXBpbmcgaW4gdGhlIFFFTVUgY29kZWJhc2UgKHdoaWNoIHVzZXMKPiBDOTkg c2luY2UgY29tbWl0IDdiZTQxNjc1ZjdjYikuCj4gCj4gQWxsIHRoZXNlIGluc3RhbmNlcyBvZiBj b2RlIHdlcmUgZm91bmQgd2l0aCB0aGUgaGVscCBvZiB0aGUKPiBmb2xsb3dpbmcgY29tbWFuZCAo dGhlbiBtYW51YWwgYW5hbHlzaXMsIHdpdGhvdXQgbW9kaWZ5aW5nCj4gc3RydWN0dXJlcyBvbmx5 IGhhdmluZyBhIHNpbmdsZSBmbGV4aWJsZSBhcnJheSBtZW1iZXIsIHN1Y2gKPiBRRURUYWJsZSBp biBibG9jay9xZWQuaCk6Cj4gCj4gICBnaXQgZ3JlcCAtRiAnWzBdOycKPiAKPiBbMV0gaHR0cHM6 Ly9nY2MuZ251Lm9yZy9vbmxpbmVkb2NzL2djYy9aZXJvLUxlbmd0aC5odG1sCj4gWzJdIGh0dHBz Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4 LmdpdC9jb21taXQvP2lkPTc2NDk3NzMyOTMyZgo+IFszXSBodHRwczovL2dpdC5rZXJuZWwub3Jn L3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9ndXN0YXZvYXJzL2xpbnV4LmdpdC9jb21taXQvP2lk PTE3NjQyYTJmYmQyYzEKPiAKPiBJbnNwaXJlZC1ieTogR3VzdGF2byBBLiBSLiBTaWx2YSA8Z3Vz dGF2b0BlbWJlZGRlZG9yLmNvbT4KPiBSZXZpZXdlZC1ieTogRGF2aWQgSGlsZGVuYnJhbmQgPGRh dmlkQHJlZGhhdC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUGhpbGlwcGUgTWF0aGlldS1EYXVkw6kg PHBoaWxtZEByZWRoYXQuY29tPgoKUmV2aWV3ZWQtYnk6IE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0 QHJlZGhhdC5jb20+CgoKCj4gLS0tCj4gdjI6IERvIG5vdCBtb2RpZnkgYmxvY2svcWVkLmg6Cj4g Cj4gICBibG9jay9xZWQuaDoxMDY6MTQ6IGVycm9yOiBmbGV4aWJsZSBhcnJheSBtZW1iZXIgJ29m ZnNldHMnIG5vdCBhbGxvd2VkIGluIG90aGVyd2lzZSBlbXB0eSBzdHJ1Y3QKPiAgICAgICB1aW50 NjRfdCBvZmZzZXRzW107ICAgICAgICAgICAgIC8qIGluIGJ5dGVzICovCj4gICAgICAgICAgICAg ICAgXgo+IC0tLQo+ICBkb2NzL2ludGVyb3Avdmhvc3QtdXNlci5yc3QgICAgICAgfCA0ICsrLS0K PiAgaW5jbHVkZS9ody9hY3BpL2FjcGktZGVmcy5oICAgICAgIHwgNCArKy0tCj4gIGluY2x1ZGUv aHcvYm9hcmRzLmggICAgICAgICAgICAgICB8IDIgKy0KPiAgaW5jbHVkZS9ody9zMzkweC9ldmVu dC1mYWNpbGl0eS5oIHwgMiArLQo+ICBpbmNsdWRlL2h3L3MzOTB4L3NjbHAuaCAgICAgICAgICAg fCA4ICsrKystLS0tCj4gIGJsb2NrL3ZtZGsuYyAgICAgICAgICAgICAgICAgICAgICB8IDIgKy0K PiAgaHcvY2hhci9zY2xwY29uc29sZS1sbS5jICAgICAgICAgIHwgMiArLQo+ICBody9jaGFyL3Nj bHBjb25zb2xlLmMgICAgICAgICAgICAgfCAyICstCj4gIGh3L3MzOTB4L3ZpcnRpby1jY3cuYyAg ICAgICAgICAgICB8IDIgKy0KPiAgdGFyZ2V0L3MzOTB4L2lvaW5zdC5jICAgICAgICAgICAgIHwg MiArLQo+ICAxMCBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZG9jcy9pbnRlcm9wL3Zob3N0LXVzZXIucnN0IGIvZG9jcy9p bnRlcm9wL3Zob3N0LXVzZXIucnN0Cj4gaW5kZXggNDAxNjUyMzk3Yy4uM2IxYjY2MDJjNyAxMDA2 NDQKPiAtLS0gYS9kb2NzL2ludGVyb3Avdmhvc3QtdXNlci5yc3QKPiArKysgYi9kb2NzL2ludGVy b3Avdmhvc3QtdXNlci5yc3QKPiBAQCAtNTY4LDcgKzU2OCw3IEBAIEZvciBzcGxpdCB2aXJ0cXVl dWUsIHF1ZXVlIHJlZ2lvbiBjYW4gYmUgaW1wbGVtZW50ZWQgYXM6Cj4gICAgICAgIHVpbnQxNl90 IHVzZWRfaWR4Owo+ICAKPiAgICAgICAgLyogVXNlZCB0byB0cmFjayB0aGUgc3RhdGUgb2YgZWFj aCBkZXNjcmlwdG9yIGluIGRlc2NyaXB0b3IgdGFibGUgKi8KPiAtICAgICAgRGVzY1N0YXRlU3Bs aXQgZGVzY1swXTsKPiArICAgICAgRGVzY1N0YXRlU3BsaXQgZGVzY1tdOwo+ICAgIH0gUXVldWVS ZWdpb25TcGxpdDsKPiAgCj4gIFRvIHRyYWNrIGluZmxpZ2h0IEkvTywgdGhlIHF1ZXVlIHJlZ2lv biBzaG91bGQgYmUgcHJvY2Vzc2VkIGFzIGZvbGxvd3M6Cj4gQEAgLTY5MCw3ICs2OTAsNyBAQCBG b3IgcGFja2VkIHZpcnRxdWV1ZSwgcXVldWUgcmVnaW9uIGNhbiBiZSBpbXBsZW1lbnRlZCBhczoK PiAgICAgICAgdWludDhfdCBwYWRkaW5nWzddOwo+ICAKPiAgICAgICAgLyogVXNlZCB0byB0cmFj ayB0aGUgc3RhdGUgb2YgZWFjaCBkZXNjcmlwdG9yIGZldGNoZWQgZnJvbSBkZXNjcmlwdG9yIHJp bmcgKi8KPiAtICAgICAgRGVzY1N0YXRlUGFja2VkIGRlc2NbMF07Cj4gKyAgICAgIERlc2NTdGF0 ZVBhY2tlZCBkZXNjW107Cj4gICAgfSBRdWV1ZVJlZ2lvblBhY2tlZDsKPiAgCj4gIFRvIHRyYWNr IGluZmxpZ2h0IEkvTywgdGhlIHF1ZXVlIHJlZ2lvbiBzaG91bGQgYmUgcHJvY2Vzc2VkIGFzIGZv bGxvd3M6Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvaHcvYWNwaS9hY3BpLWRlZnMuaCBiL2luY2x1 ZGUvaHcvYWNwaS9hY3BpLWRlZnMuaAo+IGluZGV4IDE5ZjdiYTdiNzAuLmMxMzMyN2ZhNzggMTAw NjQ0Cj4gLS0tIGEvaW5jbHVkZS9ody9hY3BpL2FjcGktZGVmcy5oCj4gKysrIGIvaW5jbHVkZS9o dy9hY3BpL2FjcGktZGVmcy5oCj4gQEAgLTE1Miw3ICsxNTIsNyBAQCB0eXBlZGVmIHN0cnVjdCBB Y3BpU2VyaWFsUG9ydENvbnNvbGVSZWRpcmVjdGlvbgo+ICAgKi8KPiAgc3RydWN0IEFjcGlSc2R0 RGVzY3JpcHRvclJldjEgewo+ICAgICAgQUNQSV9UQUJMRV9IRUFERVJfREVGICAgICAgIC8qIEFD UEkgY29tbW9uIHRhYmxlIGhlYWRlciAqLwo+IC0gICAgdWludDMyX3QgdGFibGVfb2Zmc2V0X2Vu dHJ5WzBdOyAgLyogQXJyYXkgb2YgcG9pbnRlcnMgdG8gb3RoZXIgKi8KPiArICAgIHVpbnQzMl90 IHRhYmxlX29mZnNldF9lbnRyeVtdOyAgLyogQXJyYXkgb2YgcG9pbnRlcnMgdG8gb3RoZXIgKi8K PiAgICAgIC8qIEFDUEkgdGFibGVzICovCj4gIH0gUUVNVV9QQUNLRUQ7Cj4gIHR5cGVkZWYgc3Ry dWN0IEFjcGlSc2R0RGVzY3JpcHRvclJldjEgQWNwaVJzZHREZXNjcmlwdG9yUmV2MTsKPiBAQCAt MTYyLDcgKzE2Miw3IEBAIHR5cGVkZWYgc3RydWN0IEFjcGlSc2R0RGVzY3JpcHRvclJldjEgQWNw aVJzZHREZXNjcmlwdG9yUmV2MTsKPiAgICovCj4gIHN0cnVjdCBBY3BpWHNkdERlc2NyaXB0b3JS ZXYyIHsKPiAgICAgIEFDUElfVEFCTEVfSEVBREVSX0RFRiAgICAgICAvKiBBQ1BJIGNvbW1vbiB0 YWJsZSBoZWFkZXIgKi8KPiAtICAgIHVpbnQ2NF90IHRhYmxlX29mZnNldF9lbnRyeVswXTsgIC8q IEFycmF5IG9mIHBvaW50ZXJzIHRvIG90aGVyICovCj4gKyAgICB1aW50NjRfdCB0YWJsZV9vZmZz ZXRfZW50cnlbXTsgIC8qIEFycmF5IG9mIHBvaW50ZXJzIHRvIG90aGVyICovCj4gICAgICAvKiBB Q1BJIHRhYmxlcyAqLwo+ICB9IFFFTVVfUEFDS0VEOwo+ICB0eXBlZGVmIHN0cnVjdCBBY3BpWHNk dERlc2NyaXB0b3JSZXYyIEFjcGlYc2R0RGVzY3JpcHRvclJldjI7Cj4gZGlmZiAtLWdpdCBhL2lu Y2x1ZGUvaHcvYm9hcmRzLmggYi9pbmNsdWRlL2h3L2JvYXJkcy5oCj4gaW5kZXggOWJjNDJkZmIy Mi4uYzk2MTIwZDE1ZiAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2h3L2JvYXJkcy5oCj4gKysrIGIv aW5jbHVkZS9ody9ib2FyZHMuaAo+IEBAIC03MSw3ICs3MSw3IEBAIHR5cGVkZWYgc3RydWN0IENQ VUFyY2hJZCB7Cj4gICAqLwo+ICB0eXBlZGVmIHN0cnVjdCB7Cj4gICAgICBpbnQgbGVuOwo+IC0g ICAgQ1BVQXJjaElkIGNwdXNbMF07Cj4gKyAgICBDUFVBcmNoSWQgY3B1c1tdOwo+ICB9IENQVUFy Y2hJZExpc3Q7Cj4gIAo+ICAvKioKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9ody9zMzkweC9ldmVu dC1mYWNpbGl0eS5oIGIvaW5jbHVkZS9ody9zMzkweC9ldmVudC1mYWNpbGl0eS5oCj4gaW5kZXgg YmRjMzJhM2MwOS4uNzAwYTYxMGYzMyAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2h3L3MzOTB4L2V2 ZW50LWZhY2lsaXR5LmgKPiArKysgYi9pbmNsdWRlL2h3L3MzOTB4L2V2ZW50LWZhY2lsaXR5LmgK PiBAQCAtMTIyLDcgKzEyMiw3IEBAIHR5cGVkZWYgc3RydWN0IE1EQk8gewo+ICAKPiAgdHlwZWRl ZiBzdHJ1Y3QgTURCIHsKPiAgICAgIE1kYkhlYWRlciBoZWFkZXI7Cj4gLSAgICBNREJPIG1kYm9b MF07Cj4gKyAgICBNREJPIG1kYm9bXTsKPiAgfSBRRU1VX1BBQ0tFRCBNREI7Cj4gIAo+ICB0eXBl ZGVmIHN0cnVjdCBTY2xwTXNnIHsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9ody9zMzkweC9zY2xw LmggYi9pbmNsdWRlL2h3L3MzOTB4L3NjbHAuaAo+IGluZGV4IGM1NDQxM2I3OGMuLmNkN2IyNDM1 OWYgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9ody9zMzkweC9zY2xwLmgKPiArKysgYi9pbmNsdWRl L2h3L3MzOTB4L3NjbHAuaAo+IEBAIC0xMzIsNyArMTMyLDcgQEAgdHlwZWRlZiBzdHJ1Y3QgUmVh ZEluZm8gewo+ICAgICAgdWludDE2X3QgaGlnaGVzdF9jcHU7Cj4gICAgICB1aW50OF90ICBfcmVz ZXJ2ZWQ1WzEyNCAtIDEyMl07ICAgICAvKiAxMjItMTIzICovCj4gICAgICB1aW50MzJfdCBobWZh aTsKPiAtICAgIHN0cnVjdCBDUFVFbnRyeSBlbnRyaWVzWzBdOwo+ICsgICAgc3RydWN0IENQVUVu dHJ5IGVudHJpZXNbXTsKPiAgfSBRRU1VX1BBQ0tFRCBSZWFkSW5mbzsKPiAgCj4gIHR5cGVkZWYg c3RydWN0IFJlYWRDcHVJbmZvIHsKPiBAQCAtMTQyLDcgKzE0Miw3IEBAIHR5cGVkZWYgc3RydWN0 IFJlYWRDcHVJbmZvIHsKPiAgICAgIHVpbnQxNl90IG5yX3N0YW5kYnk7ICAgICAgICAgICAgLyog MTItMTMgKi8KPiAgICAgIHVpbnQxNl90IG9mZnNldF9zdGFuZGJ5OyAgICAgICAgLyogMTQtMTUg Ki8KPiAgICAgIHVpbnQ4X3QgcmVzZXJ2ZWQwWzI0LTE2XTsgICAgICAgLyogMTYtMjMgKi8KPiAt ICAgIHN0cnVjdCBDUFVFbnRyeSBlbnRyaWVzWzBdOwo+ICsgICAgc3RydWN0IENQVUVudHJ5IGVu dHJpZXNbXTsKPiAgfSBRRU1VX1BBQ0tFRCBSZWFkQ3B1SW5mbzsKPiAgCj4gIHR5cGVkZWYgc3Ry dWN0IFJlYWRTdG9yYWdlRWxlbWVudEluZm8gewo+IEBAIC0xNTEsNyArMTUxLDcgQEAgdHlwZWRl ZiBzdHJ1Y3QgUmVhZFN0b3JhZ2VFbGVtZW50SW5mbyB7Cj4gICAgICB1aW50MTZfdCBhc3NpZ25l ZDsKPiAgICAgIHVpbnQxNl90IHN0YW5kYnk7Cj4gICAgICB1aW50OF90IF9yZXNlcnZlZDBbMTYg LSAxNF07IC8qIDE0LTE1ICovCj4gLSAgICB1aW50MzJfdCBlbnRyaWVzWzBdOwo+ICsgICAgdWlu dDMyX3QgZW50cmllc1tdOwo+ICB9IFFFTVVfUEFDS0VEIFJlYWRTdG9yYWdlRWxlbWVudEluZm87 Cj4gIAo+ICB0eXBlZGVmIHN0cnVjdCBBdHRhY2hTdG9yYWdlRWxlbWVudCB7Cj4gQEAgLTE1OSw3 ICsxNTksNyBAQCB0eXBlZGVmIHN0cnVjdCBBdHRhY2hTdG9yYWdlRWxlbWVudCB7Cj4gICAgICB1 aW50OF90IF9yZXNlcnZlZDBbMTAgLSA4XTsgIC8qIDgtOSAqLwo+ICAgICAgdWludDE2X3QgYXNz aWduZWQ7Cj4gICAgICB1aW50OF90IF9yZXNlcnZlZDFbMTYgLSAxMl07IC8qIDEyLTE1ICovCj4g LSAgICB1aW50MzJfdCBlbnRyaWVzWzBdOwo+ICsgICAgdWludDMyX3QgZW50cmllc1tdOwo+ICB9 IFFFTVVfUEFDS0VEIEF0dGFjaFN0b3JhZ2VFbGVtZW50Owo+ICAKPiAgdHlwZWRlZiBzdHJ1Y3Qg QXNzaWduU3RvcmFnZSB7Cj4gZGlmZiAtLWdpdCBhL2Jsb2NrL3ZtZGsuYyBiL2Jsb2NrL3ZtZGsu Ywo+IGluZGV4IDIwZTkwOWQ5OTcuLjg0NjYwNTFiYzkgMTAwNjQ0Cj4gLS0tIGEvYmxvY2svdm1k ay5jCj4gKysrIGIvYmxvY2svdm1kay5jCj4gQEAgLTE4Nyw3ICsxODcsNyBAQCB0eXBlZGVmIHN0 cnVjdCBWbWRrTWV0YURhdGEgewo+ICB0eXBlZGVmIHN0cnVjdCBWbWRrR3JhaW5NYXJrZXIgewo+ ICAgICAgdWludDY0X3QgbGJhOwo+ICAgICAgdWludDMyX3Qgc2l6ZTsKPiAtICAgIHVpbnQ4X3Qg IGRhdGFbMF07Cj4gKyAgICB1aW50OF90ICBkYXRhW107Cj4gIH0gUUVNVV9QQUNLRUQgVm1ka0dy YWluTWFya2VyOwo+ICAKPiAgZW51bSB7Cj4gZGlmZiAtLWdpdCBhL2h3L2NoYXIvc2NscGNvbnNv bGUtbG0uYyBiL2h3L2NoYXIvc2NscGNvbnNvbGUtbG0uYwo+IGluZGV4IGM0MjBkYzA2NmUuLjJi NWYzN2I2YTIgMTAwNjQ0Cj4gLS0tIGEvaHcvY2hhci9zY2xwY29uc29sZS1sbS5jCj4gKysrIGIv aHcvY2hhci9zY2xwY29uc29sZS1sbS5jCj4gQEAgLTMxLDcgKzMxLDcgQEAKPiAgdHlwZWRlZiBz dHJ1Y3QgT3BydG5zQ29tbWFuZCB7Cj4gICAgICBFdmVudEJ1ZmZlckhlYWRlciBoZWFkZXI7Cj4g ICAgICBNRE1TVSBtZXNzYWdlX3VuaXQ7Cj4gLSAgICBjaGFyIGRhdGFbMF07Cj4gKyAgICBjaGFy IGRhdGFbXTsKPiAgfSBRRU1VX1BBQ0tFRCBPcHJ0bnNDb21tYW5kOwo+ICAKPiAgLyogbWF4IHNp emUgZm9yIGxpbmUtbW9kZSBkYXRhIGluIDRLIFNDQ0IgcGFnZSAqLwo+IGRpZmYgLS1naXQgYS9o dy9jaGFyL3NjbHBjb25zb2xlLmMgYi9ody9jaGFyL3NjbHBjb25zb2xlLmMKPiBpbmRleCAxZmEx MjRkYWI5Li41Yzc2NjQ5MDVlIDEwMDY0NAo+IC0tLSBhL2h3L2NoYXIvc2NscGNvbnNvbGUuYwo+ ICsrKyBiL2h3L2NoYXIvc2NscGNvbnNvbGUuYwo+IEBAIC0yNSw3ICsyNSw3IEBACj4gIAo+ICB0 eXBlZGVmIHN0cnVjdCBBU0NJSUNvbnNvbGVEYXRhIHsKPiAgICAgIEV2ZW50QnVmZmVySGVhZGVy IGViaDsKPiAtICAgIGNoYXIgZGF0YVswXTsKPiArICAgIGNoYXIgZGF0YVtdOwo+ICB9IFFFTVVf UEFDS0VEIEFTQ0lJQ29uc29sZURhdGE7Cj4gIAo+ICAvKiBtYXggc2l6ZSBmb3IgQVNDSUkgZGF0 YSBpbiA0SyBTQ0NCIHBhZ2UgKi8KPiBkaWZmIC0tZ2l0IGEvaHcvczM5MHgvdmlydGlvLWNjdy5j IGIvaHcvczM5MHgvdmlydGlvLWNjdy5jCj4gaW5kZXggNTBjZjk1Yjc4MS4uNjRmOTI4ZmM3ZCAx MDA2NDQKPiAtLS0gYS9ody9zMzkweC92aXJ0aW8tY2N3LmMKPiArKysgYi9ody9zMzkweC92aXJ0 aW8tY2N3LmMKPiBAQCAtMTkzLDcgKzE5Myw3IEBAIHR5cGVkZWYgc3RydWN0IFZpcnRpb1RoaW5p bnRJbmZvIHsKPiAgdHlwZWRlZiBzdHJ1Y3QgVmlydGlvUmV2SW5mbyB7Cj4gICAgICB1aW50MTZf dCByZXZpc2lvbjsKPiAgICAgIHVpbnQxNl90IGxlbmd0aDsKPiAtICAgIHVpbnQ4X3QgZGF0YVsw XTsKPiArICAgIHVpbnQ4X3QgZGF0YVtdOwo+ICB9IFFFTVVfUEFDS0VEIFZpcnRpb1JldkluZm87 Cj4gIAo+ICAvKiBTcGVjaWZ5IHdoZXJlIHRoZSB2aXJ0cXVldWVzIGZvciB0aGUgc3ViY2hhbm5l bCBhcmUgaW4gZ3Vlc3QgbWVtb3J5LiAqLwo+IGRpZmYgLS1naXQgYS90YXJnZXQvczM5MHgvaW9p bnN0LmMgYi90YXJnZXQvczM5MHgvaW9pbnN0LmMKPiBpbmRleCBjNDM3YTFkOGM2Li4wZTg0MGNj NTc5IDEwMDY0NAo+IC0tLSBhL3RhcmdldC9zMzkweC9pb2luc3QuYwo+ICsrKyBiL3RhcmdldC9z MzkweC9pb2luc3QuYwo+IEBAIC0zNDcsNyArMzQ3LDcgQEAgdHlwZWRlZiBzdHJ1Y3QgQ2hzY1Jl c3Agewo+ICAgICAgdWludDE2X3QgbGVuOwo+ICAgICAgdWludDE2X3QgY29kZTsKPiAgICAgIHVp bnQzMl90IHBhcmFtOwo+IC0gICAgY2hhciBkYXRhWzBdOwo+ICsgICAgY2hhciBkYXRhW107Cj4g IH0gUUVNVV9QQUNLRUQgQ2hzY1Jlc3A7Cj4gIAo+ICAjZGVmaW5lIENIU0NfTUlOX1JFU1BfTEVO IDB4MDAwOAo+IC0tIAo+IDIuMjEuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5m by94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF09C18E5B for ; Sun, 8 Mar 2020 07:57:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 461B520663 for ; Sun, 8 Mar 2020 07:57:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jBduEFCS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 461B520663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAqoU-0001UB-FF for qemu-devel@archiver.kernel.org; Sun, 08 Mar 2020 03:57:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46356) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAqnZ-0000aV-Tu for qemu-devel@nongnu.org; Sun, 08 Mar 2020 03:56:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAqnY-0001pY-5L for qemu-devel@nongnu.org; Sun, 08 Mar 2020 03:56:33 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:32112 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jAqnY-0001pH-0v for qemu-devel@nongnu.org; Sun, 08 Mar 2020 03:56:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583654191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ynFyiQeM454w8E0H4H7s8WljySZMe1a49ecpNjlpYQM=; b=jBduEFCSbSM7apkct5yLuJDHd35hP+R0cUAZ8c+F2bHTWMofYgv+4AyZBeHgqciTG7dsAK USsD7mJVEqZG5oX+XUEvwZS04Xe/gp2awFZX65xroFlLlSJs2UgWWBIOMnIOSZtxwqHb+p RoZ+bJVFtpJBW+Ce09TnaeVvTjoo+Xw= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-04fgkVpzMoqB3Ed0kXdICA-1; Sun, 08 Mar 2020 03:56:27 -0400 X-MC-Unique: 04fgkVpzMoqB3Ed0kXdICA-1 Received: by mail-qv1-f69.google.com with SMTP id u5so4618801qvj.10 for ; Sat, 07 Mar 2020 23:56:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=eNlNeV0cCqtLqdRwzb8GyuXIKo2c9XoG4YAsMmS1GFs=; b=E9nSpyuC9/Blu0ARjUlY6s+OBtIZ69506jTNAGMzO+ylLFykBbamSmYnRnzb0IRE1v Yy2/hjEJde4AIBSpyuTgsUVwxGFTN+DMSJDNg5ztgBvgwAK5fOolN2SSs0EC5fnnYmQN D2BV8ITLdgRIE15iNVPW8wJQxQm6BKoOXlUrr7wzyQxHSl0OL/YQ2B9PSkQRDUytmHvC 1NyNvn52E55H41Bom6RHoboYHTflG3mUI2XwhX4NawXhfbJAvCP63v2OMDOEwsD/w7J7 cGYA1YBtkcIBGeiIMqxXfhVCXE5E1JsAl2Xb4TAVhbU78ut4iEMB4A1YhZZlZUoMYEwQ RknA== X-Gm-Message-State: ANhLgQ3W9H8rkEFD2xC7z31ZnFYIb2V/uPC9nVzLM77OJKZqZ5cq4Ey6 XPqB1dMa+ZilC1fD/V0mWpehj7fStrK3qnLJ1eUx/gD+xeuGMVdDuac4Ug8yhnzziffZKgDVX8G po0sYEl0tJVOnBBY= X-Received: by 2002:a37:b902:: with SMTP id j2mr8192003qkf.247.1583654187091; Sat, 07 Mar 2020 23:56:27 -0800 (PST) X-Google-Smtp-Source: ADFU+vuID5MQrlw0vlf04kMS2QniRJdQNH+wTNGYgD6Nv71XEqwNm6ZQGuLqxsUZ0Nu+o3VWZWrGcw== X-Received: by 2002:a37:b902:: with SMTP id j2mr8191977qkf.247.1583654186728; Sat, 07 Mar 2020 23:56:26 -0800 (PST) Received: from redhat.com (bzq-79-178-2-19.red.bezeqint.net. [79.178.2.19]) by smtp.gmail.com with ESMTPSA id t55sm21320959qte.24.2020.03.07.23.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2020 23:56:26 -0800 (PST) Date: Sun, 8 Mar 2020 03:56:16 -0400 From: "Michael S. Tsirkin" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v2 2/2] misc: Replace zero-length arrays with flexible array member (manual) Message-ID: <20200308035558-mutt-send-email-mst@kernel.org> References: <20200304153816.23636-1-philmd@redhat.com> <20200304153816.23636-3-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200304153816.23636-3-philmd@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Paul Durrant , Jason Wang , qemu-devel@nongnu.org, Gerd Hoffmann , Stefano Stabellini , qemu-block@nongnu.org, David Hildenbrand , "Gustavo A . R . Silva" , Halil Pasic , Christian Borntraeger , "Gonglei \(Arei\)" , Anthony Perard , xen-devel@lists.xenproject.org, Thomas Huth , Eduardo Habkost , Yuval Shaia , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Paolo Bonzini , John Snow , Richard Henderson , Kevin Wolf , Xiao Guangrong , Eric Auger , Cornelia Huck , Laurent Vivier , Max Reitz , Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Mar 04, 2020 at 04:38:16PM +0100, Philippe Mathieu-Daud=E9 wrote: > Description copied from Linux kernel commit from Gustavo A. R. Silva > (see [3]): >=20 > --v-- description start --v-- >=20 > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to > declare variable-length types such as these ones is a flexible > array member [1], introduced in C99: >=20 > struct foo { > int stuff; > struct boo array[]; > }; >=20 > By making use of the mechanism above, we will get a compiler > warning in case the flexible array does not occur last in the > structure, which will help us prevent some kind of undefined > behavior bugs from being unadvertenly introduced [2] to the > Linux codebase from now on. >=20 > --^-- description end --^-- >=20 > Do the similar housekeeping in the QEMU codebase (which uses > C99 since commit 7be41675f7cb). >=20 > All these instances of code were found with the help of the > following command (then manual analysis, without modifying > structures only having a single flexible array member, such > QEDTable in block/qed.h): >=20 > git grep -F '[0];' >=20 > [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co= mmit/?id=3D76497732932f > [3] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/= commit/?id=3D17642a2fbd2c1 >=20 > Inspired-by: Gustavo A. R. Silva > Reviewed-by: David Hildenbrand > Signed-off-by: Philippe Mathieu-Daud=E9 Reviewed-by: Michael S. Tsirkin > --- > v2: Do not modify block/qed.h: >=20 > block/qed.h:106:14: error: flexible array member 'offsets' not allowed = in otherwise empty struct > uint64_t offsets[]; /* in bytes */ > ^ > --- > docs/interop/vhost-user.rst | 4 ++-- > include/hw/acpi/acpi-defs.h | 4 ++-- > include/hw/boards.h | 2 +- > include/hw/s390x/event-facility.h | 2 +- > include/hw/s390x/sclp.h | 8 ++++---- > block/vmdk.c | 2 +- > hw/char/sclpconsole-lm.c | 2 +- > hw/char/sclpconsole.c | 2 +- > hw/s390x/virtio-ccw.c | 2 +- > target/s390x/ioinst.c | 2 +- > 10 files changed, 15 insertions(+), 15 deletions(-) >=20 > diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst > index 401652397c..3b1b6602c7 100644 > --- a/docs/interop/vhost-user.rst > +++ b/docs/interop/vhost-user.rst > @@ -568,7 +568,7 @@ For split virtqueue, queue region can be implemented = as: > uint16_t used_idx; > =20 > /* Used to track the state of each descriptor in descriptor table = */ > - DescStateSplit desc[0]; > + DescStateSplit desc[]; > } QueueRegionSplit; > =20 > To track inflight I/O, the queue region should be processed as follows: > @@ -690,7 +690,7 @@ For packed virtqueue, queue region can be implemented= as: > uint8_t padding[7]; > =20 > /* Used to track the state of each descriptor fetched from descrip= tor ring */ > - DescStatePacked desc[0]; > + DescStatePacked desc[]; > } QueueRegionPacked; > =20 > To track inflight I/O, the queue region should be processed as follows: > diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h > index 19f7ba7b70..c13327fa78 100644 > --- a/include/hw/acpi/acpi-defs.h > +++ b/include/hw/acpi/acpi-defs.h > @@ -152,7 +152,7 @@ typedef struct AcpiSerialPortConsoleRedirection > */ > struct AcpiRsdtDescriptorRev1 { > ACPI_TABLE_HEADER_DEF /* ACPI common table header */ > - uint32_t table_offset_entry[0]; /* Array of pointers to other */ > + uint32_t table_offset_entry[]; /* Array of pointers to other */ > /* ACPI tables */ > } QEMU_PACKED; > typedef struct AcpiRsdtDescriptorRev1 AcpiRsdtDescriptorRev1; > @@ -162,7 +162,7 @@ typedef struct AcpiRsdtDescriptorRev1 AcpiRsdtDescrip= torRev1; > */ > struct AcpiXsdtDescriptorRev2 { > ACPI_TABLE_HEADER_DEF /* ACPI common table header */ > - uint64_t table_offset_entry[0]; /* Array of pointers to other */ > + uint64_t table_offset_entry[]; /* Array of pointers to other */ > /* ACPI tables */ > } QEMU_PACKED; > typedef struct AcpiXsdtDescriptorRev2 AcpiXsdtDescriptorRev2; > diff --git a/include/hw/boards.h b/include/hw/boards.h > index 9bc42dfb22..c96120d15f 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h > @@ -71,7 +71,7 @@ typedef struct CPUArchId { > */ > typedef struct { > int len; > - CPUArchId cpus[0]; > + CPUArchId cpus[]; > } CPUArchIdList; > =20 > /** > diff --git a/include/hw/s390x/event-facility.h b/include/hw/s390x/event-f= acility.h > index bdc32a3c09..700a610f33 100644 > --- a/include/hw/s390x/event-facility.h > +++ b/include/hw/s390x/event-facility.h > @@ -122,7 +122,7 @@ typedef struct MDBO { > =20 > typedef struct MDB { > MdbHeader header; > - MDBO mdbo[0]; > + MDBO mdbo[]; > } QEMU_PACKED MDB; > =20 > typedef struct SclpMsg { > diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h > index c54413b78c..cd7b24359f 100644 > --- a/include/hw/s390x/sclp.h > +++ b/include/hw/s390x/sclp.h > @@ -132,7 +132,7 @@ typedef struct ReadInfo { > uint16_t highest_cpu; > uint8_t _reserved5[124 - 122]; /* 122-123 */ > uint32_t hmfai; > - struct CPUEntry entries[0]; > + struct CPUEntry entries[]; > } QEMU_PACKED ReadInfo; > =20 > typedef struct ReadCpuInfo { > @@ -142,7 +142,7 @@ typedef struct ReadCpuInfo { > uint16_t nr_standby; /* 12-13 */ > uint16_t offset_standby; /* 14-15 */ > uint8_t reserved0[24-16]; /* 16-23 */ > - struct CPUEntry entries[0]; > + struct CPUEntry entries[]; > } QEMU_PACKED ReadCpuInfo; > =20 > typedef struct ReadStorageElementInfo { > @@ -151,7 +151,7 @@ typedef struct ReadStorageElementInfo { > uint16_t assigned; > uint16_t standby; > uint8_t _reserved0[16 - 14]; /* 14-15 */ > - uint32_t entries[0]; > + uint32_t entries[]; > } QEMU_PACKED ReadStorageElementInfo; > =20 > typedef struct AttachStorageElement { > @@ -159,7 +159,7 @@ typedef struct AttachStorageElement { > uint8_t _reserved0[10 - 8]; /* 8-9 */ > uint16_t assigned; > uint8_t _reserved1[16 - 12]; /* 12-15 */ > - uint32_t entries[0]; > + uint32_t entries[]; > } QEMU_PACKED AttachStorageElement; > =20 > typedef struct AssignStorage { > diff --git a/block/vmdk.c b/block/vmdk.c > index 20e909d997..8466051bc9 100644 > --- a/block/vmdk.c > +++ b/block/vmdk.c > @@ -187,7 +187,7 @@ typedef struct VmdkMetaData { > typedef struct VmdkGrainMarker { > uint64_t lba; > uint32_t size; > - uint8_t data[0]; > + uint8_t data[]; > } QEMU_PACKED VmdkGrainMarker; > =20 > enum { > diff --git a/hw/char/sclpconsole-lm.c b/hw/char/sclpconsole-lm.c > index c420dc066e..2b5f37b6a2 100644 > --- a/hw/char/sclpconsole-lm.c > +++ b/hw/char/sclpconsole-lm.c > @@ -31,7 +31,7 @@ > typedef struct OprtnsCommand { > EventBufferHeader header; > MDMSU message_unit; > - char data[0]; > + char data[]; > } QEMU_PACKED OprtnsCommand; > =20 > /* max size for line-mode data in 4K SCCB page */ > diff --git a/hw/char/sclpconsole.c b/hw/char/sclpconsole.c > index 1fa124dab9..5c7664905e 100644 > --- a/hw/char/sclpconsole.c > +++ b/hw/char/sclpconsole.c > @@ -25,7 +25,7 @@ > =20 > typedef struct ASCIIConsoleData { > EventBufferHeader ebh; > - char data[0]; > + char data[]; > } QEMU_PACKED ASCIIConsoleData; > =20 > /* max size for ASCII data in 4K SCCB page */ > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c > index 50cf95b781..64f928fc7d 100644 > --- a/hw/s390x/virtio-ccw.c > +++ b/hw/s390x/virtio-ccw.c > @@ -193,7 +193,7 @@ typedef struct VirtioThinintInfo { > typedef struct VirtioRevInfo { > uint16_t revision; > uint16_t length; > - uint8_t data[0]; > + uint8_t data[]; > } QEMU_PACKED VirtioRevInfo; > =20 > /* Specify where the virtqueues for the subchannel are in guest memory. = */ > diff --git a/target/s390x/ioinst.c b/target/s390x/ioinst.c > index c437a1d8c6..0e840cc579 100644 > --- a/target/s390x/ioinst.c > +++ b/target/s390x/ioinst.c > @@ -347,7 +347,7 @@ typedef struct ChscResp { > uint16_t len; > uint16_t code; > uint32_t param; > - char data[0]; > + char data[]; > } QEMU_PACKED ChscResp; > =20 > #define CHSC_MIN_RESP_LEN 0x0008 > --=20 > 2.21.1