From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1DF1C10DCE for ; Sun, 8 Mar 2020 14:39:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3AAE2087F for ; Sun, 8 Mar 2020 14:39:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VPWL3Qae"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="iJfYi7Es" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3AAE2087F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T39gAXhmzlW9oJlKFxNoThuXkCX2cqZLtw5fM1yB7V4=; b=VPWL3QaesXHLa4 LZBzxbq5HhGI9MBKx1mH+A7dBrj1uRcEtLNRWDw1gJggdfN+1jIageUojHgHWPPxMjTlGmqxx7mdO vNMQWqDV2s9Kb+nr6wCXtjBXQp89NBZWpDGINPiSiDcrWAI1Jsfl6YsLboujqvfvt2dK9mXqhFfhP sYvWu5i0gkTt8u+vVRMhma2hW9f20DmrLKXxMlZB+uZ+Ciw1Toi9v0H1PLCTShmX8C2UwnrzhZJto y/iE3oxtdedFQ+slYvs7GrmyBCvPBOPSTPqu3/8alqG1mhPf1XzWng3BII95p7dNc7UKitR8X7xMw HZEX4EwhgIaHd4z5Ufbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAx5G-0006mV-Jx; Sun, 08 Mar 2020 14:39:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAx5D-0006m8-SV for linux-riscv@lists.infradead.org; Sun, 08 Mar 2020 14:39:13 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C2C0206D7; Sun, 8 Mar 2020 14:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583678351; bh=AMd0h0/qwrlKb60N+y/bZccBrEPrwM6M0GofBq5BRyU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iJfYi7Es7/Rk36TmElQNtAtib6Gk+L5JPtAMRh5ULtEF68pz2E3sehoE/h0BApUbK 6jM8jMfUExCvJvhos19Fpgg4vUgjIcink8jVBn2APpB4LWyKcrLmMtvCxY/dqij0FN OZE4vjEBAT6ZyNPmBcBADNW0NjB1vh6c9/NWElAw= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jAx5B-00B39e-K4; Sun, 08 Mar 2020 14:39:09 +0000 Date: Sun, 8 Mar 2020 14:39:07 +0000 From: Marc Zyngier To: Atish Patra Subject: Re: [PATCH v3 1/2] irqchip/sifive-plic: Enable/Disable external interrupts upon cpu online/offline Message-ID: <20200308143907.51f8eddc@why> In-Reply-To: <20200308135931.331f9be4@why> References: <20200302231146.15530-1-atish.patra@wdc.com> <20200302231146.15530-2-atish.patra@wdc.com> <20200308135931.331f9be4@why> Organization: Approximate X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: atish.patra@wdc.com, linux-kernel@vger.kernel.org, anup@brainfault.org, aou@eecs.berkeley.edu, anju@linux.vnet.ibm.com, anup.patel@wdc.com, bp@suse.de, ebiederm@xmission.com, james.morse@arm.com, jason@lakedaemon.net, linux-riscv@lists.infradead.org, palmer@dabbelt.com, paul.walmsley@sifive.com, rafael.j.wysocki@intel.com, steven.price@arm.com, tglx@linutronix.de, ulf.hansson@linaro.org, vincent.chen@sifive.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200308_073911_938133_D663E111 X-CRM114-Status: GOOD ( 13.61 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Albert Ou , Jason Cooper , Anup Patel , Anup Patel , linux-kernel@vger.kernel.org, Steven Price , "Rafael J. Wysocki" , Vincent Chen , Anju T Sudhakar , James Morse , "Eric W. Biederman" , Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Borislav Petkov , Thomas Gleixner Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, 8 Mar 2020 13:59:31 +0000 Marc Zyngier wrote: > On Mon, 2 Mar 2020 15:11:45 -0800 > Atish Patra wrote: > > > Currently, PLIC threshold is only initialized once in the beginning. > > However, threshold can be set to disabled if a CPU is marked offline with > > CPU hotplug feature. This will not allow to change the irq affinity to a > > CPU that just came online. > > > > Add PLIC specific CPU hotplug callbacks and enable the threshold when a CPU > > comes online. Take this opportunity to move the external interrupt enable > > code from trap init to PLIC driver as well. On cpu offline path, the driver > > performs the exact opposite operations i.e. disable the interrupt and > > the threshold. > > > > Signed-off-by: Atish Patra > > Reviewed-by: Anup Patel > > Both patches queued for 5.7 (please add a cover letter when sending a > patch series). Apologies, there was a cover letter. I just messed my filters... ;-) M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5B4CC10F28 for ; Sun, 8 Mar 2020 14:39:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F87F2087F for ; Sun, 8 Mar 2020 14:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583678382; bh=AMd0h0/qwrlKb60N+y/bZccBrEPrwM6M0GofBq5BRyU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=DurnDAa3M4WvYdK37CaDJ6RkpC1T+UXEe3FfiluJUefz8VaSOD4jsyzzYi90Dwa2x kz3Doefnfr4LYODM5oA+KBDUAb7eq3/JaQztapOQoNeM9M7vj9oy213OhcKsC+c8rY rTDwsoD5WVSffDfqA0OkEXvJMwspwAhv1K176QKA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726354AbgCHOjM (ORCPT ); Sun, 8 Mar 2020 10:39:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:55192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbgCHOjM (ORCPT ); Sun, 8 Mar 2020 10:39:12 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C2C0206D7; Sun, 8 Mar 2020 14:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583678351; bh=AMd0h0/qwrlKb60N+y/bZccBrEPrwM6M0GofBq5BRyU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iJfYi7Es7/Rk36TmElQNtAtib6Gk+L5JPtAMRh5ULtEF68pz2E3sehoE/h0BApUbK 6jM8jMfUExCvJvhos19Fpgg4vUgjIcink8jVBn2APpB4LWyKcrLmMtvCxY/dqij0FN OZE4vjEBAT6ZyNPmBcBADNW0NjB1vh6c9/NWElAw= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jAx5B-00B39e-K4; Sun, 08 Mar 2020 14:39:09 +0000 Date: Sun, 8 Mar 2020 14:39:07 +0000 From: Marc Zyngier To: Atish Patra Cc: linux-kernel@vger.kernel.org, Anup Patel , Albert Ou , Anju T Sudhakar , Anup Patel , Borislav Petkov , "Eric W. Biederman" , James Morse , Jason Cooper , linux-riscv@lists.infradead.org, Palmer Dabbelt , Paul Walmsley , "Rafael J. Wysocki" , Steven Price , Thomas Gleixner , Ulf Hansson , Vincent Chen Subject: Re: [PATCH v3 1/2] irqchip/sifive-plic: Enable/Disable external interrupts upon cpu online/offline Message-ID: <20200308143907.51f8eddc@why> In-Reply-To: <20200308135931.331f9be4@why> References: <20200302231146.15530-1-atish.patra@wdc.com> <20200302231146.15530-2-atish.patra@wdc.com> <20200308135931.331f9be4@why> Organization: Approximate X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: atish.patra@wdc.com, linux-kernel@vger.kernel.org, anup@brainfault.org, aou@eecs.berkeley.edu, anju@linux.vnet.ibm.com, anup.patel@wdc.com, bp@suse.de, ebiederm@xmission.com, james.morse@arm.com, jason@lakedaemon.net, linux-riscv@lists.infradead.org, palmer@dabbelt.com, paul.walmsley@sifive.com, rafael.j.wysocki@intel.com, steven.price@arm.com, tglx@linutronix.de, ulf.hansson@linaro.org, vincent.chen@sifive.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 8 Mar 2020 13:59:31 +0000 Marc Zyngier wrote: > On Mon, 2 Mar 2020 15:11:45 -0800 > Atish Patra wrote: > > > Currently, PLIC threshold is only initialized once in the beginning. > > However, threshold can be set to disabled if a CPU is marked offline with > > CPU hotplug feature. This will not allow to change the irq affinity to a > > CPU that just came online. > > > > Add PLIC specific CPU hotplug callbacks and enable the threshold when a CPU > > comes online. Take this opportunity to move the external interrupt enable > > code from trap init to PLIC driver as well. On cpu offline path, the driver > > performs the exact opposite operations i.e. disable the interrupt and > > the threshold. > > > > Signed-off-by: Atish Patra > > Reviewed-by: Anup Patel > > Both patches queued for 5.7 (please add a cover letter when sending a > patch series). Apologies, there was a cover letter. I just messed my filters... ;-) M. -- Jazz is not dead. It just smells funny...