Re: [Outreachy kernel] Re: [PATCH] Staging: vt6655: device_main: cleanup long line

[Lourdes Pedrajas <lu@pplo.net>]

On Sun, Mar 08, 2020 at 03:50:09PM +0100, Julia Lawall wrote:
> On Sun, 8 Mar 2020, Lourdes Pedrajas wrote:
> 
> > On Sun, Mar 08, 2020 at 07:50:10AM +0100, Greg KH wrote:
> > > On Sun, Mar 08, 2020 at 12:06:31AM +0100, Lourdes Pedrajas wrote:
> > > > Code cleanup: long line found by checkpatch.
> > > >
> > > >  Changes to be committed:
> > > > 	modified:   drivers/staging/vt6655/device_main.c
> > >
> > > Why are these two lines in the changelog text?
> > >
> > My mistake, I thought it is correct to include them, sorry!
> 
> Take a quick look at https://lkml.org/ and see patches that other people
> have sent.  If you look at some examples, you will get some intuition
> about what information should be put where.
> 
> julia
> 
> 
Yes, thank you!

> >
> > > >
> > > > Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> > > > ---
> > > >  drivers/staging/vt6655/device_main.c | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> > > > index 0442f71494b2..88e1284a7743 100644
> > > > --- a/drivers/staging/vt6655/device_main.c
> > > > +++ b/drivers/staging/vt6655/device_main.c
> > > > @@ -1075,7 +1075,8 @@ static void vnt_interrupt_process(struct vnt_private *priv)
> > > >  			    priv->op_mode == NL80211_IFTYPE_ADHOC) &&
> > > >  			    priv->vif->bss_conf.enable_beacon) {
> > > >  				MACvOneShotTimer1MicroSec(priv,
> > > > -							  (priv->vif->bss_conf.beacon_int - MAKE_BEACON_RESERVED) << 10);
> > > > +					(priv->vif->bss_conf.beacon_int -
> > > > +					 MAKE_BEACON_RESERVED) << 10);
> > >
> > > Now you have another checkpatch warning :(
> > >
> > > THe original is fine, the line-length is a "strong hint" that sometimes
> > > needs to be gone over.
> > >
> > > sorry.
> > >
> > > greg k-h
> >
> > I also had my doubts about this one, thank you for clarifying!
> >
> > Lourdes.
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200308134915.GA4173%40supernova.
> >