From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH] drivers: virtio: Make out_del_vqs dependent on BALLOON_COMPACTION
Date: Sun, 8 Mar 2020 16:59:19 -0400 [thread overview]
Message-ID: <20200308165831-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <4AB99BBC-0EC7-40F0-96ED-04796A73CBA2@redhat.com>
On Sun, Mar 08, 2020 at 08:38:19PM +0100, David Hildenbrand wrote:
>
>
> > Am 06.03.2020 um 11:56 schrieb Vincenzo Frascino <vincenzo.frascino@arm.com>:
> >
> > out_del_vqs label is currently used only when BALLOON_COMPACTION
> > configuration option is enabled. Having it disabled triggers the
> > following warning at compile time:
> >
> > drivers/virtio/virtio_balloon.c: In function ‘virtballoon_probe’:
> > drivers/virtio/virtio_balloon.c:963:1: warning: label ‘out_del_vqs’
> > defined but not used [-Wunused-label]
> > 963 | out_del_vqs:
> > | ^~~~~~~~~~~
> >
> > Make out_del_vqs dependent on BALLOON_COMPACTION to address the
> > issue.
> >
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Cc: Jason Wang <jasowang@redhat.com>
> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>
> I think this is now the third patch on the list that tries to fix this warning.
>
> Michael, can we finally queue one of these (or is there one in -next already - did not check)?
>
> Thanks
It's queued in my tree (and will be in next eventually), I just didn't
send it to Linus yet.
Sorry about the delay.
--
MST
prev parent reply other threads:[~2020-03-08 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 10:55 [PATCH] drivers: virtio: Make out_del_vqs dependent on BALLOON_COMPACTION Vincenzo Frascino
2020-03-08 19:38 ` David Hildenbrand
2020-03-08 20:59 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200308165831-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=david@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.