diff for duplicates of <20200308214748.GL1094083@builder> diff --git a/a/1.txt b/N1/1.txt index b7e0e1b..73e53cd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -35,7 +35,7 @@ support, and then a second patch that adds wled5. > + brightness = low_limit; > + > + brightness_msb_mask = 0xf; -> + if (wled->max_brightness == WLED5_SINK_REG_BRIGHT_MAX_15B) +> + if (wled->max_brightness = WLED5_SINK_REG_BRIGHT_MAX_15B) > + brightness_msb_mask = 0x7f; Why not just brightness &= wled->max_brightness? But given that it seems @@ -65,7 +65,7 @@ skip this altogether? > + int rc; > + u8 val; > + -> + val = (wled->cfg.mod_sel == MOD_A) ? WLED5_SINK_REG_SYNC_MOD_A_BIT : +> + val = (wled->cfg.mod_sel = MOD_A) ? WLED5_SINK_REG_SYNC_MOD_A_BIT : > + WLED5_SINK_REG_SYNC_MOD_B_BIT; > + rc = regmap_update_bits(wled->regmap, > + wled->sink_addr + WLED5_SINK_REG_MOD_SYNC_BIT, diff --git a/a/content_digest b/N1/content_digest index a08afa0..40cae4f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,24 +2,24 @@ "ref\01583153739-19170-3-git-send-email-kgunda@codeaurora.org\0" "From\0Bjorn Andersson <bjorn.andersson@linaro.org>\0" "Subject\0Re: [PATCH V1 2/2] backlight: qcom-wled: Add support for WLED5 peripheral in PM8150L\0" - "Date\0Sun, 8 Mar 2020 14:47:48 -0700\0" + "Date\0Sun, 08 Mar 2020 21:47:48 +0000\0" "To\0Kiran Gunda <kgunda@codeaurora.org>\0" - "Cc\0jingoohan1@gmail.com" - lee.jones@linaro.org + "Cc\0mark.rutland@arm.com" + devicetree@vger.kernel.org + daniel.thompson@linaro.org b.zolnierkie@samsung.com + jingoohan1@gmail.com + Andy Gross <agross@kernel.org> + linux-kernel@vger.kernel.org dri-devel@lists.freedesktop.org - daniel.thompson@linaro.org + linux-fbdev@vger.kernel.org + robh+dt@kernel.org jacek.anaszewski@gmail.com pavel@ucw.cz - robh+dt@kernel.org - mark.rutland@arm.com - linux-leds@vger.kernel.org - devicetree@vger.kernel.org - linux-kernel@vger.kernel.org - Dan Murphy <dmurphy@ti.com> - Andy Gross <agross@kernel.org> linux-arm-msm@vger.kernel.org - " linux-fbdev@vger.kernel.org\0" + lee.jones@linaro.org + linux-leds@vger.kernel.org + " Dan Murphy <dmurphy@ti.com>\0" "\00:1\0" "b\0" "On Mon 02 Mar 04:55 PST 2020, Kiran Gunda wrote:\n" @@ -59,7 +59,7 @@ "> +\t\tbrightness = low_limit;\n" "> +\n" "> +\tbrightness_msb_mask = 0xf;\n" - "> +\tif (wled->max_brightness == WLED5_SINK_REG_BRIGHT_MAX_15B)\n" + "> +\tif (wled->max_brightness = WLED5_SINK_REG_BRIGHT_MAX_15B)\n" "> +\t\tbrightness_msb_mask = 0x7f;\n" "\n" "Why not just brightness &= wled->max_brightness? But given that it seems\n" @@ -89,7 +89,7 @@ "> +\tint rc;\n" "> +\tu8 val;\n" "> +\n" - "> +\tval = (wled->cfg.mod_sel == MOD_A) ? WLED5_SINK_REG_SYNC_MOD_A_BIT :\n" + "> +\tval = (wled->cfg.mod_sel = MOD_A) ? WLED5_SINK_REG_SYNC_MOD_A_BIT :\n" "> +\t\t\t\t\t WLED5_SINK_REG_SYNC_MOD_B_BIT;\n" "> +\trc = regmap_update_bits(wled->regmap,\n" "> +\t\t\t\twled->sink_addr + WLED5_SINK_REG_MOD_SYNC_BIT,\n" @@ -115,4 +115,4 @@ "Regards,\n" Bjorn -7ae9a8a654625c5836afd4507547426ddc88db28a45463fe9c83975f13571bf1 +593985d12dd50a321edacc94dec217afa8a082c287d242a0d2bed0475fed182c
diff --git a/a/1.txt b/N2/1.txt index b7e0e1b..6b159d1 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -90,3 +90,7 @@ And return regmap_update_bits(...); Regards, Bjorn +_______________________________________________ +dri-devel mailing list +dri-devel@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N2/content_digest index a08afa0..33e4912 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,22 +4,22 @@ "Subject\0Re: [PATCH V1 2/2] backlight: qcom-wled: Add support for WLED5 peripheral in PM8150L\0" "Date\0Sun, 8 Mar 2020 14:47:48 -0700\0" "To\0Kiran Gunda <kgunda@codeaurora.org>\0" - "Cc\0jingoohan1@gmail.com" - lee.jones@linaro.org + "Cc\0mark.rutland@arm.com" + devicetree@vger.kernel.org + daniel.thompson@linaro.org b.zolnierkie@samsung.com + jingoohan1@gmail.com + Andy Gross <agross@kernel.org> + linux-kernel@vger.kernel.org dri-devel@lists.freedesktop.org - daniel.thompson@linaro.org + linux-fbdev@vger.kernel.org + robh+dt@kernel.org jacek.anaszewski@gmail.com pavel@ucw.cz - robh+dt@kernel.org - mark.rutland@arm.com - linux-leds@vger.kernel.org - devicetree@vger.kernel.org - linux-kernel@vger.kernel.org - Dan Murphy <dmurphy@ti.com> - Andy Gross <agross@kernel.org> linux-arm-msm@vger.kernel.org - " linux-fbdev@vger.kernel.org\0" + lee.jones@linaro.org + linux-leds@vger.kernel.org + " Dan Murphy <dmurphy@ti.com>\0" "\00:1\0" "b\0" "On Mon 02 Mar 04:55 PST 2020, Kiran Gunda wrote:\n" @@ -113,6 +113,10 @@ "> +\n" "\n" "Regards,\n" - Bjorn + "Bjorn\n" + "_______________________________________________\n" + "dri-devel mailing list\n" + "dri-devel@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/dri-devel -7ae9a8a654625c5836afd4507547426ddc88db28a45463fe9c83975f13571bf1 +0cae7872939f0197b9bb2a7b5c4c5fc2765943fea9e20ca30155ee45d4dac3e1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.