From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65ECEC10F27 for ; Mon, 9 Mar 2020 08:03:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 457E820728 for ; Mon, 9 Mar 2020 08:03:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725956AbgCIID4 (ORCPT ); Mon, 9 Mar 2020 04:03:56 -0400 Received: from verein.lst.de ([213.95.11.211]:46554 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbgCIID4 (ORCPT ); Mon, 9 Mar 2020 04:03:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id EF09B68B20; Mon, 9 Mar 2020 09:03:54 +0100 (CET) Date: Mon, 9 Mar 2020 09:03:54 +0100 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, Dave Chinner Subject: Re: [PATCH 5/7] xfs: factor out a xlog_state_activate_iclog helper Message-ID: <20200309080354.GC31481@lst.de> References: <20200306143137.236478-1-hch@lst.de> <20200306143137.236478-6-hch@lst.de> <20200306171213.GH2773@bfoster> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200306171213.GH2773@bfoster> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, Mar 06, 2020 at 12:12:13PM -0500, Brian Foster wrote: > On Fri, Mar 06, 2020 at 07:31:35AM -0700, Christoph Hellwig wrote: > > Factor out the code to mark an iclog a active into a new helper. > > "mark as active" or just "mark active" I've fixed this, but then replaced this patch with a bigger one doing additional refactoring.