From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D0F7C10F27 for ; Mon, 9 Mar 2020 08:05:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A4EF2072A for ; Mon, 9 Mar 2020 08:05:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725962AbgCIIFs (ORCPT ); Mon, 9 Mar 2020 04:05:48 -0400 Received: from verein.lst.de ([213.95.11.211]:46559 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbgCIIFr (ORCPT ); Mon, 9 Mar 2020 04:05:47 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C3F1468B20; Mon, 9 Mar 2020 09:05:44 +0100 (CET) Date: Mon, 9 Mar 2020 09:05:44 +0100 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, Dave Chinner Subject: Re: [PATCH 7/7] xfs: kill XLOG_STATE_IOERROR Message-ID: <20200309080544.GD31481@lst.de> References: <20200306143137.236478-1-hch@lst.de> <20200306143137.236478-8-hch@lst.de> <20200306171545.GJ2773@bfoster> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200306171545.GJ2773@bfoster> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, Mar 06, 2020 at 12:15:45PM -0500, Brian Foster wrote: > If we were to first significantly reduce the number of error state > checks required throughout this code (i.e. reduced to the minimum > critical points necessary that ensure we don't do more log I/O or other > "bad things"), _then_ I see the value of a patch to kill off the error > state. Until we get to that point, this kind of strikes me as > rejiggering complexity around. For example, things like how > xlog_state_do_callback() passes ioerror to > xlog_state_iodone_process_iclog(), which assigns it based on shutdown > state, only for the caller to also check the shutdown state again are > indication that more cleanup is in order before killing off the state. I've added a few more patches fixing up some low hanging fruit and completely redoing the code structure around xlog_state_iodone_process_iclog. Although that means the series keeps growing, so I might split it into multiple series with some easier prep patches and then the bigger changes in a second round.