From: Johan Hovold <johan@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org
Subject: Re: [PATCH] staging: greybus: Fix the irq API abuse
Date: Mon, 9 Mar 2020 09:30:49 +0100 [thread overview]
Message-ID: <20200309083049.GA14211@localhost> (raw)
In-Reply-To: <87o8t9boqq.fsf@nanos.tec.linutronix.de>
On Fri, Mar 06, 2020 at 02:24:13PM +0100, Thomas Gleixner wrote:
> Nothing outside of low level architecture code is supposed to look up
> interrupt descriptors and fiddle with them.
>
> Replace the open coded abuse by calling generic_handle_irq().
>
> This still does not explain why and in which context this connection
> magic is injecting interrupts in the first place and why this is correct
> and safe, but at least the API abuse is gone.
Yeah, there's more to that story. The interrupt-handling was known to
have issues, but I can't seem to find the details right now.
> Fixes: 036aad9d0224 ("greybus: gpio: add interrupt handling support")
> Fixes: 2611ebef8322 ("greybus: gpio: don't call irq-flow handler directly")
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Johan Hovold <johan@kernel.org>
Johan
prev parent reply other threads:[~2020-03-09 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 13:24 [PATCH] staging: greybus: Fix the irq API abuse Thomas Gleixner
2020-03-09 8:30 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309083049.GA14211@localhost \
--to=johan@kernel.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmfrfs@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.