From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/8] lapi: Add a configure check and fallback for setns
Date: Mon, 9 Mar 2020 11:34:00 +0100 [thread overview]
Message-ID: <20200309103359.GA29747@rei.lan> (raw)
In-Reply-To: <20200309101533.GA355713@x230>
Hi!
> There is an error for old glibc on centos 06:
>
> https://api.travis-ci.org/v3/job/659994070/log.txt
>
> In file included from /usr/src/ltp/testcases/kernel/syscalls/clock_gettime/clock_gettime03.c:21:
>
> /usr/src/ltp/include/lapi/setns.h: In function 'setns':
>
> /usr/src/ltp/include/lapi/setns.h:16: error: implicit declaration of function 'syscall'
Hmm, I guess that we can include unistd.h in the lapi/syscalls.h so that
the syscall() function has a prototype.
> /usr/src/ltp/include/lapi/setns.h:16: error: implicit declaration of function 'tst_brk'
>
> /usr/src/ltp/include/lapi/setns.h:16: error: 'TCONF' undeclared (first use in this function)
>
> /usr/src/ltp/include/lapi/setns.h:16: error: (Each undeclared identifier is reported only once
>
> /usr/src/ltp/include/lapi/setns.h:16: error: for each function it appears in.)
>
> In file included from /usr/src/ltp/include/tst_test.h:14,
>
> from /usr/src/ltp/include/tst_safe_clocks.h:13,
>
> from /usr/src/ltp/testcases/kernel/syscalls/clock_gettime/clock_gettime03.c:22:
Okay, I guess that both errors could be fixed by moving the lapi/setns.h
include after the tst_test.h in the test, because tst_test.h both
includes unistd.h as well as defines the tst_brk() and TCONF.
Thanks for spotting this.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-03-09 10:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 13:48 [LTP] [PATCH 0/8] Add basic time namespace testcases Cyril Hrubis
2020-03-05 13:48 ` [LTP] [PATCH 1/8] lapi/namespace_constants.h: Add CLONE_NEWTIME Cyril Hrubis
2020-03-05 13:48 ` [LTP] [PATCH 2/8] lapi: Add a configure check and fallback for setns Cyril Hrubis
2020-03-09 10:15 ` Petr Vorel
2020-03-09 10:34 ` Cyril Hrubis [this message]
2020-03-05 13:48 ` [LTP] [PATCH 3/8] include/tst_timer: Fix normalization Cyril Hrubis
2020-03-05 13:48 ` [LTP] [PATCH 4/8] syscalls/sysinfo03: Add time namespace test Cyril Hrubis
2020-03-09 12:32 ` Richard Palethorpe
2020-03-09 12:48 ` Cyril Hrubis
2020-03-09 13:26 ` Richard Palethorpe
2020-03-09 13:33 ` Cyril Hrubis
2020-03-05 13:48 ` [LTP] [PATCH 5/8] syscalls/clock_nanosleep03: Add test for time namespace Cyril Hrubis
2020-03-05 13:48 ` [LTP] [PATCH 6/8] syscalls/clock_gettime03: Add basic time namespace test Cyril Hrubis
2020-03-09 13:23 ` Richard Palethorpe
2020-03-09 13:49 ` Cyril Hrubis
2020-03-05 13:48 ` [LTP] [PATCH 7/8] containers/timens: Add basic error test Cyril Hrubis
2020-03-10 12:06 ` Richard Palethorpe
2020-03-05 13:48 ` [LTP] [PATCH 8/8] syscalls/timerfd04: Add time namespace test Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309103359.GA29747@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.