All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Anthony Mallet <anthony.mallet@laas.fr>
Cc: Oliver Neukum <oneukum@suse.com>, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] USB: cdc-acm: fix close_delay and closing_wait units in TIOCSSERIAL
Date: Mon, 9 Mar 2020 11:35:44 +0100	[thread overview]
Message-ID: <20200309103544.GC180589@kroah.com> (raw)
In-Reply-To: <20200309095159.14163-1-anthony.mallet@laas.fr>

On Mon, Mar 09, 2020 at 10:51:58AM +0100, Anthony Mallet wrote:
> close_delay and closing_wait are specified in hundredth of a second but stored
> internally in jiffies. Use the jiffies_to_msecs() and msecs_to_jiffies()
> functions to convert from each other.
> 
> Signed-off-by: Anthony Mallet <anthony.mallet@laas.fr>
> ---
>  drivers/usb/class/cdc-acm.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Is this a "v2" of this series?  If so, then can you please properly
version the patches and put below the --- line what changed from the
previous versions?

The kernel submitting patches documentation says how to do this, take a
look at that for the details, or see one of the many examples on the
mailing list archives here.

Can you please fix this up and send a v3 for both of these?

thanks,

greg k-h

  parent reply	other threads:[~2020-03-09 10:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09  9:51 [PATCH 1/2] USB: cdc-acm: fix close_delay and closing_wait units in TIOCSSERIAL Anthony Mallet
2020-03-09  9:51 ` [PATCH 2/2] USB: cdc-acm: fix rounding error " Anthony Mallet
2020-03-09 10:35 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-03-05 10:24 [PATCH 1/2] USB: cdc-acm: fix close_delay and closing_wait units " Anthony Mallet
2020-03-05 10:34 ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200309103544.GC180589@kroah.com \
    --to=greg@kroah.com \
    --cc=anthony.mallet@laas.fr \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.