Re: [PATCH] [Outreachy kernel] staging: wfx: remove blank line

[Stefano Brivio <sbrivio@redhat.com>]

On Mon,  9 Mar 2020 00:11:30 +0530
Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:

> Blank line is not necessary before a close brace '}', remove it.
> 
> Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> ---
>  drivers/staging/wfx/data_rx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/wfx/data_rx.c b/drivers/staging/wfx/data_rx.c
> index 5d198457c6ce..2a09f6b978c3 100644
> --- a/drivers/staging/wfx/data_rx.c
> +++ b/drivers/staging/wfx/data_rx.c
> @@ -62,7 +62,6 @@ static int wfx_drop_encrypt_data(struct wfx_dev *wdev,
>  	memmove(skb->data + iv_len, skb->data, hdrlen);
>  	skb_pull(skb, iv_len);
>  	return 0;
> -
>  }
>  
>  void wfx_rx_cb(struct wfx_vif *wvif,

As you're removing one single blank line from a single function, for
the future, the commit title could be more descriptive: "staging: wfx:
remove excess newline in wfx_drop_encrypt_data()". This might be
subject to personal taste, though. Change looks good per se.

Same here, you should Cc: more people.

-- 
Stefano