All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org, mhocko@suse.com,
	dan.j.williams@intel.com, osalvador@suse.de, rppt@linux.ibm.com
Subject: Re: [PATCH v3 6/7] mm/sparse.c: move subsection_map related codes together
Date: Mon, 9 Mar 2020 21:41:04 +0800	[thread overview]
Message-ID: <20200309134104.GE27711@MiWiFi-R3L-srv> (raw)
In-Reply-To: <8462ca2b-822f-52c0-5986-93377d252fac@redhat.com>

On 03/09/20 at 10:08am, David Hildenbrand wrote:
> On 07.03.20 09:42, Baoquan He wrote:
> > No functional change.
> > 
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > ---
> >  mm/sparse.c | 134 +++++++++++++++++++++++++---------------------------
> >  1 file changed, 65 insertions(+), 69 deletions(-)
 
> 
> IMHO, we don't need this patch - but just my personal opinion. Change
> itself looks good on a quick glance.

I personally like seeing function set operating on one data structure
being put together. To me, I use vi+ctags+cscope to jump to called
funtion easily. When try to get a picture of a data and handling, e.g here
the subsection map and the relevant functions, putting them together is
better to understand code. I am also fine to discard this patch, no
patch has dependency on this one in this series, it's easy to not pick
it if no one like it. 



  reply	other threads:[~2020-03-09 13:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-07  8:42 [PATCH v3 0/7] mm/hotplug: Only use subsection map for VMEMMAP Baoquan He
2020-03-07  8:42 ` [PATCH v3 1/7] mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case Baoquan He
2020-03-07 20:59   ` Andrew Morton
2020-03-07 22:55     ` Baoquan He
2020-03-09  8:56   ` David Hildenbrand
2020-03-09  8:58   ` David Hildenbrand
2020-03-09 13:18     ` Baoquan He
2020-03-09 13:22       ` David Hildenbrand
2020-03-09 10:13   ` Pankaj Gupta
2020-03-09 12:56   ` Michal Hocko
2020-03-07  8:42 ` [PATCH v3 2/7] mm/sparse.c: introduce new function fill_subsection_map() Baoquan He
2020-03-07  8:42 ` [PATCH v3 3/7] mm/sparse.c: introduce a new function clear_subsection_map() Baoquan He
2020-03-09  8:59   ` David Hildenbrand
2020-03-09 13:32     ` Baoquan He
2020-03-09 13:38       ` David Hildenbrand
2020-03-09 14:07         ` Baoquan He
2020-03-07  8:42 ` [PATCH v3 4/7] mm/sparse.c: only use subsection map in VMEMMAP case Baoquan He
2020-03-09  9:00   ` David Hildenbrand
2020-03-07  8:42 ` [PATCH v3 5/7] mm/sparse.c: add note about only VMEMMAP supporting sub-section support Baoquan He
2020-03-07 11:55   ` Baoquan He
2020-03-10 14:46   ` Michal Hocko
2020-03-11  4:20     ` Baoquan He
2020-03-07  8:42 ` [PATCH v3 6/7] mm/sparse.c: move subsection_map related codes together Baoquan He
2020-03-09  9:08   ` David Hildenbrand
2020-03-09 13:41     ` Baoquan He [this message]
2020-03-07  8:42 ` [PATCH v3 7/7] mm/sparse.c: Use __get_free_pages() instead in populate_section_memmap() Baoquan He
2020-03-10 14:56   ` Michal Hocko
2020-03-10 14:59     ` David Hildenbrand
2020-03-11  9:31     ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200309134104.GE27711@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    --cc=rppt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.