From: Lourdes Pedrajas <lu@pplo.net>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] A question: commented out code
Date: Mon, 9 Mar 2020 17:40:14 +0100 [thread overview]
Message-ID: <20200309164014.GC3949@supernova> (raw)
In-Reply-To: <alpine.DEB.2.21.2003090836290.2676@hadrien>
On Mon, Mar 09, 2020 at 08:37:26AM +0100, Julia Lawall wrote:
> On Sun, 8 Mar 2020, Lourdes Pedrajas wrote:
>
> > Is removing commented out, unused code, a good cleanup patch? I'm
> > wondering that maybe that code is there for a reason. I checked TODO files
> > prior to removing that code to see if they provide a reason, but for the files
> > I edited, they did not.
>
> The general principle is that it should go. The git history is always
> there, so the code is not lost forever. You can use your judgement, of
> course.
>
> julia
>
I agree, thank you Julia!
prev parent reply other threads:[~2020-03-09 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 22:44 A question: commented out code Lourdes Pedrajas
2020-03-09 7:37 ` [Outreachy kernel] " Julia Lawall
2020-03-09 16:40 ` Lourdes Pedrajas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309164014.GC3949@supernova \
--to=lu@pplo.net \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.