From: Al Viro <viro@zeniv.linux.org.uk>
To: Joe Perches <joe@perches.com>
Cc: Daniel Xu <dxu@dxuuu.xyz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH] xattr: NULL initialize name in simple_xattr_alloc
Date: Mon, 9 Mar 2020 22:31:45 +0000 [thread overview]
Message-ID: <20200309223145.GI23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <19abedb11fae1b96aa052090e7a0d5bbea416824.camel@perches.com>
On Mon, Mar 09, 2020 at 12:30:07PM -0700, Joe Perches wrote:
> On Mon, 2020-03-09 at 11:37 -0700, Daniel Xu wrote:
> > It's preferable to initialize structs to a deterministic state.
>
> Thanks Daniel.
Not much point, TBH - there are only two callers, both assigning
that field very shortly. If you want to do it, do it right -
make that
simple_xattr_alloc(name, value, len)
with kfree(name) done on failure. And make the callers allocate
the name first. Simpler cleanup rules on failure exits that
way...
prev parent reply other threads:[~2020-03-09 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 18:37 [PATCH] xattr: NULL initialize name in simple_xattr_alloc Daniel Xu
2020-03-09 19:30 ` Joe Perches
2020-03-09 22:31 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309223145.GI23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dxu@dxuuu.xyz \
--cc=joe@perches.com \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.