Re: [PATCH] wilc1000 : rearrange line exceeding 80 characters

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Mar 10, 2020 at 02:58:24PM +0530, Deepak R Varma wrote:
> A long if condition exceeding 80 characters that makes evaluation
> appear confusing. Rearranging the condition makes it easier to understand.
> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
>  drivers/staging/wilc1000/netdev.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

You forgot "staging:" in your subject line.

> 
> diff --git a/drivers/staging/wilc1000/netdev.c b/drivers/staging/wilc1000/netdev.c
> index 045f5cdfdca0..d7a632c92a76 100644
> --- a/drivers/staging/wilc1000/netdev.c
> +++ b/drivers/staging/wilc1000/netdev.c
> @@ -802,8 +802,10 @@ void wilc_wfi_mgmt_rx(struct wilc *wilc, u8 *buff, u32 size)
>  		u16 type = le16_to_cpup((__le16 *)buff);
>  
>  		if (vif->priv.p2p_listen_state &&
> -		    ((type == vif->frame_reg[0].type && vif->frame_reg[0].reg) ||
> -		     (type == vif->frame_reg[1].type && vif->frame_reg[1].reg)))
> +		    ((type == vif->frame_reg[0].type &&
> +			vif->frame_reg[0].reg) ||
> +		     (type == vif->frame_reg[1].type &&
> +			vif->frame_reg[1].reg)))

The original code is really easier to follow than your change, so I
would just leave it as-is please.

thanks,

greg k-h