From: Joerg Roedel <joro@8bytes.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: iommu@lists.linux-foundation.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] iommu/vt-d: quirk_ioat_snb_local_iommu: replace WARN_TAINT with pr_warn + add_taint
Date: Tue, 10 Mar 2020 11:44:37 +0100 [thread overview]
Message-ID: <20200310104436.GC3794@8bytes.org> (raw)
In-Reply-To: <20200309182510.373875-1-hdegoede@redhat.com>
On Mon, Mar 09, 2020 at 07:25:10PM +0100, Hans de Goede wrote:
> Quoting from the comment describing the WARN functions in
> include/asm-generic/bug.h:
>
> * WARN(), WARN_ON(), WARN_ON_ONCE, and so on can be used to report
> * significant kernel issues that need prompt attention if they should ever
> * appear at runtime.
> *
> * Do not use these macros when checking for invalid external inputs
>
> The (buggy) firmware tables which the dmar code was calling WARN_TAINT
> for really are invalid external inputs. They are not under the kernel's
> control and the issues in them cannot be fixed by a kernel update.
> So logging a backtrace, which invites bug reports to be filed about this,
> is not helpful.
>
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=701847
> Fixes: 556ab45f9a77 ("ioat2: catch and recover from broken vtd configurations v6")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/iommu/intel-iommu.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2020-03-10 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 18:25 [PATCH] iommu/vt-d: quirk_ioat_snb_local_iommu: replace WARN_TAINT with pr_warn + add_taint Hans de Goede
2020-03-10 1:46 ` Lu Baolu
2020-03-10 10:44 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310104436.GC3794@8bytes.org \
--to=joro@8bytes.org \
--cc=dwmw2@infradead.org \
--cc=hdegoede@redhat.com \
--cc=iommu@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.