From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF8EC10F27 for ; Tue, 10 Mar 2020 11:37:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00D7524681 for ; Tue, 10 Mar 2020 11:37:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583840277; bh=Cx2LRnFxdyWMsx83KnJim7N0cA4g5Eqn+DXRBSQizuQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1q/mj/SBsF9dpv80iSMQx2FWrU4c//ISqvFGY0Wk6L0Jc0bmNtZXBEBAsz+Ov81ey 2YuZJN4hE8YgPj17ES/2MivGAvB8eeWaWAzMLvo8PXoXfwGvzmAAqVvBoXgLdTJK28 DzbaBgWG9LNcl6gy1AxHCDyu/rFzSIY34TqW6qmw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726307AbgCJLh4 (ORCPT ); Tue, 10 Mar 2020 07:37:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:36428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbgCJLh4 (ORCPT ); Tue, 10 Mar 2020 07:37:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5A23024655; Tue, 10 Mar 2020 11:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583840275; bh=Cx2LRnFxdyWMsx83KnJim7N0cA4g5Eqn+DXRBSQizuQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WJR+e7zoYWePMgjkaTYbUroZ2eHMIpOOfQfot1RK5iffhtHGcix1K2v9381Qs4wEI 56YMlfN9o9f8yr/4lK7MZUsrt0aZgVv+7Ghej3hyU/DwTGsCPIMdwFAaSvt1RSL9cv IP8E9Sbq9wBBxz8NgfKmhqa2QOT053W87Mg6C7b8= Date: Tue, 10 Mar 2020 12:37:53 +0100 From: Greg KH To: yangerkun Cc: sashal@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 4.4.y/4.9.y] NFS: fix highmem leak exist in nfs_readdir_xdr_to_array Message-ID: <20200310113753.GA3106483@kroah.com> References: <20200310100219.5421-1-yangerkun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310100219.5421-1-yangerkun@huawei.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Mar 10, 2020 at 06:02:19PM +0800, yangerkun wrote: > The patch 'e22dea67d2f7 ("NFS: Fix memory leaks and corruption in > readdir")' in 4.4.y/4.9.y will introduce a highmem leak. > Actually, nfs_readdir_get_array has did what we want to do. No need to > call kmap again. > > Signed-off-by: yangerkun > --- > fs/nfs/dir.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c > index c2665d920cf8..2517fcd423b6 100644 > --- a/fs/nfs/dir.c > +++ b/fs/nfs/dir.c > @@ -678,8 +678,6 @@ int nfs_readdir_xdr_to_array(nfs_readdir_descriptor_t *desc, struct page *page, > goto out_label_free; > } > > - array = kmap(page); > - > status = nfs_readdir_alloc_pages(pages, array_size); > if (status < 0) > goto out_release_array; > -- > 2.17.2 > Can you resend and cc: the NFS developers and maintainers on this change? I need their ack to be able to apply it. thanks, greg k-h