From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B6FEC18E5A for ; Tue, 10 Mar 2020 11:45:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F5CB24655 for ; Tue, 10 Mar 2020 11:45:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SOYAC3HV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="r0DTGuHH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F5CB24655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tPNzhOJ2SYWNvfZgO4hZ6P0R40yizpsyrLskot1y+Og=; b=SOYAC3HVmiENVd 9cNyvO3iTr8o+U924t2Rnd9oJUAJiFdeZa1UwUB6185YM/fiKy/y5yvtjBedi00NH8UuoBAs8Lr15 fRdEtTzZ94jvrBNNVTCAxqcVY/12JdORGz2A9pOmauhZTx5pj/s80IpCyldI4EBoVp8M1JXzycLD+ wtUOSsM6gVKGFXjK0fxGWLwJgvBLN6mRgnB97eVrSzuX6G7pU7ppV5hPeqWEc/0KhIySi3FoiB+uP Of9A97QvvKZU7HBBvv7kk0JyWaKT2cJz4JIMmSkZO6UwXaljyoxZsAIcdSOZM22KvTmIfZAgp0iX5 5lOt4YlcS083zsbm9fDw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBdJw-0000pb-Jd; Tue, 10 Mar 2020 11:45:12 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBdJt-0000o8-KR for linux-arm-kernel@bombadil.infradead.org; Tue, 10 Mar 2020 11:45:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JFUcdzOUencsCKId/ctBPwQiHSHHBRg97HyGLAkaW4E=; b=r0DTGuHHzYJX4xgVWZIL+IVaHG PYGnKXe42n/VBhIuOUVpn710HyExoUDUxQjF+NTlMlCa+vhRI7DEBG47y4/xLLW/MCZviPgul6Irk 3FHHYNswuXl5qweUNIkP4GSzRAkC/f+a2b6THmCET1WAEZvaiCimE/XTK8GsTcSTn1EQosTFTvOrd K0x42rJOA+wUl02phvAqKwrBsv15IhR8oVT07A3UogzRt16dgOvl3Bh1CbV1ToiZqX0A2e1QLqQmF gtir4gnKbxhPRGv9M3jpckuZQ+lD/qeGJSTe7jP7XSC3sq4lPHpj/11syO1itImY3eER7LjI0XxwZ 0uIC+WFQ==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBdJr-0000Or-VJ; Tue, 10 Mar 2020 11:45:08 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id DF4DA40009; Tue, 10 Mar 2020 08:45:03 -0300 (-03) Date: Tue, 10 Mar 2020 08:45:03 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Subject: Re: [PATCH v5 0/5] perf cs-etm: Fix synthesizing instruction samples Message-ID: <20200310114503.GA25299@kernel.org> References: <20200219021811.20067-1-leo.yan@linaro.org> <20200310054305.GA21545@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200310054305.GA21545@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Mathieu Poirier , Suzuki K Poulose , Peter Zijlstra , Coresight ML , linux-kernel@vger.kernel.org, Alexander Shishkin , Ingo Molnar , Namhyung Kim , Robert Walker , Jiri Olsa , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, Mar 10, 2020 at 01:43:05PM +0800, Leo Yan escreveu: > Hi Arnaldo, > > On Wed, Feb 19, 2020 at 10:18:06AM +0800, Leo Yan wrote: > > This patch series is to address issues for synthesizing instruction > > samples, especially when the instruction sample period is small enough, > > the current logic cannot synthesize multiple instruction samples within > > one instruction range packet. > > > > Patch 0001 is to swap packets for instruction samples, so this allow > > option '--itrace=iNNN' can work well. > > > > Patch 0002 avoids to reset the last branches for every instruction > > sample; if reset the last branches for every time generating sample, the > > later samples in the same range packet cannot use the last branches > > anymore. > > > > Patch 0003 is the fixing for handling different instruction periods, > > especially for small sample period. > > > > Patch 0004 is an optimization for copying last branches; it only copies > > last branches once if the instruction samples share the same last > > branches. > > > > Patch 0005 is a minor fix for unsigned variable comparison to zero. > > > > This patch set has been rebased on the latest perf/core branch; and > > verified on Juno board with below commands: > > > > # perf script --itrace=i2 > > # perf script --itrace=i2il16 > > # perf inject --itrace=i2il16 -i perf.data -o perf.data.new > > # perf inject --itrace=i100il16 -i perf.data -o perf.data.new > > Could you pick up this patch set? I confirmed this patch set can > cleanly apply on top of the latest mainline kernel (5.6-rc5). > > Or if you want me to resend this patch set, please feel free let me > know. Thanks! Thanks, all build tested on x86 and arm64 (with CORESIGHT=1, etc), applied. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A42BC10F27 for ; Tue, 10 Mar 2020 11:45:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFDB22468C for ; Tue, 10 Mar 2020 11:45:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ijzjfY87" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726436AbgCJLpK (ORCPT ); Tue, 10 Mar 2020 07:45:10 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:35525 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbgCJLpK (ORCPT ); Tue, 10 Mar 2020 07:45:10 -0400 Received: by mail-qk1-f194.google.com with SMTP id d8so7910206qka.2 for ; Tue, 10 Mar 2020 04:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JFUcdzOUencsCKId/ctBPwQiHSHHBRg97HyGLAkaW4E=; b=ijzjfY879xd5ao57WpwaANRMaCpaYDMaEpB29Q+QPTBgwItb+0yR12YExXxydmWku6 GD2IcA0blDbhvaLkR/D9I/zJi7jATnknUN5Gu57O3o8B6HGyt7utmhgnbrmAW4mYpctu bIa9ovc2UvhTdaYtuSp7NgpDvKv0JHvbOkYhP3M9UmWbF1vhjP3V8pW0xV/iOOyBXs0r kRfIkbFhZcqI6vsL4HnDlfRHF15o+Ipho+C40hyc2kmoKKV1I3CN7cz3eQtK1p+/Ccm/ n4h//ORgHOuxkXMDKj2faxGuHwjdncXVdNazEA/LIhQhHamEEj3g1frdZ31ivEukcnrM HjGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JFUcdzOUencsCKId/ctBPwQiHSHHBRg97HyGLAkaW4E=; b=tgUZg6q38wdWn7bVjTOEOqQK6IwhRsAnf8FUOY59K1rGqc3Sm65UZf7MME3zcZ5nQu Sck76adhPqMQMj0vvFP++c5TkcWuq5EsrHdmt6wXANWVWtYBZzPdUFil7cy5dRCHEXnd Bl/4efUDfUkdp4hfRkmRFLI91WbqETAmo7g35BkOd/GJiJDvpTQ06dac989RpML9fwgA fVjP0TtcBZZUCqrk/ovWbk90WpFWro7lhJdStUltu61GTL/ogrSw3GFkKd0ea6nU61Sk A8GWIcgXinn88W6vD9jWPeowLVStFfqUyqvm4Zbv1KJrY7bPh/3vdkdOqqKmX6oDQH+p XzXQ== X-Gm-Message-State: ANhLgQ0cBkOO/nEGj96DOEwt/SgF9+/iPc/BOcPclXyUzMVtRoPP/smx NOtDCaeA0X5GJ5La+G+SU9c= X-Google-Smtp-Source: ADFU+vscKo8xuu/DwFLFjKLU/u+/KK3pvCK7+CEPE3KsX6WkzzshJxugxbuhzxTkPNUs8k79BelGew== X-Received: by 2002:a37:6852:: with SMTP id d79mr10937577qkc.304.1583840707653; Tue, 10 Mar 2020 04:45:07 -0700 (PDT) Received: from quaco.ghostprotocols.net ([179.97.37.151]) by smtp.gmail.com with ESMTPSA id h9sm23852287qtq.61.2020.03.10.04.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 04:45:06 -0700 (PDT) From: Arnaldo Carvalho de Melo X-Google-Original-From: Arnaldo Carvalho de Melo Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id DF4DA40009; Tue, 10 Mar 2020 08:45:03 -0300 (-03) Date: Tue, 10 Mar 2020 08:45:03 -0300 To: Leo Yan Cc: Mathieu Poirier , Suzuki K Poulose , Mike Leach , Robert Walker , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Coresight ML Subject: Re: [PATCH v5 0/5] perf cs-etm: Fix synthesizing instruction samples Message-ID: <20200310114503.GA25299@kernel.org> References: <20200219021811.20067-1-leo.yan@linaro.org> <20200310054305.GA21545@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310054305.GA21545@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Mar 10, 2020 at 01:43:05PM +0800, Leo Yan escreveu: > Hi Arnaldo, > > On Wed, Feb 19, 2020 at 10:18:06AM +0800, Leo Yan wrote: > > This patch series is to address issues for synthesizing instruction > > samples, especially when the instruction sample period is small enough, > > the current logic cannot synthesize multiple instruction samples within > > one instruction range packet. > > > > Patch 0001 is to swap packets for instruction samples, so this allow > > option '--itrace=iNNN' can work well. > > > > Patch 0002 avoids to reset the last branches for every instruction > > sample; if reset the last branches for every time generating sample, the > > later samples in the same range packet cannot use the last branches > > anymore. > > > > Patch 0003 is the fixing for handling different instruction periods, > > especially for small sample period. > > > > Patch 0004 is an optimization for copying last branches; it only copies > > last branches once if the instruction samples share the same last > > branches. > > > > Patch 0005 is a minor fix for unsigned variable comparison to zero. > > > > This patch set has been rebased on the latest perf/core branch; and > > verified on Juno board with below commands: > > > > # perf script --itrace=i2 > > # perf script --itrace=i2il16 > > # perf inject --itrace=i2il16 -i perf.data -o perf.data.new > > # perf inject --itrace=i100il16 -i perf.data -o perf.data.new > > Could you pick up this patch set? I confirmed this patch set can > cleanly apply on top of the latest mainline kernel (5.6-rc5). > > Or if you want me to resend this patch set, please feel free let me > know. Thanks! Thanks, all build tested on x86 and arm64 (with CORESIGHT=1, etc), applied. - Arnaldo