From: Lourdes Pedrajas <lu@pplo.net>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
perex@perex.cz
Subject: Re: [Outreachy kernel] [PATCH] staging: hp: hp100.c: remove commented out code
Date: Tue, 10 Mar 2020 12:47:16 +0100 [thread overview]
Message-ID: <20200310114716.GA3202@supernova> (raw)
In-Reply-To: <alpine.DEB.2.21.2003092208170.2324@hadrien>
On Mon, Mar 09, 2020 at 10:09:25PM +0100, Julia Lawall wrote:
> On Mon, 9 Mar 2020, Lourdes Pedrajas wrote:
>
> > Remove unused code.
>
> This could be a little more informative. For example, you could use git
> blame to find out how long the code has been there. If it has been there
> since the driver was introduced n years ago, that could be a useful piece
> of information to make clear that the code really is unnecessary.
>
> julia
>
I agree. This patch is being merged, but next time I'll use your hint,
it's useful. Thank you for your patience!
prev parent reply other threads:[~2020-03-10 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 17:12 [PATCH] staging: hp: hp100.c: remove commented out code Lourdes Pedrajas
2020-03-09 21:09 ` [Outreachy kernel] " Julia Lawall
2020-03-10 11:47 ` Lourdes Pedrajas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310114716.GA3202@supernova \
--to=lu@pplo.net \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.