Re: [thud] [PATCH] packagegroup-arago-tisdk-addons: add tensorflow-lite

[Denys Dmytriyenko <denys@ti.com>]

On Fri, Mar 06, 2020 at 05:26:57PM -0500, Gou, Hongmei wrote:
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Friday, March 6, 2020 1:27 PM
> > To: Gou, Hongmei
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [thud] [PATCH] packagegroup-arago-tisdk-addons:
> > add tensorflow-lite
> > 
> > On Fri, Mar 06, 2020 at 12:46:25PM -0500, Hongmei Gou wrote:
> > > * This is for including the examples built from the tensforflow lite package
> > >   to the target filesystem at usr/share/tensorflow-lite/examples
> > >
> > > * As tensorflow-lite is creating static library, tensorflow-lite-demo which
> > >   depends on tensorflow-lite will not bring in the examples folder for
> > >   tensorflow-lite to the target filesystem
> > 
> > Not really clear from this description - do you package examples in a separate
> > package? Then you need to list that package in RDEPENDS packagegroup
> > below.
> > Otherwise the standard depency from demo package should be fine.
> 
> There used to be a separate tensorflow-lite-examples package for the examples.
> The examples got in the tensorflow-lite package after changing the target location
> to /usr/share/tensorflow-lite. So, the current tensorflow-lite package itself contains
> the examples (console output).
> 
> On the other hand, we newly introduced the tensorflow-lite-demo package which
> contains demos with GUI display, and it depends on tensorflow-lite.

Sorry for the delay.

So, tensorflow-lite-demo links *statically* against tensorflow-lite and hence 
there's no RDEPENDS preserved, which was expected to be there for the proper 
packaging to work...

Is static linking the expected behavior? Are there plans to link dynamically?


Second question - should examples from tensorflow-lite still be packaged 
separately? I understand they got moved and now picked up by the main package 
automatically. But there is an easy way to get the old behavior by prepending 
examples package to the PACKAGES list, instead of appending.


I guess I can merge this to thud as is, but would like to clean this up going 
forward, so please answer above questions anyway. Thanks!

Denys


> > > Signed-off-by: Hongmei Gou <a0271529@ti.com>
> > > ---
> > > This is applicable to thud only, since zeus/master is now using ti-
> > analytics.bb
> > >
> > >  .../packagegroups/packagegroup-arago-tisdk-addons.bb        | 6 +++++-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > arago-tisdk-addons.bb b/meta-arago-distro/recipes-
> > core/packagegroups/packagegroup-arago-tisdk-addons.bb
> > > index 583d2c0b..ff34ab95 100644
> > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> > tisdk-addons.bb
> > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > arago-tisdk-addons.bb
> > > @@ -1,6 +1,6 @@
> > >  DESCRIPTION = "Task to install additional utilities/demos for SDKs"
> > >  LICENSE = "MIT"
> > > -PR = "r77"
> > > +PR = "r78"
> > >
> > >  PACKAGE_ARCH = "${MACHINE_ARCH}"
> > >
> > > @@ -153,6 +153,7 @@ ARMNN_PACKAGES = "armnn"
> > >  EXTRA_PACKAGES_append_ti33x = " voxelsdk \
> > >                                  arm-compute-library \
> > >                                  ${ARMNN_PACKAGES} \
> > > +                                tensorflow-lite \
> > >                                  tensorflow-lite-demo \
> > >                                  pdm-anomaly-detection \
> > >  "
> > > @@ -160,6 +161,7 @@ EXTRA_PACKAGES_append_ti33x = " voxelsdk \
> > >  EXTRA_PACKAGES_append_ti43x = " voxelsdk \
> > >                                  arm-compute-library \
> > >                                  ${ARMNN_PACKAGES} \
> > > +                                tensorflow-lite \
> > >                                  tensorflow-lite-demo \
> > >                                  pdm-anomaly-detection \
> > >  "
> > > @@ -169,12 +171,14 @@ EXTRA_PACKAGES_append_omap-a15 = "
> > voxelsdk \
> > >                                     big-data-ipc-demo-linux-firmware \
> > >                                     arm-compute-library \
> > >                                     ${ARMNN_PACKAGES} \
> > > +                                   tensorflow-lite \
> > >                                     tensorflow-lite-demo \
> > >                                     pdm-anomaly-detection \
> > >  "
> > >
> > >  EXTRA_PACKAGES_append_am65xx = " arm-compute-library \
> > >                               ${ARMNN_PACKAGES} \
> > > +                             tensorflow-lite \
> > >                               tensorflow-lite-demo \
> > >                               pdm-anomaly-detection \
> > >  "
> > > --
> > > 2.17.1
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago