From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Steve Longerbeam <slongerbeam@gmail.com>
Cc: linux-media@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Rui Miguel Silva <rmfrfs@gmail.com>
Subject: Re: [PATCH 7/7] media: imx: imx7-media-csi: Fix video field handling
Date: Tue, 10 Mar 2020 17:49:37 +0200 [thread overview]
Message-ID: <20200310154937.GA32319@pendragon.ideasonboard.com> (raw)
In-Reply-To: <ed913970-573e-4bee-ce84-28513a7869a9@gmail.com>
Hi Steve and Rui,
I've spent more time on the i.MX7 support in the i.MX media staging
driver today, and I've reached a point where I'm not comfortable moving
forward without your ack.
I found format handling to be very broken, the driver enumerates formats
that are not supported by the device, and doesn't properly handle the
supported formats. While trying to fix that, I found out that the common
i.MX6 and i.MX7 helpers (imx-media-capture.c and imx-media-utils.c) get
in the way, as i.MX6 and i.MX7 format support are very entangled. I
would like to split the two in order to clean up the i.MX7 code, which
would also give an opportunity to later clean the i.MX6 code if desired.
Before moving in that time-consuming direction, I want to make sure this
will be accepted, as I don't want to spend days of work for nothing. If
you want to discuss this in real time, I'm available in the #v4l channel
on Freenode (nickname pinchartl).
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-03-10 15:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 0:41 [PATCH 0/7] media: imx: Miscellaneous fixes for i.MX7 Laurent Pinchart
2019-10-24 0:41 ` [PATCH 1/7] media: imx: imx7_mipi_csis: Power off the source when stopping streaming Laurent Pinchart
2019-10-24 17:43 ` Fabio Estevam
2019-10-24 22:20 ` Rui Miguel Silva
2019-10-24 0:41 ` [PATCH 2/7] media: imx: imx7_mipi_csis: Print the RESOL_CH0 register Laurent Pinchart
2019-10-24 0:41 ` [PATCH 3/7] media: imx: imx7_mipi_csis: Add greyscale formats support Laurent Pinchart
2019-10-24 0:41 ` [PATCH 4/7] media: imx: imx6-media-csi: Replace Y16 with Y10 and Y12 Laurent Pinchart
2019-10-24 0:41 ` [PATCH 5/7] media: imx: imx7-media-csi: Add Y10 and Y12 formats support Laurent Pinchart
2019-10-24 0:41 ` [PATCH 6/7] media: imx: imx7-media-csi: Remove unneeded register read Laurent Pinchart
2019-10-24 17:57 ` Steve Longerbeam
2019-10-24 17:59 ` Steve Longerbeam
2019-10-24 0:41 ` [PATCH 7/7] media: imx: imx7-media-csi: Fix video field handling Laurent Pinchart
2019-10-24 3:25 ` Steve Longerbeam
2019-10-24 3:27 ` Steve Longerbeam
2020-03-09 20:48 ` Laurent Pinchart
2019-10-24 15:11 ` Steve Longerbeam
2020-03-09 20:52 ` Laurent Pinchart
2020-03-10 0:00 ` Steve Longerbeam
2020-03-10 0:06 ` Laurent Pinchart
2020-03-10 15:49 ` Laurent Pinchart [this message]
2020-03-11 23:54 ` Steve Longerbeam
2020-03-12 0:01 ` Laurent Pinchart
2019-10-24 22:14 ` [PATCH 0/7] media: imx: Miscellaneous fixes for i.MX7 Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310154937.GA32319@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rmfrfs@gmail.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.