From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C196EC18E5A for ; Tue, 10 Mar 2020 16:32:50 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9575D20848 for ; Tue, 10 Mar 2020 16:32:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="Bw05hDwu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="l8uHHrw8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rb36kZ2I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9575D20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jBhoG-0007fx-6X; Tue, 10 Mar 2020 16:32:48 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jBhoF-0007fq-0w for linux-f2fs-devel@lists.sourceforge.net; Tue, 10 Mar 2020 16:32:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=v6UUlXs6s/wfkxq7kKSxxRt/BhpkTl3aXYt0Mf3Q25U=; b=Bw05hDwuUhO8pSxOzPyVDFK+Fl 2ljUecxw6RtWAcRlgqT/bEvR6c88TBfoCZTeZ6R+pL1ZcY1muSMxLZ+ps4MKxn8Tb838CRHzkzLOw cYf2kaVcKJk/UyrcN9kH7YkEjkE3iT3B5lIqypc+w1pAlvKonktcoEXXuxRqVFdYkuRg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=v6UUlXs6s/wfkxq7kKSxxRt/BhpkTl3aXYt0Mf3Q25U=; b=l8uHHrw81JFwIX+fQBLVCHTZAQ A7SW6WtUtYYSfPugYaHsYVMPjxJnzBoKxj0VSLqWtyILeY6VERN7ttHkgkfy4wmJJuAQohVXD6Qyl 8hrjfK+YSr/jYNh4gVDvkZkh0ef7MZKIShN6X1p3Uxcx9i7YXVAG9NNH924OsXhadMDA=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jBhoD-007miM-9S for linux-f2fs-devel@lists.sourceforge.net; Tue, 10 Mar 2020 16:32:46 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 89DBD20848; Tue, 10 Mar 2020 16:32:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583857959; bh=/2iPAON56KiKp4VwG3w8X0u28X5Zi54HWAvPebGYCEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Rb36kZ2IbhnZyB3p1V4V9GfgNg6bejDxx1CE6wjMZfT6YUH/psCRAb2RrJkPjMgH2 Go0BJJKKyZ5lTjS5QhXBu42kon1eWwEY210z/9Ec+pBRGEjfzfyFtu+GiWsT6Os2CD XunWcletPjGcSg/F8kGYtouEaW6O5e0gn8UznE8s= Date: Tue, 10 Mar 2020 09:32:39 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: <20200310163239.GC240315@google.com> References: <20200310125009.12966-1-yuchao0@huawei.com> <20200310125009.12966-2-yuchao0@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200310125009.12966-2-yuchao0@huawei.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Headers-End: 1jBhoD-007miM-9S Subject: Re: [f2fs-dev] [PATCH 2/5] f2fs: force compressed data into warm area X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 03/10, Chao Yu wrote: > Generally, data shows better continuity in warm data area as its > default allocation direction is right, in order to enhance > sequential read/write performance of compress inode, let's force > compress data into warm area. Not quite sure tho, compressed blocks are logically cold, no? > > Signed-off-by: Chao Yu > --- > fs/f2fs/segment.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 601d67e72c50..ab1bc750712a 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -3037,9 +3037,10 @@ static int __get_segment_type_6(struct f2fs_io_info *fio) > if (fio->type == DATA) { > struct inode *inode = fio->page->mapping->host; > > - if (is_cold_data(fio->page) || file_is_cold(inode) || > - f2fs_compressed_file(inode)) > + if (is_cold_data(fio->page) || file_is_cold(inode)) > return CURSEG_COLD_DATA; > + if (f2fs_compressed_file(inode)) > + return CURSEG_WARM_DATA; > if (file_is_hot(inode) || > is_inode_flag_set(inode, FI_HOT_DATA) || > f2fs_is_atomic_file(inode) || > -- > 2.18.0.rc1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC1E7C18E5A for ; Tue, 10 Mar 2020 16:32:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C648021D7E for ; Tue, 10 Mar 2020 16:32:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583857961; bh=/2iPAON56KiKp4VwG3w8X0u28X5Zi54HWAvPebGYCEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=l1CJIgPu/uhdCz3sy53Bi6j/KGfjtMuC7P+ROEonvopDfaJoAIql5a6X0yoI0n92w qogLGEClozwlFTLH6orHqoF9bnYU6g/SOSrfkOvk51gSvTONXNWBQxs2QtHliyy++I Db8oM6xC7oRJlhZ9Tw+VFCdTdd1a8Vur+a0/Vk6c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbgCJQcl (ORCPT ); Tue, 10 Mar 2020 12:32:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:46786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727007AbgCJQck (ORCPT ); Tue, 10 Mar 2020 12:32:40 -0400 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 89DBD20848; Tue, 10 Mar 2020 16:32:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583857959; bh=/2iPAON56KiKp4VwG3w8X0u28X5Zi54HWAvPebGYCEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Rb36kZ2IbhnZyB3p1V4V9GfgNg6bejDxx1CE6wjMZfT6YUH/psCRAb2RrJkPjMgH2 Go0BJJKKyZ5lTjS5QhXBu42kon1eWwEY210z/9Ec+pBRGEjfzfyFtu+GiWsT6Os2CD XunWcletPjGcSg/F8kGYtouEaW6O5e0gn8UznE8s= Date: Tue, 10 Mar 2020 09:32:39 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chao@kernel.org Subject: Re: [PATCH 2/5] f2fs: force compressed data into warm area Message-ID: <20200310163239.GC240315@google.com> References: <20200310125009.12966-1-yuchao0@huawei.com> <20200310125009.12966-2-yuchao0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310125009.12966-2-yuchao0@huawei.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10, Chao Yu wrote: > Generally, data shows better continuity in warm data area as its > default allocation direction is right, in order to enhance > sequential read/write performance of compress inode, let's force > compress data into warm area. Not quite sure tho, compressed blocks are logically cold, no? > > Signed-off-by: Chao Yu > --- > fs/f2fs/segment.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 601d67e72c50..ab1bc750712a 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -3037,9 +3037,10 @@ static int __get_segment_type_6(struct f2fs_io_info *fio) > if (fio->type == DATA) { > struct inode *inode = fio->page->mapping->host; > > - if (is_cold_data(fio->page) || file_is_cold(inode) || > - f2fs_compressed_file(inode)) > + if (is_cold_data(fio->page) || file_is_cold(inode)) > return CURSEG_COLD_DATA; > + if (f2fs_compressed_file(inode)) > + return CURSEG_WARM_DATA; > if (file_is_hot(inode) || > is_inode_flag_set(inode, FI_HOT_DATA) || > f2fs_is_atomic_file(inode) || > -- > 2.18.0.rc1