From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guru Das Srinagesh Date: Tue, 10 Mar 2020 18:12:42 +0000 Subject: Re: [PATCH v7 12/13] backlight: pwm_bl: Use 64-bit division macros for period and duty cycle Message-Id: <20200310181242.GA31738@codeaurora.org> List-Id: References: <20200310143432.cfjlqac5x6oinshj@holly.lan> In-Reply-To: <20200310143432.cfjlqac5x6oinshj@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Thompson Cc: linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , Subbaraman Narayanamurthy , Lee Jones On Tue, Mar 10, 2020 at 02:34:32PM +0000, Daniel Thompson wrote: > This patch looks like it is a tiny change to get the pwm_backlight to > perform 64-bit division. Most of the above text is completely irrelevant > to the change contained in this patch. No need to justify the change in > the PWM structures here since that can go in the patch that changes > those structures. Just describe what this patch does, perhaps something > like the following: > > The PWM API will shortly switch the state.period and > state.duty_cycle fields to 64-bit values. Make pwm_bl > ready for this transition by adopting 64-bit division > macros. Will update the commit text accordingly. > Also please copy the backlight maintainers into the covering letter. It > is useful to place patches like this into context. Will do. Thank you. Guru Das. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guru Das Srinagesh Subject: Re: [PATCH v7 12/13] backlight: pwm_bl: Use 64-bit division macros for period and duty cycle Date: Tue, 10 Mar 2020 11:12:42 -0700 Message-ID: <20200310181242.GA31738@codeaurora.org> References: <20200310143432.cfjlqac5x6oinshj@holly.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:38739 "EHLO alexa-out-sd-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726464AbgCJSMo (ORCPT ); Tue, 10 Mar 2020 14:12:44 -0400 Content-Disposition: inline In-Reply-To: <20200310143432.cfjlqac5x6oinshj@holly.lan> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Daniel Thompson Cc: linux-pwm@vger.kernel.org, Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Subbaraman Narayanamurthy , linux-kernel@vger.kernel.org, Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org On Tue, Mar 10, 2020 at 02:34:32PM +0000, Daniel Thompson wrote: > This patch looks like it is a tiny change to get the pwm_backlight to > perform 64-bit division. Most of the above text is completely irrelevant > to the change contained in this patch. No need to justify the change in > the PWM structures here since that can go in the patch that changes > those structures. Just describe what this patch does, perhaps something > like the following: > > The PWM API will shortly switch the state.period and > state.duty_cycle fields to 64-bit values. Make pwm_bl > ready for this transition by adopting 64-bit division > macros. Will update the commit text accordingly. > Also please copy the backlight maintainers into the covering letter. It > is useful to place patches like this into context. Will do. Thank you. Guru Das. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E64FC10F27 for ; Tue, 10 Mar 2020 23:36:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3783521927 for ; Tue, 10 Mar 2020 23:36:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3783521927 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B5A66E8FB; Tue, 10 Mar 2020 23:36:16 +0000 (UTC) X-Greylist: delayed 365 seconds by postgrey-1.36 at gabe; Tue, 10 Mar 2020 18:18:48 UTC Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43B516E379 for ; Tue, 10 Mar 2020 18:18:48 +0000 (UTC) Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 10 Mar 2020 11:12:43 -0700 Received: from gurus-linux.qualcomm.com ([10.46.162.81]) by ironmsg05-sd.qualcomm.com with ESMTP; 10 Mar 2020 11:12:42 -0700 Received: by gurus-linux.qualcomm.com (Postfix, from userid 383780) id DE2854AAD; Tue, 10 Mar 2020 11:12:42 -0700 (PDT) Date: Tue, 10 Mar 2020 11:12:42 -0700 From: Guru Das Srinagesh To: Daniel Thompson Subject: Re: [PATCH v7 12/13] backlight: pwm_bl: Use 64-bit division macros for period and duty cycle Message-ID: <20200310181242.GA31738@codeaurora.org> References: <20200310143432.cfjlqac5x6oinshj@holly.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200310143432.cfjlqac5x6oinshj@holly.lan> User-Agent: Mutt/1.5.21 (2010-09-15) X-Mailman-Approved-At: Tue, 10 Mar 2020 23:36:13 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , Subbaraman Narayanamurthy , Lee Jones Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Mar 10, 2020 at 02:34:32PM +0000, Daniel Thompson wrote: > This patch looks like it is a tiny change to get the pwm_backlight to > perform 64-bit division. Most of the above text is completely irrelevant > to the change contained in this patch. No need to justify the change in > the PWM structures here since that can go in the patch that changes > those structures. Just describe what this patch does, perhaps something > like the following: > > The PWM API will shortly switch the state.period and > state.duty_cycle fields to 64-bit values. Make pwm_bl > ready for this transition by adopting 64-bit division > macros. Will update the commit text accordingly. > Also please copy the backlight maintainers into the covering letter. It > is useful to place patches like this into context. Will do. Thank you. Guru Das. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel