Re: [meta-ti] [thud/master][PATCH] sciclient-rtos: SRCREV update, adding steps to generate sysfw.bin

["Denys Dmytriyenko" <denys@ti.com>]

On Tue, Mar 10, 2020 at 02:33:56PM -0400, Radhakrishnan, Mahesh wrote:
> Yes. Sciclient is only for K3 devices I have addressed the review comment and sent a v2 patch for the same.

Thanks!

> -----Original Message-----
> From: Dmytriyenko, Denys 
> Sent: Tuesday, March 10, 2020 2:07 PM
> To: Radhakrishnan, Mahesh; meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti] [thud/master][PATCH] sciclient-rtos: SRCREV update, adding steps to generate sysfw.bin
> 
> Ping again. Any feedback?
> 
> On Mon, Mar 02, 2020 at 01:42:14PM -0500, Denys Dmytriyenko via Lists.Yoctoproject.Org wrote:
> > Ping.
> > 
> > On Thu, Feb 27, 2020 at 04:28:33PM -0500, Denys Dmytriyenko via Lists.Yoctoproject.Org wrote:
> > > On Wed, Feb 26, 2020 at 04:37:50PM -0500, Mahesh Radhakrishnan via Lists.Yoctoproject.Org wrote:
> > > > ---
> > > >  recipes-bsp/sciclient/sciclient-rtos_git.bb | 40 +++++++++++++++++++--
> > > >  1 file changed, 38 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/recipes-bsp/sciclient/sciclient-rtos_git.bb b/recipes-bsp/sciclient/sciclient-rtos_git.bb
> > > > index 6a3d79c3..ca3894fa 100644
> > > > --- a/recipes-bsp/sciclient/sciclient-rtos_git.bb
> > > > +++ b/recipes-bsp/sciclient/sciclient-rtos_git.bb
> > > > @@ -7,14 +7,15 @@ TI_PDK_COMP = "ti.drv.sciclient"
> > > >  PE = "1"
> > > >  
> > > >  LICENSE = "BSD-3-Clause"
> > > > -LIC_FILES_CHKSUM = "file://sciclient.h;beginline=1;endline=31;md5=7224b2eeca1444815f1737bfcdfa892a"
> > > > +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=99d7639a81c1ba1f16fd070a928ffddb"
> > > >  
> > > >  COMPATIBLE_MACHINE = "k3"
> > > >  PACKAGE_ARCH = "${MACHINE_ARCH}"
> > > >  
> > > > -PR = "r0"
> > > > +PR = "r1"
> > > >  
> > > >  DEPENDS_append = " osal-rtos common-csl-ip-rtos"
> > > > +DEPENDS_append_k3 = " openssl-native"
> > > 
> > > Isn't it redundant since the recipe is only compatible with "k3"?
> > > 
> > > 
> > > >  # Build with make instead of XDC
> > > >  TI_PDK_XDCMAKE = "0"
> > > > @@ -60,6 +61,41 @@ do_compile() {
> > > >      tar -cf sciclient.tar --exclude='*.tar' ./*
> > > >  }
> > > >  
> > > > +
> > > > +do_compile_prepend_am65xx-hs-evm() {
> > > > +
> > > > +    cd ${SCICLIENT_ROOTPATH}
> > > > +
> > > > +    # Saving the GP firmware to a different GP name
> > > > +    cp ${CP_ARGS} ./soc/V0/sysfw.bin ./soc/V0/sysfw-gp.bin
> > > > +    
> > > > +    cd ${SCICLIENT_ROOTPATH}/tools
> > > > +    # Create the .bin file for HS
> > > > +    ${SCICLIENT_ROOTPATH}/tools/firmwareHeaderGen.sh am65x-hs ${PDK_INSTALL_DIR}/packages
> > > > +    cd -
> > > > +}
> > > > +
> > > > +do_compile_prepend_am65xx-evm() {
> > > > +
> > > > +    cd ${SCICLIENT_ROOTPATH}/tools
> > > > +
> > > > +    # Create the .bin file for GP, PG1
> > > > +    ${SCICLIENT_ROOTPATH}/tools/firmwareHeaderGen.sh am65x ${PDK_INSTALL_DIR}/packages
> > > > +    # Create the .bin file for GP, PG2
> > > > +    ${SCICLIENT_ROOTPATH}/tools/firmwareHeaderGen.sh am65x_pg2 ${PDK_INSTALL_DIR}/packages
> > > > +    
> > > > +    cd -
> > > > +}
> > > > +
> > > > +
> > > > +do_compile_prepend_j7-evm() {
> > > > +
> > > > +    cd ${SCICLIENT_ROOTPATH}/tools
> > > > +    # Create the .bin file for GP
> > > > +    ${SCICLIENT_ROOTPATH}/tools/firmwareHeaderGen.sh j721e ${PDK_INSTALL_DIR}/packages
> > > > +    cd -
> > > > +}
> > > > +
> > > >  do_install() {
> > > >      cd ${SCICLIENT_ROOTPATH}
> > > >      install -d ${D}${PDK_INSTALL_DIR_RECIPE}/packages/ti/drv/sciclient
> > > > -- 
> > > > 2.17.1
> > > > 
> > > 
> > > > 
> > > 
> > 
> > > 
> > 
> 
> > 
>