From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21724C10F29 for ; Wed, 11 Mar 2020 07:19:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4E33208C3 for ; Wed, 11 Mar 2020 07:19:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u/iHAGbb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4E33208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wC5mfV8juhqDmLTVdoJz6hVkXgk12kChqw+UouNt2cE=; b=u/iHAGbbSGmJw0 RHeHeeKraX16qRgRfCOwRIljvxTUmwonyLkuff+niT5MX4JDmY9Ls5caM+1+hF4uzW58a4t4hs8t6 saZc42/cDutEGcJzXVs2yrDwUvOfpw/Lz8ruGPez+O+wqz4tM9J3MeI/2RinjELjhgwq8gYawrYAQ /rHnTns8dcshe8RS2c3Y9b7iRfk6FoQmMR8350EjhvOVGsdFjex9zPXdaJ3aTyqruajljD8l4x1ZH jTI4dhptVKTOtywA6HoQbNhtCOxUN0+SZSaGQHvtb9Cv1Ox/fw5tVCzxJd6ywiqGGVYwOnsxep/Gv KUuUiPwniEtm61yDfKVQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBveV-0007NR-7h; Wed, 11 Mar 2020 07:19:39 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBveQ-0007IW-TH for linux-mtd@lists.infradead.org; Wed, 11 Mar 2020 07:19:36 +0000 X-Originating-IP: 90.89.41.158 Received: from xps13 (lfbn-tou-1-1473-158.w90-89.abo.wanadoo.fr [90.89.41.158]) (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id F2B9E1BF209; Wed, 11 Mar 2020 07:19:18 +0000 (UTC) Date: Wed, 11 Mar 2020 08:19:18 +0100 From: Miquel Raynal To: Chuanhong Guo , linux-mtd@lists.infradead.org, Miquel Raynal , Boris Brezillon Subject: Re: [PATCH v4] mtd: nand: spi: rework detect procedure for different read id op Message-ID: <20200311081918.0f2c64c2@xps13> In-Reply-To: <20200310183338.19961-1-miquel.raynal@bootlin.com> References: <20200208074439.146296-1-gch981213@gmail.com> <20200310183338.19961-1-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_001935_109714_44DBC6D1 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQ2h1YW5ob25nLAoKTWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4g d3JvdGUgb24gVHVlLCAxMCBNYXIgMjAyMAoxOTozMzozOCArMDEwMDoKCj4gT24gU2F0LCAyMDIw LTAyLTA4IGF0IDA3OjQzOjUwIFVUQywgQ2h1YW5ob25nIEd1byB3cm90ZToKPiA+IEN1cnJlbnRs eSB0aGVyZSBhcmUgMyBkaWZmZXJlbnQgdmFyaWFudHMgb2YgcmVhZF9pZCBpbXBsZW1lbnRhdGlv bjoKPiA+IDEuIG9wY29kZSBvbmx5LiBGb3VuZCBpbiBHRDVGeEdRNHhGLgo+ID4gMi4gb3Bjb2Rl ICsgMSBhZGRyIGJ5dGUuIEZvdW5kIGluIEdENUd4R1E0eEEvRQo+ID4gMy4gb3Bjb2RlICsgMSBk dW1teSBieXRlLiBGb3VuZCBpbiBvdGhlciBjdXJyZW50bHkgc3VwcG9ydGVkIGNoaXBzLgo+ID4g Cj4gPiBPcmlnaW5hbCBpbXBsZW1lbnRhdGlvbiB3YXMgZm9yIHZhcmlhbnQgMSBhbmQgbGV0IGRl dGVjdCBmdW5jdGlvbgo+ID4gb2YgY2hpcHMgd2l0aCB2YXJpYW50IDIgYW5kIDMgdG8gaWdub3Jl IHRoZSBmaXJzdCBieXRlLiBUaGlzIGlzbid0Cj4gPiByb2J1c3Q6Cj4gPiAKPiA+IDEuIEZvciBj aGlwcyBvZiB2YXJpYW50IDIsIGlmIFNQSSBtYXN0ZXIgZG9lc24ndCBrZWVwIE1PU0kgbG93Cj4g PiBkdXJpbmcgcmVhZCwgY2hpcCB3aWxsIGdldCBhIHJhbmRvbSBpZCBvZmZzZXQsIGFuZCB0aGUg ZW50aXJlIGlkCj4gPiBidWZmZXIgd2lsbCBzaGlmdCBieSB0aGF0IG9mZnNldCwgY2F1c2luZyBk ZXRlY3QgZmFpbHVyZS4KPiA+IAo+ID4gMi4gRm9yIGNoaXBzIG9mIHZhcmlhbnQgMSwgaWYgaXQg aGFwcGVucyB0byBnZXQgYSBkZXZpZCB0aGF0IGVxdWFscwo+ID4gdG8gbWFudWZhY3R1cmUgaWQg b2YgdmFyaWFudCAyIG9yIDMgY2hpcHMsIGl0J2xsIGdldCBpbmNvcnJlY3RseQo+ID4gZGV0ZWN0 ZWQuCj4gPiAKPiA+IFRoaXMgcGF0Y2ggcmV3b3JrcyBkZXRlY3QgcHJvY2VkdXJlIHRvIGFkZHJl c3MgcHJvYmxlbXMgYWJvdmUuIE5ldwo+ID4gbG9naWMgZG8gZGV0ZWN0aW9uIGZvciBhbGwgdmFy aWFudHMgc2VwYXJhdGVkbHksIGluIDEtMi0zIG9yZGVyLgo+ID4gU2luY2UgYWxsIGN1cnJlbnQg ZGV0ZWN0IG1ldGhvZHMgZG8gZXhhY3RseSB0aGUgc2FtZSBpZCBtYXRjaGluZwo+ID4gcHJvY2Vk dXJlLCB1bmlmeSB0aGVtIGludG8gY29yZS5jIGFuZCByZW1vdmUgZGV0ZWN0IG1ldGhvZCBmcm9t Cj4gPiBtYW51ZmFjdHVyZV9vcHMuCj4gPiAKPiA+IFRlc3RlZCBvbiBHRDVGMUdRNFVBWUlHIGFu ZCBXMjVOMDFHVlpFSUcuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IENodWFuaG9uZyBHdW8gPGdj aDk4MTIxM0BnbWFpbC5jb20+ICAKPiAKPiBBcHBsaWVkIHRvIGh0dHBzOi8vZ2l0Lmtlcm5lbC5v cmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L210ZC9saW51eC5naXQgbmFuZC9uZXh0LCB0aGFu a3MuCgpJIGFsc28gY2hhbmdlZCB0aGUgcHJlZml4IHRvICJtdGQ6IHNwaW5hbmQ6Ii4KClRoYW5r cywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8980EC10F25 for ; Wed, 11 Mar 2020 07:19:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F668208C3 for ; Wed, 11 Mar 2020 07:19:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728516AbgCKHTb convert rfc822-to-8bit (ORCPT ); Wed, 11 Mar 2020 03:19:31 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:46907 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726672AbgCKHTb (ORCPT ); Wed, 11 Mar 2020 03:19:31 -0400 X-Originating-IP: 90.89.41.158 Received: from xps13 (lfbn-tou-1-1473-158.w90-89.abo.wanadoo.fr [90.89.41.158]) (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id F2B9E1BF209; Wed, 11 Mar 2020 07:19:18 +0000 (UTC) Date: Wed, 11 Mar 2020 08:19:18 +0100 From: Miquel Raynal To: Chuanhong Guo , linux-mtd@lists.infradead.org, Miquel Raynal , Boris Brezillon Cc: Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] mtd: nand: spi: rework detect procedure for different read id op Message-ID: <20200311081918.0f2c64c2@xps13> In-Reply-To: <20200310183338.19961-1-miquel.raynal@bootlin.com> References: <20200208074439.146296-1-gch981213@gmail.com> <20200310183338.19961-1-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chuanhong, Miquel Raynal wrote on Tue, 10 Mar 2020 19:33:38 +0100: > On Sat, 2020-02-08 at 07:43:50 UTC, Chuanhong Guo wrote: > > Currently there are 3 different variants of read_id implementation: > > 1. opcode only. Found in GD5FxGQ4xF. > > 2. opcode + 1 addr byte. Found in GD5GxGQ4xA/E > > 3. opcode + 1 dummy byte. Found in other currently supported chips. > > > > Original implementation was for variant 1 and let detect function > > of chips with variant 2 and 3 to ignore the first byte. This isn't > > robust: > > > > 1. For chips of variant 2, if SPI master doesn't keep MOSI low > > during read, chip will get a random id offset, and the entire id > > buffer will shift by that offset, causing detect failure. > > > > 2. For chips of variant 1, if it happens to get a devid that equals > > to manufacture id of variant 2 or 3 chips, it'll get incorrectly > > detected. > > > > This patch reworks detect procedure to address problems above. New > > logic do detection for all variants separatedly, in 1-2-3 order. > > Since all current detect methods do exactly the same id matching > > procedure, unify them into core.c and remove detect method from > > manufacture_ops. > > > > Tested on GD5F1GQ4UAYIG and W25N01GVZEIG. > > > > Signed-off-by: Chuanhong Guo > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. I also changed the prefix to "mtd: spinand:". Thanks, Miquèl