From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tobias Schramm <t.schramm@manjaro.org>
Cc: Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] power: supply: add CellWise cw2015 fuel gauge driver
Date: Wed, 11 Mar 2020 11:11:30 +0200 [thread overview]
Message-ID: <20200311091130.GC1922688@smile.fi.intel.com> (raw)
In-Reply-To: <503baadb-b8f2-f4bd-a1a8-44b2dc77b933@manjaro.org>
On Wed, Mar 11, 2020 at 09:48:30AM +0100, Tobias Schramm wrote:
> was just about to send v3.
>
> >
> > __be16 value;
> >
> >
> > ret = regmap(..., (...)value, sizeof(value));
Just checked this, simple &value works.
> > if (ret)
> > return ret; // note, you missed this in above.
> >
> > *val = be16_to_cpu(value);
> > return 0;
> >
>
> That implementation looks pretty clean. I'll take it.
Thank you.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-03-11 9:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 16:03 [PATCH v2 0/2] Add support for CellWise cw2015 fuel gauge Tobias Schramm
2020-03-09 16:03 ` [PATCH v2 1/2] dt-bindings: power: supply: cw2015_battery: add device tree binding documentation Tobias Schramm
2020-03-10 18:34 ` Rob Herring
2020-03-10 18:34 ` Rob Herring
2020-03-09 16:03 ` [PATCH v2 2/2] power: supply: add CellWise cw2015 fuel gauge driver Tobias Schramm
2020-03-10 10:10 ` Andy Shevchenko
2020-03-10 18:55 ` Tobias Schramm
2020-03-11 8:14 ` Andy Shevchenko
2020-03-11 8:48 ` Tobias Schramm
2020-03-11 9:11 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311091130.GC1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=t.schramm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.