Re: [PATCH v6 01/13] hw/i386: Introduce X86CPUTopoInfo to contain topology info

[Igor Mammedov <imammedo@redhat.com>]

On Tue, 10 Mar 2020 21:33:25 -0500
Babu Moger <babu.moger@amd.com> wrote:

> This is an effort to re-arrange few data structure for better readability.
> 
> 1. Add X86CPUTopoInfo which will have all the topology informations
>    required to build the cpu topology. There is no functional changes.
> 
> 2. Introduce init_topo_info to initialize X86CPUTopoInfo members from
>    X86MachineState.
> 
> 3. Update x86 unit tests for new calling convention with parameter X86CPUTopoInfo
> 
> There is no functional changes.

patch doesn't apply to current master, so I can't really test it
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
>  hw/i386/pc.c               |   12 ++++++------
>  hw/i386/x86.c              |   32 ++++++++++++++++++++++++--------
>  include/hw/i386/topology.h |   38 ++++++++++++++++++++++++--------------
>  include/hw/i386/x86.h      |    3 +++
>  tests/test-x86-cpuid.c     |   43 ++++++++++++++++++++++++-------------------
>  5 files changed, 81 insertions(+), 47 deletions(-)
> 
[...]
> diff --git a/hw/i386/x86.c b/hw/i386/x86.c
> index 322fb6abbc..03b8962c98 100644
> --- a/hw/i386/x86.c
> +++ b/hw/i386/x86.c
> @@ -57,6 +57,16 @@
>  /* Physical Address of PVH entry point read from kernel ELF NOTE */
>  static size_t pvh_start_addr;
>  
> +inline void init_topo_info(X86CPUTopoInfo *topo_info,
> +                                  const X86MachineState *x86ms)

not aligned properly

[...]