From: Guenter Roeck <linux@roeck-us.net>
To: Guru Das Srinagesh <gurus@codeaurora.org>
Cc: linux-pwm@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>,
linux-kernel@vger.kernel.org, "Kamil Debski" <kamil@wypas.org>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Jean Delvare" <jdelvare@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v8 03/12] hwmon: pwm-fan: Use 64-bit division macro
Date: Wed, 11 Mar 2020 08:08:16 -0700 [thread overview]
Message-ID: <20200311150816.GA10018@roeck-us.net> (raw)
In-Reply-To: <237b1b5ae59d072b576d300cdc0c2a1242b18516.1583889178.git.gurus@codeaurora.org>
On Tue, Mar 10, 2020 at 06:41:12PM -0700, Guru Das Srinagesh wrote:
> Since the PWM framework is switching struct pwm_args.period's datatype
> to u64, prepare for this transition by using DIV_ROUND_UP_ULL to handle
> a 64-bit dividend.
>
> Cc: Kamil Debski <kamil@wypas.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: linux-hwmon@vger.kernel.org
>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
Not sure if I entirely buy the use case, but then the performance
impact is minimal, at least for this driver, so
Acked-by: Guenter Roeck <linux@roeck-us.net>
Guenter
> ---
> drivers/hwmon/pwm-fan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
> index 42ffd2e..283423a 100644
> --- a/drivers/hwmon/pwm-fan.c
> +++ b/drivers/hwmon/pwm-fan.c
> @@ -437,7 +437,7 @@ static int pwm_fan_resume(struct device *dev)
> return 0;
>
> pwm_get_args(ctx->pwm, &pargs);
> - duty = DIV_ROUND_UP(ctx->pwm_value * (pargs.period - 1), MAX_PWM);
> + duty = DIV_ROUND_UP_ULL(ctx->pwm_value * (pargs.period - 1), MAX_PWM);
> ret = pwm_config(ctx->pwm, duty, pargs.period);
> if (ret)
> return ret;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2020-03-11 15:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 1:41 [PATCH v8 00/12] Convert PWM period and duty cycle to u64 Guru Das Srinagesh
2020-03-11 1:41 ` [Intel-gfx] " Guru Das Srinagesh
2020-03-11 1:41 ` Guru Das Srinagesh
2020-03-11 1:41 ` Guru Das Srinagesh
2020-03-11 1:41 ` [PATCH v8 01/12] clk: pwm: Use 64-bit division function Guru Das Srinagesh
2020-03-11 16:58 ` David Laight
2020-03-12 2:09 ` Guru Das Srinagesh
2020-03-12 9:14 ` David Laight
2020-03-12 19:09 ` Guru Das Srinagesh
2020-03-19 20:53 ` Guru Das Srinagesh
2020-04-09 2:40 ` Guru Das Srinagesh
2020-03-11 1:41 ` [PATCH v8 02/12] drm/i915: Use 64-bit division macro Guru Das Srinagesh
2020-03-11 1:41 ` [Intel-gfx] " Guru Das Srinagesh
2020-03-11 1:41 ` Guru Das Srinagesh
2020-03-11 1:41 ` [PATCH v8 03/12] hwmon: pwm-fan: " Guru Das Srinagesh
2020-03-11 15:08 ` Guenter Roeck [this message]
2020-03-11 1:41 ` [PATCH v8 04/12] ir-rx51: " Guru Das Srinagesh
2020-03-11 2:11 ` Sean Young
2020-03-11 1:41 ` [PATCH v8 05/12] pwm: clps711x: " Guru Das Srinagesh
2020-03-11 1:41 ` [PATCH v8 06/12] pwm: pwm-imx-tpm: " Guru Das Srinagesh
2020-03-11 1:41 ` [PATCH v8 07/12] pwm: imx27: Use 64-bit division macro and function Guru Das Srinagesh
2020-03-11 1:41 ` [PATCH v8 08/12] pwm: sifive: Use 64-bit division macro Guru Das Srinagesh
2020-03-11 1:41 ` Guru Das Srinagesh
2020-03-11 1:41 ` [PATCH v8 09/12] pwm: stm32-lp: Use %llu format specifier for period Guru Das Srinagesh
2020-03-11 1:41 ` [PATCH v8 10/12] pwm: sun4i: Use 64-bit division function Guru Das Srinagesh
2020-03-11 3:35 ` Chen-Yu Tsai
2020-03-11 1:41 ` [PATCH v8 11/12] backlight: pwm_bl: " Guru Das Srinagesh
2020-03-11 1:41 ` Guru Das Srinagesh
2020-03-11 1:41 ` Guru Das Srinagesh
2020-03-11 10:05 ` Daniel Thompson
2020-03-11 10:05 ` Daniel Thompson
2020-03-11 10:05 ` Daniel Thompson
2020-03-11 1:41 ` [PATCH v8 12/12] pwm: core: Convert period and duty cycle to u64 Guru Das Srinagesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311150816.GA10018@roeck-us.net \
--to=linux@roeck-us.net \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=gurus@codeaurora.org \
--cc=jdelvare@suse.com \
--cc=kamil@wypas.org \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.