From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH v2 2/2] xfs: fix xfs_rmap_has_other_keys usage of ECANCELED
Date: Wed, 11 Mar 2020 09:07:31 -0700 [thread overview]
Message-ID: <20200311160731.GA28849@infradead.org> (raw)
In-Reply-To: <20200311160329.GF8045@magnolia>
On Wed, Mar 11, 2020 at 09:03:29AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> In e7ee96dfb8c26, we converted all ITER_ABORT users to use ECANCELED
> instead, but we forgot to teach xfs_rmap_has_other_keys not to return
> that magic value to callers. Fix it now by using ECANCELED both to
> abort the iteration and to signal that we found another reverse mapping.
> This enables us to drop the separate boolean flag.
>
> Fixes: e7ee96dfb8c26 ("xfs: remove all *_ITER_ABORT values")
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-03-11 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 0:46 [PATCH 0/2] xfs: random fixes Darrick J. Wong
2020-03-11 0:47 ` [PATCH 1/2] xfs: fix use-after-free when aborting corrupt attr inactivation Darrick J. Wong
2020-03-11 5:14 ` Dave Chinner
2020-03-11 6:35 ` Christoph Hellwig
2020-03-11 0:47 ` [PATCH 2/2] xfs: fix xfs_rmap_has_other_keys usage of ECANCELED Darrick J. Wong
2020-03-11 5:22 ` Dave Chinner
2020-03-11 6:40 ` Christoph Hellwig
2020-03-11 15:47 ` Darrick J. Wong
2020-03-11 15:52 ` Christoph Hellwig
2020-03-11 16:02 ` Darrick J. Wong
2020-03-11 16:03 ` [PATCH v2 " Darrick J. Wong
2020-03-11 16:07 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311160731.GA28849@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.