All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Remi Pommarel <repk@triplefau.lt>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
	QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Remi Pommarel <repk@triplefau.lt>,
	stable@vger.kernel.org
Subject: Re: [PATCH] ath9k: Handle txpower changes even when TPC is disabled
Date: Wed, 11 Mar 2020 16:53:30 +0000 (UTC)	[thread overview]
Message-ID: <20200311165330.7184BC433D2@smtp.codeaurora.org> (raw)
In-Reply-To: <20200229161347.31341-1-repk@triplefau.lt>

Remi Pommarel <repk@triplefau.lt> wrote:

> When TPC is disabled IEEE80211_CONF_CHANGE_POWER event can be handled to
> reconfigure HW's maximum txpower.
> 
> This fixes 0dBm txpower setting when user attaches to an interface for
> the first time with the following scenario:
> 
> ieee80211_do_open()
>     ath9k_add_interface()
>         ath9k_set_txpower() /* Set TX power with not yet initialized
>                                sc->hw->conf.power_level */
> 
>     ieee80211_hw_config() /* Iniatilize sc->hw->conf.power_level and
>                              raise IEEE80211_CONF_CHANGE_POWER */
> 
>     ath9k_config() /* IEEE80211_CONF_CHANGE_POWER is ignored */
> 
> This issue can be reproduced with the following:
> 
>   $ modprobe -r ath9k
>   $ modprobe ath9k
>   $ wpa_supplicant -i wlan0 -c /tmp/wpa.conf &
>   $ iw dev /* Here TX power is either 0 or 3 depending on RF chain */
>   $ killall wpa_supplicant
>   $ iw dev /* TX power goes back to calibrated value and subsequent
>               calls will be fine */
> 
> Fixes: 283dd11994cde ("ath9k: add per-vif TX power capability")
> Cc: stable@vger.kernel.org
> Signed-off-by: Remi Pommarel <repk@triplefau.lt>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

968ae2caad07 ath9k: Handle txpower changes even when TPC is disabled

-- 
https://patchwork.kernel.org/patch/11413917/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      reply	other threads:[~2020-03-11 16:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-29 16:13 [PATCH] ath9k: Handle txpower changes even when TPC is disabled Remi Pommarel
2020-03-11 16:53 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200311165330.7184BC433D2@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=ath9k-devel@qca.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=repk@triplefau.lt \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.