From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/pkg-meson.mk: Fix cross-compilation.conf
Date: Wed, 11 Mar 2020 19:44:05 +0100 [thread overview]
Message-ID: <20200311194405.066b502f@gmx.net> (raw)
In-Reply-To: <20200311105930.21564-1-glex.spb@gmail.com>
Hello Gleb,
thanks for the patch, only one nitpick below...
On Wed, 11 Mar 2020 10:59:30 +0000, Gleb Mazovetskiy <glex.spb@gmail.com> wrote:
> $$(STAGING_DIR) -> $(STAGING_DIR) in PKG_MESON_INSTALL_CROSS_CONF.
>
> $$ resulted in `$(STAGING_DIR)` in the file instead of the expanded
> value.
Please mention that the affected file is the 'host/etc/meson/cross-compilation.conf' one
(and not the per-package ones)...
With this fixed you can add my
Reviewed-by: Peter Seiderer <ps.report@gmx.net>
Regards,
Peter
>
> Signed-off-by: Gleb Mazovetskiy <glex.spb@gmail.com>
> ---
> package/pkg-meson.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
> index 642b715938..416129f6fe 100644
> --- a/package/pkg-meson.mk
> +++ b/package/pkg-meson.mk
> @@ -193,7 +193,7 @@ define PKG_MESON_INSTALL_CROSS_CONF
> -e 's%@TARGET_LDFLAGS@%$(call make-comma-list,$(TARGET_LDFLAGS))@PKG_TARGET_CFLAGS@%g' \
> -e 's%@TARGET_CXXFLAGS@%$(call make-comma-list,$(TARGET_CXXFLAGS))@PKG_TARGET_CFLAGS@%g' \
> -e 's%@HOST_DIR@%$(HOST_DIR)%g' \
> - -e 's%@STAGING_DIR@%$$(STAGING_DIR)%g' \
> + -e 's%@STAGING_DIR@%$(STAGING_DIR)%g' \
> $(HOST_MESON_PKGDIR)/cross-compilation.conf.in \
> > $(HOST_DIR)/etc/meson/cross-compilation.conf.in
> sed -e 's%@PKG_TARGET_CFLAGS@%%g' \
next prev parent reply other threads:[~2020-03-11 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 10:59 [Buildroot] [PATCH 1/1] package/pkg-meson.mk: Fix cross-compilation.conf Gleb Mazovetskiy
2020-03-11 18:44 ` Peter Seiderer [this message]
2020-03-11 19:11 ` Gleb Mazovetskiy
2020-03-11 19:15 ` Gleb Mazovetskiy
2020-03-11 21:33 ` Yann E. MORIN
2020-03-11 21:31 ` Yann E. MORIN
2020-03-21 19:39 ` Peter Korsgaard
2020-03-11 19:19 ` Gleb Mazovetskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311194405.066b502f@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.