From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62405C0044D for ; Wed, 11 Mar 2020 22:33:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50DE820757 for ; Wed, 11 Mar 2020 22:33:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583966001; bh=JLJTfmLMhvgovHL3TFJY94u6dR2CKasrJ+XunuPsEnY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hNvxM5gd5aPUZe6kT2zcT3xCfac5p8eb258jlg3C6omzeH23uuZXmG1MKJRTESaHX lh9v8YGQ9qHMttbQt3RloR6aG2sCwk3s3E5ao8RP3YFLO5+C7s1o9tTjr4wfx5Bf3d aQXlWOPXkjtTbppFM0DSJe/z39WGtWgSjCev9S2Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387477AbgCKWdU (ORCPT ); Wed, 11 Mar 2020 18:33:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:38080 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387412AbgCKWdS (ORCPT ); Wed, 11 Mar 2020 18:33:18 -0400 Received: from kicinski-fedora-PC1C0HJN.thefacebook.com (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DEC5220768; Wed, 11 Mar 2020 22:33:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583965998; bh=JLJTfmLMhvgovHL3TFJY94u6dR2CKasrJ+XunuPsEnY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vwPszCMKOi30PFTnJCaq8YA+BvZ4qaw+OcszPU+2BFkktGyUkYVlXrvLNLohTn6yj w3LfQerjQd6ke1hHaJlcKlMEK5S0rOvZA0LkZ8VYkT0ArDvaZRrSxwLHB5Z8bT091F Var7al4EaCMMiLPWZ1h6qZwboz/vsgp8dv213G54= From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, mkubecek@suse.cz, sathya.perla@broadcom.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, madalin.bucur@nxp.com, fugang.duan@nxp.com, claudiu.manoil@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, jacob.e.keller@intel.com, alexander.h.duyck@linux.intel.com, Jakub Kicinski Subject: [PATCH net-next 10/15] net: iavf: reject unsupported coalescing params Date: Wed, 11 Mar 2020 15:32:57 -0700 Message-Id: <20200311223302.2171564-11-kuba@kernel.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200311223302.2171564-1-kuba@kernel.org> References: <20200311223302.2171564-1-kuba@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c index f807e2c7597f..2c39d46b6138 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c +++ b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c @@ -996,6 +996,10 @@ static int iavf_set_rxfh(struct net_device *netdev, const u32 *indir, } static const struct ethtool_ops iavf_ethtool_ops = { + .supported_coalesce_params = ETHTOOL_COALESCE_USECS | + ETHTOOL_COALESCE_MAX_FRAMES | + ETHTOOL_COALESCE_MAX_FRAMES_IRQ | + ETHTOOL_COALESCE_USE_ADAPTIVE, .get_drvinfo = iavf_get_drvinfo, .get_link = ethtool_op_get_link, .get_ringparam = iavf_get_ringparam, -- 2.24.1