From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: willemdebruijn.kernel@gmail.com, netdev@vger.kernel.org,
willemb@google.com
Subject: Re: [PATCH net] net/packet: tpacket_rcv: do not increment ring index on drop
Date: Thu, 12 Mar 2020 02:27:58 -0400 [thread overview]
Message-ID: <20200312022748-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200311.231327.132987828940639157.davem@davemloft.net>
On Wed, Mar 11, 2020 at 11:13:27PM -0700, David Miller wrote:
> From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Date: Mon, 9 Mar 2020 11:34:35 -0400
>
> > From: Willem de Bruijn <willemb@google.com>
> >
> > In one error case, tpacket_rcv drops packets after incrementing the
> > ring producer index.
> >
> > If this happens, it does not update tp_status to TP_STATUS_USER and
> > thus the reader is stalled for an iteration of the ring, causing out
> > of order arrival.
> >
> > The only such error path is when virtio_net_hdr_from_skb fails due
> > to encountering an unknown GSO type.
> >
> > Signed-off-by: Willem de Bruijn <willemb@google.com>
>
> I'm applying this, as it fixes the ring state management in this case.
>
> The question of what we should actually be doing for unknown GSO types
> is a separate discussion.
>
> Thanks Willem.
Absolutely, I agree
Acked-by: Michael S. Tsirkin <mst@redhat.com>
prev parent reply other threads:[~2020-03-12 6:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 15:34 [PATCH net] net/packet: tpacket_rcv: do not increment ring index on drop Willem de Bruijn
2020-03-09 15:42 ` Willem de Bruijn
2020-03-09 15:50 ` Willem de Bruijn
2020-03-10 6:46 ` Michael S. Tsirkin
2020-03-10 6:43 ` Michael S. Tsirkin
2020-03-10 12:49 ` Willem de Bruijn
2020-03-10 12:59 ` Michael S. Tsirkin
2020-03-10 14:16 ` Willem de Bruijn
2020-03-10 14:43 ` Michael S. Tsirkin
2020-03-10 15:38 ` Willem de Bruijn
2020-03-10 16:14 ` Willem de Bruijn
2020-03-10 21:29 ` Michael S. Tsirkin
2020-03-10 21:35 ` Willem de Bruijn
2020-03-10 21:57 ` Michael S. Tsirkin
2020-03-10 23:13 ` Willem de Bruijn
2020-03-11 7:56 ` Michael S. Tsirkin
2020-03-11 14:31 ` Willem de Bruijn
2020-03-11 21:25 ` Michael S. Tsirkin
2020-03-11 21:49 ` Willem de Bruijn
2020-03-12 6:13 ` David Miller
2020-03-12 6:27 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312022748-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.