From: Greg KH <gregkh@linuxfoundation.org>
To: Lourdes Pedrajas <lu@pplo.net>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v3] staging: rtl8192u: r8192U_wx: use pr_warn() instead of printk()
Date: Thu, 12 Mar 2020 09:20:15 +0100 [thread overview]
Message-ID: <20200312082015.GH11746@kroah.com> (raw)
In-Reply-To: <20200311191638.27974-1-lu@pplo.net>
On Wed, Mar 11, 2020 at 08:16:38PM +0100, Lourdes Pedrajas wrote:
> printk() is deprecated, use pr_warn() instead, which is a message printing
> function for network devices, defined in include/linux/netdevice.h.
> Issue found by checkpatch.
>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> Changes since v2:
> - Correct the subject line from v1 and use the generic pr_warn() since
> netdev_warn() expect a pointer to a net device.
As Julia pointed out, this is not correct, you can use netdev_warn()
here.
thanks,
greg k-h
prev parent reply other threads:[~2020-03-12 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 19:16 [PATCH v3] staging: rtl8192u: r8192U_wx: use pr_warn() instead of printk() Lourdes Pedrajas
2020-03-11 19:51 ` [Outreachy kernel] " Julia Lawall
2020-03-12 8:20 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312082015.GH11746@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=lu@pplo.net \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.