* [PATCH] staging: ralink-gdma: ralink-gdma: change variable to a non-volatile
@ 2020-03-12 12:17 Lourdes Pedrajas
2020-03-12 12:30 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Lourdes Pedrajas @ 2020-03-12 12:17 UTC (permalink / raw)
To: outreachy-kernel, gregkh; +Cc: Lourdes Pedrajas
Change variable declaration volatile unsigned long chan_issued to
unsigned long chan_issued
Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
Issue found with checkpatch.pl
Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
drivers/staging/ralink-gdma/ralink-gdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index eabf1093328e..8d1b81f720fd 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -122,7 +122,7 @@ struct gdma_dma_dev {
struct gdma_data *data;
void __iomem *base;
struct tasklet_struct task;
- volatile unsigned long chan_issued;
+ unsigned long chan_issued;
atomic_t cnt;
struct gdma_dmaengine_chan chan[];
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: ralink-gdma: ralink-gdma: change variable to a non-volatile
2020-03-12 12:17 [PATCH] staging: ralink-gdma: ralink-gdma: change variable to a non-volatile Lourdes Pedrajas
@ 2020-03-12 12:30 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-03-12 12:30 UTC (permalink / raw)
To: Lourdes Pedrajas; +Cc: outreachy-kernel
On Thu, Mar 12, 2020 at 01:17:56PM +0100, Lourdes Pedrajas wrote:
> Change variable declaration volatile unsigned long chan_issued to
> unsigned long chan_issued
>
> Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
>
> Issue found with checkpatch.pl
>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> drivers/staging/ralink-gdma/ralink-gdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index eabf1093328e..8d1b81f720fd 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -122,7 +122,7 @@ struct gdma_dma_dev {
> struct gdma_data *data;
> void __iomem *base;
> struct tasklet_struct task;
> - volatile unsigned long chan_issued;
> + unsigned long chan_issued;
Same comment here as on the other patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-12 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-12 12:17 [PATCH] staging: ralink-gdma: ralink-gdma: change variable to a non-volatile Lourdes Pedrajas
2020-03-12 12:30 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.