From: Stefano Brivio <sbrivio@redhat.com>
To: Lourdes Pedrajas <lu@pplo.net>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
matthias.bgg@gmail.com
Subject: Re: [Outreachy kernel] [PATCH] staging: mt7621-dma: mtk-hsdma: make a variable non-volatile
Date: Thu, 12 Mar 2020 13:31:12 +0100 [thread overview]
Message-ID: <20200312133112.4f61c60b@elisabeth> (raw)
In-Reply-To: <20200312121548.6719-1-lu@pplo.net>
On Thu, 12 Mar 2020 13:15:48 +0100
Lourdes Pedrajas <lu@pplo.net> wrote:
> Change variable declaration volatile unsigned long chan_issued to
> unsigned long chan_issued
>
> Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
This needs some more details. From that same guide:
Patches to remove volatile variables are generally welcome - as
long as they come with a justification which shows that the
concurrency issues have been properly thought through.
so, here you need to investigate what that "volatile" was supposed to
achieve, if it is achieved by other means, if some form of locking is
needed instead, if we end up in one of the "exception" cases also
listed in that guide.
--
Stefano
next prev parent reply other threads:[~2020-03-12 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 12:15 [PATCH] staging: mt7621-dma: mtk-hsdma: make a variable non-volatile Lourdes Pedrajas
2020-03-12 12:29 ` Greg KH
2020-03-12 12:31 ` Stefano Brivio [this message]
2020-03-12 19:43 ` [Outreachy kernel] " Lourdes Pedrajas
2020-03-12 20:43 ` Greg KH
2020-03-12 20:57 ` Lourdes Pedrajas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312133112.4f61c60b@elisabeth \
--to=sbrivio@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=lu@pplo.net \
--cc=matthias.bgg@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.