From: Leon Romanovsky <leon@kernel.org>
To: Andrew Boyer <aboyer@pensando.io>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Weihang Li <liweihang@huawei.com>,
dledford@redhat.com, linux-rdma@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH for-next] RDMA/hns: Add interface to support lock free
Date: Thu, 12 Mar 2020 19:26:09 +0200 [thread overview]
Message-ID: <20200312172609.GC31504@unreal> (raw)
In-Reply-To: <42CC9743-9112-4954-807D-2A7A856BC78E@pensando.io>
On Thu, Mar 12, 2020 at 01:04:05PM -0400, Andrew Boyer wrote:
> What would you say to a per-process env variable to disable locking in a userspace provider?
We have thread-domain concept in libibverbs to achieve lockless flows.
https://github.com/linux-rdma/rdma-core/blob/master/libibverbs/man/ibv_alloc_td.3
BTW, please don't use top-posting.
Thanks
>
> -Andrew
>
> > On Mar 12, 2020, at 1:02 PM, Jason Gunthorpe <jgg@ziepe.ca> wrote:
> >
> > On Thu, Mar 12, 2020 at 11:26:40AM +0200, Leon Romanovsky wrote:
> >> On Thu, Mar 12, 2020 at 03:48:10PM +0800, Weihang Li wrote:
> >>> From: Jiaran Zhang <zhangjiaran@huawei.com>
> >>>
> >>> In some scenarios, ULP can ensure that there is no concurrency when
> >>> processing io, thus lock free can be used to improve performance.
> >>>
> >>> Signed-off-by: Jiaran Zhang <zhangjiaran@huawei.com>
> >>> Signed-off-by: Yixian Liu <liuyixian@huawei.com>
> >>> Signed-off-by: Weihang Li <liweihang@huawei.com>
> >>> drivers/infiniband/hw/hns/hns_roce_device.h | 1 +
> >>> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 112 ++++++++++++++++++++--------
> >>> drivers/infiniband/hw/hns/hns_roce_qp.c | 1 +
> >>> 3 files changed, 84 insertions(+), 30 deletions(-)
> >>>
> >>
> >> NAK, everything in this patch is wrong, starting from exposure,
> >> implementation and description.
> >
> > Yes, complete no on a module parameter to disable locking.
> >
> > Jason
>
next prev parent reply other threads:[~2020-03-12 17:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 7:48 [PATCH for-next] RDMA/hns: Add interface to support lock free Weihang Li
2020-03-12 9:26 ` Leon Romanovsky
2020-03-12 17:02 ` Jason Gunthorpe
[not found] ` <42CC9743-9112-4954-807D-2A7A856BC78E@pensando.io>
2020-03-12 17:26 ` Leon Romanovsky [this message]
2020-03-12 17:27 ` Jason Gunthorpe
2020-03-13 6:02 ` liweihang
2020-03-13 12:18 ` Jason Gunthorpe
2020-03-14 3:44 ` liweihang
2020-03-14 9:49 ` Leon Romanovsky
2020-03-14 18:07 ` Leon Romanovsky
2020-03-16 10:46 ` liweihang
2020-03-16 12:12 ` Jason Gunthorpe
2020-03-16 13:04 ` Leon Romanovsky
2020-03-16 13:29 ` liweihang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312172609.GC31504@unreal \
--to=leon@kernel.org \
--cc=aboyer@pensando.io \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liweihang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.