From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH 2/5] xfs: remove the unused XLOG_UNMOUNT_REC_TYPE define
Date: Thu, 12 Mar 2020 16:45:12 -0700 [thread overview]
Message-ID: <20200312234512.GT8045@magnolia> (raw)
In-Reply-To: <20200312143959.583781-3-hch@lst.de>
On Thu, Mar 12, 2020 at 03:39:56PM +0100, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_log_priv.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index e400170ff4af..2b0aec37e73e 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -525,12 +525,6 @@ xlog_cil_force(struct xlog *log)
> xlog_cil_force_lsn(log, log->l_cilp->xc_current_sequence);
> }
>
> -/*
> - * Unmount record type is used as a pseudo transaction type for the ticket.
> - * It's value must be outside the range of XFS_TRANS_* values.
> - */
> -#define XLOG_UNMOUNT_REC_TYPE (-1U)
> -
> /*
> * Wrapper function for waiting on a wait queue serialised against wakeups
> * by a spinlock. This matches the semantics of all the wait queues used in the
> --
> 2.24.1
>
next prev parent reply other threads:[~2020-03-12 23:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 14:39 misc log cleanups Christoph Hellwig
2020-03-12 14:39 ` [PATCH 1/5] xfs: mark XLOG_FORCED_SHUTDOWN as unlikely Christoph Hellwig
2020-03-12 23:45 ` Darrick J. Wong
2020-03-12 14:39 ` [PATCH 2/5] xfs: remove the unused XLOG_UNMOUNT_REC_TYPE define Christoph Hellwig
2020-03-12 23:45 ` Darrick J. Wong [this message]
2020-03-12 14:39 ` [PATCH 3/5] xfs: remove the unused return value from xfs_log_unmount_write Christoph Hellwig
2020-03-12 23:49 ` Darrick J. Wong
2020-03-13 11:18 ` Christoph Hellwig
2020-03-12 14:39 ` [PATCH 4/5] xfs: remove dead code " Christoph Hellwig
2020-03-12 23:51 ` Darrick J. Wong
2020-03-12 14:39 ` [PATCH 5/5] xfs: cleanup xfs_log_unmount_write Christoph Hellwig
2020-03-12 23:52 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312234512.GT8045@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.