From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F4DCC10DCE for ; Fri, 13 Mar 2020 01:26:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9CCD206F7 for ; Fri, 13 Mar 2020 01:26:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="fRIau9xa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727015AbgCMB0T (ORCPT ); Thu, 12 Mar 2020 21:26:19 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:42478 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726620AbgCMB0T (ORCPT ); Thu, 12 Mar 2020 21:26:19 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1584062778; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=DMvCcIAMOenOFGODAkqdoJHng9kOVkfWjVR4kCCv2yI=; b=fRIau9xaG4U2N9Jm4cSol2JRk7bQvOEH8gYdboN2eD/3Ey2KCj6q8lo/bHpoTWWEEp6cv4XV VaTRCdkzJdVbFk35yvMPcliA2045DzchQnM6qM7AA5YVas4zRRWBoshCXm/x/U2cXw9HSpEy kxjOkAFQohz3UvyP4qvTOAuSbNs= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e6ae134.7f8b3f055bc8-smtp-out-n05; Fri, 13 Mar 2020 01:26:12 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5BF21C433D2; Fri, 13 Mar 2020 01:26:11 +0000 (UTC) Received: from codeaurora.org (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: stummala) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0F6F0C433CB; Fri, 13 Mar 2020 01:26:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0F6F0C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=stummala@codeaurora.org Date: Fri, 13 Mar 2020 06:56:04 +0530 From: Sahitya Tummala To: Jaegeuk Kim Cc: Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix long latency due to discard during umount Message-ID: <20200313012604.GI20234@codeaurora.org> References: <1584011671-20939-1-git-send-email-stummala@codeaurora.org> <20200312170242.GA185506@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200312170242.GA185506@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2020 at 10:02:42AM -0700, Jaegeuk Kim wrote: > On 03/12, Sahitya Tummala wrote: > > F2FS already has a default timeout of 5 secs for discards that > > can be issued during umount, but it can take more than the 5 sec > > timeout if the underlying UFS device queue is already full and there > > are no more available free tags to be used. In that case, submit_bio() > > will wait for the already queued discard requests to complete to get > > a free tag, which can potentially take way more than 5 sec. > > > > Fix this by submitting the discard requests with REQ_NOWAIT > > flags during umount. This will return -EAGAIN for UFS queue/tag full > > scenario without waiting in the context of submit_bio(). The FS can > > then handle these requests by retrying again within the stipulated > > discard timeout period to avoid long latencies. > > > > Signed-off-by: Sahitya Tummala > > --- > > fs/f2fs/segment.c | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > > index fb3e531..a06bbac 100644 > > --- a/fs/f2fs/segment.c > > +++ b/fs/f2fs/segment.c > > @@ -1124,10 +1124,13 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi, > > struct discard_cmd_control *dcc = SM_I(sbi)->dcc_info; > > struct list_head *wait_list = (dpolicy->type == DPOLICY_FSTRIM) ? > > &(dcc->fstrim_list) : &(dcc->wait_list); > > - int flag = dpolicy->sync ? REQ_SYNC : 0; > > + int flag; > > block_t lstart, start, len, total_len; > > int err = 0; > > > > + flag = dpolicy->sync ? REQ_SYNC : 0; > > + flag |= dpolicy->type == DPOLICY_UMOUNT ? REQ_NOWAIT : 0; > > + > > if (dc->state != D_PREP) > > return 0; > > > > @@ -1203,6 +1206,11 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi, > > bio->bi_end_io = f2fs_submit_discard_endio; > > bio->bi_opf |= flag; > > submit_bio(bio); > > + if ((flag & REQ_NOWAIT) && (dc->error == -EAGAIN)) { > > + dc->state = D_PREP; > > + err = dc->error; > > + break; > > + } > > > > atomic_inc(&dcc->issued_discard); > > > > @@ -1510,6 +1518,10 @@ static int __issue_discard_cmd(struct f2fs_sb_info *sbi, > > } > > > > __submit_discard_cmd(sbi, dpolicy, dc, &issued); > > + if (dc->error == -EAGAIN) { > > + congestion_wait(BLK_RW_ASYNC, HZ/50); > > --> need to be DEFAULT_IO_TIMEOUT Yes, i will update it. > > > + __relocate_discard_cmd(dcc, dc); > > It seems we need to submit bio first, and then move dc to wait_list, if there's > no error, in __submit_discard_cmd(). Yes, that is not changed and it still happens for the failed request that is re-queued here too when it gets submitted again later. I am requeuing the discard request failed with -EAGAIN error back to dcc->pend_list[] from wait_list. It will call submit_bio() for this request and also move to wait_list when it calls __submit_discard_cmd() again next time. Please let me know if I am missing anything? Thanks, > > > + } > > > > if (issued >= dpolicy->max_requests) > > break; > > -- > > Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. > > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. -- -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.