From: ling.ma.program@gmail.com
To: linux-kernel@vger.kernel.org
Cc: ling.ml@antfin.com
Subject: [RFC PATCH] locks:Remove spinlock in unshare_files
Date: Fri, 13 Mar 2020 11:10:17 +0800 [thread overview]
Message-ID: <20200313031017.71090-1-ling.ma.program@gmail.com> (raw)
From: Ma Ling <ling.ml@antfin.com>
Processor support atomic operation for long/int/short/char type,
we use the feature to avoid spinlock, which cost hundreds cycles.
Appreciate your comments
Ling
Signed-off-by: Ma Ling <ling.ml@antfin.com>
---
kernel/fork.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/fork.c b/kernel/fork.c
index 60a1295..fe54600 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -3041,9 +3041,7 @@ int unshare_files(struct files_struct **displaced)
return error;
}
*displaced = task->files;
- task_lock(task);
- task->files = copy;
- task_unlock(task);
+ WRITE_ONCE(task->files, copy);
return 0;
}
--
1.8.3.1
next reply other threads:[~2020-03-13 3:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 3:10 ling.ma.program [this message]
2020-03-16 13:25 ` [RFC PATCH] locks:Remove spinlock in unshare_files Ling Ma
2020-03-16 13:39 ` Peter Zijlstra
2020-03-16 18:35 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313031017.71090-1-ling.ma.program@gmail.com \
--to=ling.ma.program@gmail.com \
--cc=ling.ml@antfin.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.