From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 535E7C5ACC0 for ; Fri, 13 Mar 2020 10:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DB0A2073E for ; Fri, 13 Mar 2020 10:15:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GVMDp2vZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726387AbgCMKPd (ORCPT ); Fri, 13 Mar 2020 06:15:33 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:54676 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgCMKPb (ORCPT ); Fri, 13 Mar 2020 06:15:31 -0400 Received: by mail-wm1-f65.google.com with SMTP id n8so9252317wmc.4 for ; Fri, 13 Mar 2020 03:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=A2S0VguwI+vPRoafp0n7H/FnoxCrEJkQC7JvYKj1Y0s=; b=GVMDp2vZE2aQwlKRTXncVtfN/X+6h48E0TlmseeRuAA107vTByb4SPEwMedGts2FpH 0TL7glG8mEnbMDZ+queQzD2z8DhUOZNdJH7ieZjOQnso4/ztWA4Zn75c65eSChADubSd 0cXZHBjArc0TCK17CXch9WBT9JSoawEIY9faPIiTiyZVLh7CB+EXTkP4tDkHsfeB1+R2 YXRhfNpkpNTIcVQmQ/Elu9NY3FwXfyvYutM+MW2tImKrOwQKW22UE3kEC/U09RRMs36N k87s/4AcSbJhgTuxTtpxn6vzTgZzEV/FulMOW4LM8nYmHWyTFOvERzjfZVu+JYlP2r9S epPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=A2S0VguwI+vPRoafp0n7H/FnoxCrEJkQC7JvYKj1Y0s=; b=ZXNWzK9sapxh6oD36X7NLNbZCpEPu/KF4D4Jxycsd8Ox73M4Q5QDOsLisSnw8NhfaB KnYVV+ZgUPjX6diSfYqWSfCNKa40E0JQNdZeyZQqjYYT05zTCecQ6hu4qMC2jiIcQhN7 HwFXc2rLxTc6YJ2Ow5t5l3kErCH7JMCuGbDGjYah2kKwrm3lEobydGFUwMUkUg397EtM VFbYIR+W98sdds9/b0hnuskvySSuemiTf1xvCeTblwPz1bwkNgCM3g7oHTNkc+H6nqu3 xUpYxrzjzORIpL7RjvJ8ZZbLCC+FoDfq9zTgXLkISQuEFqkTuYe3PcNMhrx87IBtcCcv rGEw== X-Gm-Message-State: ANhLgQ3c8hzO1mHx0zgqY20G4ym/bJMOk2LSVuux36f3JXn6gEGTmmm5 1OsFZNZxDpQOUORvXctRMFdvGg== X-Google-Smtp-Source: ADFU+vvfNiM0lhbIk+4DF69YACHaSoOD2UzvSXjcbL/Yevz/3tgRAyjOYY4bwXeZHBIHemSgOn8+hQ== X-Received: by 2002:a1c:9e85:: with SMTP id h127mr9702121wme.145.1584094528850; Fri, 13 Mar 2020 03:15:28 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id a73sm280921wme.47.2020.03.13.03.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2020 03:15:28 -0700 (PDT) Date: Fri, 13 Mar 2020 10:15:24 +0000 From: Quentin Perret To: Lukasz Luba Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Morten.Rasmussen@arm.com, Dietmar.Eggemann@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, liviu.dudau@arm.com, lorenzo.pieralisi@arm.com, patrick.bellasi@matbug.net, orjan.eide@arm.com, rdunlap@infradead.org Subject: Re: [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() Message-ID: <20200313101524.GA150397@google.com> References: <20200309134117.2331-1-lukasz.luba@arm.com> <20200309134117.2331-3-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309134117.2331-3-lukasz.luba@arm.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Monday 09 Mar 2020 at 13:41:15 (+0000), Lukasz Luba wrote: > diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c > index d2b5f062a07b..676b56424886 100644 > --- a/drivers/cpufreq/cpufreq-dt.c > +++ b/drivers/cpufreq/cpufreq-dt.c > @@ -275,7 +275,9 @@ static int cpufreq_init(struct cpufreq_policy *policy) > policy->cpuinfo.transition_latency = transition_latency; > policy->dvfs_possible_from_any_cpu = true; > > - dev_pm_opp_of_register_em(policy->cpus); > + ret = dev_pm_opp_of_register_em(cpu_dev, policy->cpus); > + if (ret) > + dev_dbg(cpu_dev, "Couldn't register Energy Model %d\n", ret); > > return 0; Ah, that answers my comment on patch 01. You're adding the error messages here. Isn't this more boilerplate for the drivers ? All they do is print the same debug message. Maybe just move it inside dev_pm_opp_of_register_em directly ? Thanks, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4169C10DCE for ; Fri, 13 Mar 2020 10:15:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A4C62073E for ; Fri, 13 Mar 2020 10:15:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BOF7cYMg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="GVMDp2vZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A4C62073E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1b5eNpHYX49ZqNxw3FN0X0BzyvktxH6LN81V+kzGjAs=; b=BOF7cYMgsx/BVF DHeFbmh4u8yZog3a2PLnu1XnXGT0NQu7hcIJjNc0EafDoBWNU8FECYqMiFa17Hg42caEa/t6D6klZ SBtw0cuZ75VA/NUOs3B7P9x8iz6Pt37QXgHfgvQp5um43FjiqU/NKCcJMLwDWgep/gcXhSTLQfAdI WJgzGkdHwKILpb073z5CPpCQttQ7b22bF9w2rY0huJfm4ITWyLxxdQUeLm6PZWI8GzOBVrHVMA7w7 M5cRWqYrpSH8I6ZBpSguiuiJ+7+JrOOmykplqRsSmOY9bIQ5dwe0t0GETh/JBo3NAX7Z5llowW9HC 1v1/6jBShtBxhVSUcQuQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jChLp-0004Rq-Ez; Fri, 13 Mar 2020 10:15:33 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jChLn-0004Qw-1z for linux-mediatek@lists.infradead.org; Fri, 13 Mar 2020 10:15:32 +0000 Received: by mail-wm1-x344.google.com with SMTP id a5so9263660wmb.0 for ; Fri, 13 Mar 2020 03:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=A2S0VguwI+vPRoafp0n7H/FnoxCrEJkQC7JvYKj1Y0s=; b=GVMDp2vZE2aQwlKRTXncVtfN/X+6h48E0TlmseeRuAA107vTByb4SPEwMedGts2FpH 0TL7glG8mEnbMDZ+queQzD2z8DhUOZNdJH7ieZjOQnso4/ztWA4Zn75c65eSChADubSd 0cXZHBjArc0TCK17CXch9WBT9JSoawEIY9faPIiTiyZVLh7CB+EXTkP4tDkHsfeB1+R2 YXRhfNpkpNTIcVQmQ/Elu9NY3FwXfyvYutM+MW2tImKrOwQKW22UE3kEC/U09RRMs36N k87s/4AcSbJhgTuxTtpxn6vzTgZzEV/FulMOW4LM8nYmHWyTFOvERzjfZVu+JYlP2r9S epPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=A2S0VguwI+vPRoafp0n7H/FnoxCrEJkQC7JvYKj1Y0s=; b=OtsnmbFIKJp/DeC9bvSedID4EO0vEpt2E7EYeNcl64cNvTmujtqCi86JrQEiCG0UVL DDGrrjp8vkxQgb9jebs95KmIpumWuqIRAyV8LUWNw+7pozTQD8srcRW31Ed5LtxEzlOf Wosas81EJjFMD14h9yr6qNNolW8d8FF9rN/6Ru62BWtdSWF/OggROimY5T82E1wJQ7hk 3s41+uKTasxlcwNVex1eC5kf+NMmJA27ddwzjTlBIMiWqqes0tyCGduWFbu12/DXc1HQ VRM56Wsh8dU23Hw8yTLHOfQbB3AkTe83PFYaYduqRtgzbcscIIl/+7/KTiKJS2ZssYAe 8Y4g== X-Gm-Message-State: ANhLgQ1bDRWDnmKURCttCuIjtG90Mnijq71NJTRRBLGOdp+HzmZCip6k mmkYS+DocXmxa/3wBptAAuLhQGotG1TpYg== X-Google-Smtp-Source: ADFU+vvfNiM0lhbIk+4DF69YACHaSoOD2UzvSXjcbL/Yevz/3tgRAyjOYY4bwXeZHBIHemSgOn8+hQ== X-Received: by 2002:a1c:9e85:: with SMTP id h127mr9702121wme.145.1584094528850; Fri, 13 Mar 2020 03:15:28 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id a73sm280921wme.47.2020.03.13.03.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2020 03:15:28 -0700 (PDT) Date: Fri, 13 Mar 2020 10:15:24 +0000 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() Message-ID: <20200313101524.GA150397@google.com> References: <20200309134117.2331-1-lukasz.luba@arm.com> <20200309134117.2331-3-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200309134117.2331-3-lukasz.luba@arm.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200313_031531_129985_78154296 X-CRM114-Status: UNSURE ( 9.16 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Monday 09 Mar 2020 at 13:41:15 (+0000), Lukasz Luba wrote: > diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c > index d2b5f062a07b..676b56424886 100644 > --- a/drivers/cpufreq/cpufreq-dt.c > +++ b/drivers/cpufreq/cpufreq-dt.c > @@ -275,7 +275,9 @@ static int cpufreq_init(struct cpufreq_policy *policy) > policy->cpuinfo.transition_latency = transition_latency; > policy->dvfs_possible_from_any_cpu = true; > > - dev_pm_opp_of_register_em(policy->cpus); > + ret = dev_pm_opp_of_register_em(cpu_dev, policy->cpus); > + if (ret) > + dev_dbg(cpu_dev, "Couldn't register Energy Model %d\n", ret); > > return 0; Ah, that answers my comment on patch 01. You're adding the error messages here. Isn't this more boilerplate for the drivers ? All they do is print the same debug message. Maybe just move it inside dev_pm_opp_of_register_em directly ? Thanks, Quentin _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D91C10DCE for ; Fri, 13 Mar 2020 10:15:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CBBC2073E for ; Fri, 13 Mar 2020 10:15:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YJWBF0d/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="GVMDp2vZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CBBC2073E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xd4jjd8mVDPPIbrGHBNlwiHF+8LVoEB/pwCRc6BN4jA=; b=YJWBF0d/acj9BT QPBVyHbwQHssJJJb7v44fouyoeXyehwShz137zrVO6PGDdwbhBTspZJKjFpuOE4J5GAP8tSFkST1i 1cgv3icuxcjVND2VxyyRJqO2w7qPAjDIRimkx4bkhoIzK3Agn2i9pkG15Lc063vVSMPyBjy+iTMJa 3NKd0a8+i8aH0D/ExkILe7hHW3pQjHATxDdtpnAslqX3aSMJpRKNxRJXgySryBz+br2j/u+fZDCGU jr4thI5henTYw1g9m3pjQ7YiQsqiHUG+PCNIC+PzW+e/QaoplwzgL3kJ21mMoIsTk1MZS1+DmudmY oewRbkE6OpCLefGFEZVA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jChLr-0004Sh-8C; Fri, 13 Mar 2020 10:15:35 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jChLn-0004Qx-27 for linux-arm-kernel@lists.infradead.org; Fri, 13 Mar 2020 10:15:32 +0000 Received: by mail-wm1-x342.google.com with SMTP id a132so9266496wme.1 for ; Fri, 13 Mar 2020 03:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=A2S0VguwI+vPRoafp0n7H/FnoxCrEJkQC7JvYKj1Y0s=; b=GVMDp2vZE2aQwlKRTXncVtfN/X+6h48E0TlmseeRuAA107vTByb4SPEwMedGts2FpH 0TL7glG8mEnbMDZ+queQzD2z8DhUOZNdJH7ieZjOQnso4/ztWA4Zn75c65eSChADubSd 0cXZHBjArc0TCK17CXch9WBT9JSoawEIY9faPIiTiyZVLh7CB+EXTkP4tDkHsfeB1+R2 YXRhfNpkpNTIcVQmQ/Elu9NY3FwXfyvYutM+MW2tImKrOwQKW22UE3kEC/U09RRMs36N k87s/4AcSbJhgTuxTtpxn6vzTgZzEV/FulMOW4LM8nYmHWyTFOvERzjfZVu+JYlP2r9S epPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=A2S0VguwI+vPRoafp0n7H/FnoxCrEJkQC7JvYKj1Y0s=; b=cezyxa6qML1JM0H4keT+BRHX1clMd27tPuBc+yaUnZK4+V4hPx12BCEBVEZ8XF5zKQ tQOKHAXRS2TOv44O48F4WuhuPud5JNonxTRKn1eHMvjnNX2jLEXbx0G5Lp7uts0C7B70 skW/ToOx1Bby55QB05/RJbUntwwAqWsdLYqqCqSuBAQHNJP9lXPpCLJeVoAJRJcjjkGd IJKpedh4HKVAId/lHk9tNmEGCJQv805o4skDYoli/rqVvJmoHFHWfsXeNp1MxUM8o3Um etTcQPwocM4v0ABsO+ax6y+Ssi6VBil2hwkU2RC7JWKdVkxydA9EaT0pzpOff9xkV+5K E1Pg== X-Gm-Message-State: ANhLgQ0Wu+GgS5tz1B4CCBm4A3gDu3iF8jd6QHShmE+NsZALOKqdwwVJ MgU3kmzTsRfrmwPZ8a6IVU76mQ== X-Google-Smtp-Source: ADFU+vvfNiM0lhbIk+4DF69YACHaSoOD2UzvSXjcbL/Yevz/3tgRAyjOYY4bwXeZHBIHemSgOn8+hQ== X-Received: by 2002:a1c:9e85:: with SMTP id h127mr9702121wme.145.1584094528850; Fri, 13 Mar 2020 03:15:28 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id a73sm280921wme.47.2020.03.13.03.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2020 03:15:28 -0700 (PDT) Date: Fri, 13 Mar 2020 10:15:24 +0000 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() Message-ID: <20200313101524.GA150397@google.com> References: <20200309134117.2331-1-lukasz.luba@arm.com> <20200309134117.2331-3-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200309134117.2331-3-lukasz.luba@arm.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200313_031531_130399_851E23A0 X-CRM114-Status: GOOD ( 10.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Monday 09 Mar 2020 at 13:41:15 (+0000), Lukasz Luba wrote: > diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c > index d2b5f062a07b..676b56424886 100644 > --- a/drivers/cpufreq/cpufreq-dt.c > +++ b/drivers/cpufreq/cpufreq-dt.c > @@ -275,7 +275,9 @@ static int cpufreq_init(struct cpufreq_policy *policy) > policy->cpuinfo.transition_latency = transition_latency; > policy->dvfs_possible_from_any_cpu = true; > > - dev_pm_opp_of_register_em(policy->cpus); > + ret = dev_pm_opp_of_register_em(cpu_dev, policy->cpus); > + if (ret) > + dev_dbg(cpu_dev, "Couldn't register Energy Model %d\n", ret); > > return 0; Ah, that answers my comment on patch 01. You're adding the error messages here. Isn't this more boilerplate for the drivers ? All they do is print the same debug message. Maybe just move it inside dev_pm_opp_of_register_em directly ? Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F174C5ACBF for ; Sun, 15 Mar 2020 23:19:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D82620409 for ; Sun, 15 Mar 2020 23:19:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="GVMDp2vZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D82620409 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 732FA6E2F2; Sun, 15 Mar 2020 23:19:17 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E8476EBAC for ; Fri, 13 Mar 2020 10:15:30 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id 6so9252361wmi.5 for ; Fri, 13 Mar 2020 03:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=A2S0VguwI+vPRoafp0n7H/FnoxCrEJkQC7JvYKj1Y0s=; b=GVMDp2vZE2aQwlKRTXncVtfN/X+6h48E0TlmseeRuAA107vTByb4SPEwMedGts2FpH 0TL7glG8mEnbMDZ+queQzD2z8DhUOZNdJH7ieZjOQnso4/ztWA4Zn75c65eSChADubSd 0cXZHBjArc0TCK17CXch9WBT9JSoawEIY9faPIiTiyZVLh7CB+EXTkP4tDkHsfeB1+R2 YXRhfNpkpNTIcVQmQ/Elu9NY3FwXfyvYutM+MW2tImKrOwQKW22UE3kEC/U09RRMs36N k87s/4AcSbJhgTuxTtpxn6vzTgZzEV/FulMOW4LM8nYmHWyTFOvERzjfZVu+JYlP2r9S epPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=A2S0VguwI+vPRoafp0n7H/FnoxCrEJkQC7JvYKj1Y0s=; b=FIzIFY9PR3dHmiV5hord3dB8VhkrjuYP3VIePAxtkL42fuQKlNNx+4JeWBJ5ZjP09Q D/kIm9EGOWs1UzPORr3f05/jbderB0zg+AsHdP8KR5pLkhDPqDnNkAs0tJ8qBZANUd5j 6nTxBfxxbTNfYcGyikYgKGMrJ6owNtARDDkdE/4EGrhrYYx9ddU7FbPoHxlfMKa0RtYy sdNZ41XMfy2nEE1vuH6+DdEo3U8cI8p5Cqhibp3IKl7tVVxuP/YXxL0p3rUvy1mxc3/o jWrpRrfLGFnqYPCtKJX+nhncHJ+inTOINQsVL1aarqNM+W2RbGJbl2TRbQYx1ANPZmko mm2g== X-Gm-Message-State: ANhLgQ2t/BiOxZpv7dxsLGy4H47O6+ZhrGlmL3tsdB3ld+LEOoN/xOvu lle4K++8baksSMR9nR9R4IJE3A== X-Google-Smtp-Source: ADFU+vvfNiM0lhbIk+4DF69YACHaSoOD2UzvSXjcbL/Yevz/3tgRAyjOYY4bwXeZHBIHemSgOn8+hQ== X-Received: by 2002:a1c:9e85:: with SMTP id h127mr9702121wme.145.1584094528850; Fri, 13 Mar 2020 03:15:28 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id a73sm280921wme.47.2020.03.13.03.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2020 03:15:28 -0700 (PDT) Date: Fri, 13 Mar 2020 10:15:24 +0000 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() Message-ID: <20200313101524.GA150397@google.com> References: <20200309134117.2331-1-lukasz.luba@arm.com> <20200309134117.2331-3-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200309134117.2331-3-lukasz.luba@arm.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Approved-At: Sun, 15 Mar 2020 23:19:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, Morten.Rasmussen@arm.com, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Monday 09 Mar 2020 at 13:41:15 (+0000), Lukasz Luba wrote: > diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c > index d2b5f062a07b..676b56424886 100644 > --- a/drivers/cpufreq/cpufreq-dt.c > +++ b/drivers/cpufreq/cpufreq-dt.c > @@ -275,7 +275,9 @@ static int cpufreq_init(struct cpufreq_policy *policy) > policy->cpuinfo.transition_latency = transition_latency; > policy->dvfs_possible_from_any_cpu = true; > > - dev_pm_opp_of_register_em(policy->cpus); > + ret = dev_pm_opp_of_register_em(cpu_dev, policy->cpus); > + if (ret) > + dev_dbg(cpu_dev, "Couldn't register Energy Model %d\n", ret); > > return 0; Ah, that answers my comment on patch 01. You're adding the error messages here. Isn't this more boilerplate for the drivers ? All they do is print the same debug message. Maybe just move it inside dev_pm_opp_of_register_em directly ? Thanks, Quentin _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel