Re: [PATCH rdma-next v1 11/11] RDMA/cma: Provide ECE reject reason

[Leon Romanovsky <leon@kernel.org>]

On Fri, Mar 13, 2020 at 10:54:30AM -0300, Jason Gunthorpe wrote:
> On Tue, Mar 10, 2020 at 11:14:38AM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > IBTA declares "vendor option not supported" reject reason in REJ
> > messages if passive side doesn't want to accept proposed ECE options.
> >
> > Due to the fact that ECE is managed by userspace, there is a need to let
> > users to provide such rejected reason.
> >
> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> >  drivers/infiniband/core/cma.c    | 14 ++++++++------
> >  drivers/infiniband/core/ucma.c   |  7 ++++++-
> >  include/rdma/ib_cm.h             |  3 ++-
> >  include/rdma/rdma_cm.h           | 13 ++++++++++---
> >  include/uapi/rdma/rdma_user_cm.h |  7 ++++++-
> >  5 files changed, 32 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> > index f1f0d51667b7..0b57c15139cf 100644
> > +++ b/drivers/infiniband/core/cma.c
> > @@ -4191,8 +4191,8 @@ int rdma_notify(struct rdma_cm_id *id, enum ib_event_type event)
> >  }
> >  EXPORT_SYMBOL(rdma_notify);
> >
> > -int rdma_reject(struct rdma_cm_id *id, const void *private_data,
> > -		u8 private_data_len)
> > +int rdma_reject_ece(struct rdma_cm_id *id, const void *private_data,
> > +		    u8 private_data_len, enum rdma_ucm_reject_reason reason)
> >  {
>
> Let not call something like this rdma_reject_ece, pass in the
> ib_cm_rej_reason directly and update callers

The problem that no one is interested in the reason, this is why I
decided to go with special API.

>
> Jason