From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v19 3/8] drm/i915: Add intel_bw_get_*_state helpers
Date: Fri, 13 Mar 2020 16:14:07 +0200 [thread overview]
Message-ID: <20200313141407.GM13686@intel.com> (raw)
In-Reply-To: <93708764786145ff9c8ee2c84af6ff41@intel.com>
On Fri, Mar 13, 2020 at 01:57:58PM +0000, Lisovskiy, Stanislav wrote:
> >> >> Add correspondent helpers to be able to get old/new bandwidth
> >> >> global state object.
> >> >>
> >> >> v2: - Fixed typo in function call
> >> >> v3: - Changed new functions naming to use convention proposed
> >> >> by Jani Nikula, i.e intel_bw_* in intel_bw.c file.
> >>
> >> >Still nak on the rename.
> >>
> >> Cool. Discuss it with Jani Nikula then, to have at least some common strategy on how to be picky on me.
>
> >The strategy is either rename all of these functions or none so that we
> >don't end up with random inconsistencies all over the place.
>
>
> Initially Jani Nikula wrote that he is trying to encourage people to call functions
>
> starting with the module name. OK. Done it.
>
>
> You say that the opposite and nack. Now it just turns out that it is again _me_ - poor minded, who didn't understand that I need to rename
>
> all functions now here as well, including those completely unrelated to that patch.
>
> Sure - we have "plenty" of time!
>
>
> Or may be I shouldn't rename - kind of confused now.
If you do a mass rename do it as a separate series.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-13 14:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 16:11 [Intel-gfx] [PATCH v19 0/8] Refactor Gen11+ SAGV support Stanislav Lisovskiy
2020-03-09 16:11 ` [Intel-gfx] [PATCH v19 1/8] drm/i915: Start passing latency as parameter Stanislav Lisovskiy
2020-03-10 14:32 ` Ville Syrjälä
2020-03-10 14:54 ` Lisovskiy, Stanislav
2020-03-10 20:44 ` Ville Syrjälä
2020-03-11 9:16 ` Stanislav Lisovskiy
2020-03-09 16:11 ` [Intel-gfx] [PATCH v19 2/8] drm/i915: Introduce skl_plane_wm_level accessor Stanislav Lisovskiy
[not found] ` <20200311160727.GA13686@intel.com>
2020-03-13 8:42 ` Lisovskiy, Stanislav
2020-03-09 16:11 ` [Intel-gfx] [PATCH v19 3/8] drm/i915: Add intel_bw_get_*_state helpers Stanislav Lisovskiy
[not found] ` <20200311160854.GB13686@intel.com>
2020-03-13 8:49 ` Lisovskiy, Stanislav
2020-03-13 13:26 ` Ville Syrjälä
2020-03-13 13:57 ` Lisovskiy, Stanislav
2020-03-13 14:14 ` Ville Syrjälä [this message]
2020-03-09 16:12 ` [Intel-gfx] [PATCH v19 4/8] drm/i915: Refactor intel_can_enable_sagv Stanislav Lisovskiy
2020-03-11 9:13 ` Stanislav Lisovskiy
[not found] ` <20200311163130.GC13686@intel.com>
2020-03-18 11:52 ` Lisovskiy, Stanislav
2020-03-18 12:50 ` Ville Syrjälä
2020-03-19 13:09 ` Lisovskiy, Stanislav
2020-03-20 12:51 ` Lisovskiy, Stanislav
2020-03-23 14:18 ` Ville Syrjälä
2020-03-23 14:36 ` Lisovskiy, Stanislav
2020-03-23 14:50 ` Ville Syrjälä
2020-03-23 14:58 ` Lisovskiy, Stanislav
2020-03-09 16:12 ` [Intel-gfx] [PATCH v19 5/8] drm/i915: Added required new PCode commands Stanislav Lisovskiy
2020-03-09 16:12 ` [Intel-gfx] [PATCH v19 6/8] drm/i915: Rename bw_state to new_bw_state Stanislav Lisovskiy
2020-03-09 16:12 ` [Intel-gfx] [PATCH v19 7/8] drm/i915: Restrict qgv points which don't have enough bandwidth Stanislav Lisovskiy
2020-03-09 16:12 ` [Intel-gfx] [PATCH v19 8/8] drm/i915: Enable SAGV support for Gen12 Stanislav Lisovskiy
2020-03-09 16:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support Patchwork
2020-03-10 13:58 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-03-11 12:54 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Refactor Gen11+ SAGV support (rev3) Patchwork
2020-03-11 14:20 ` Lisovskiy, Stanislav
2020-03-11 19:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Refactor Gen11+ SAGV support (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313141407.GM13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stanislav.lisovskiy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.