From: Tony Lindgren <tony@atomide.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Roger Quadros <rogerq@ti.com>,
hch@lst.de, robh+dt@kernel.org, nm@ti.com, t-kristo@ti.com,
nsekhar@ti.com, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH v2] ARM: dts: dra7: Add bus_dma_limit for L3 bus
Date: Fri, 13 Mar 2020 08:15:16 -0700 [thread overview]
Message-ID: <20200313151516.GB37466@atomide.com> (raw)
In-Reply-To: <fb916d06-1521-25a5-2eae-94244a3f9d06@arm.com>
* Robin Murphy <robin.murphy@arm.com> [200313 15:06]:
> On 2020-03-13 9:47 am, Roger Quadros wrote:
> > The L3 interconnect's memory map is from 0x0 to
> > 0xffffffff. Out of this, System memory (SDRAM) can be
> > accessed from 0x80000000 to 0xffffffff (2GB)
> >
> > DRA7 does support 4GB of SDRAM but upper 2GB can only be
> > accessed by the MPU subsystem.
> >
> > Add the dma-ranges property to reflect the physical address limit
> > of the L3 bus.
> >
> > Issues ere observed only with SATA on DRA7-EVM with 4GB RAM
> > and CONFIG_ARM_LPAE enabled. This is because the controller
> > supports 64-bit DMA and its driver sets the dma_mask to 64-bit
> > thus resulting in DMA accesses beyond L3 limit of 2G.
> >
> > Setting the correct bus_dma_limit fixes the issue.
>
> Neat! In principle you should no longer need the specific dma-ranges on the
> PCIe nodes, since AIUI those really only represent a subset of this general
> limitation, but given the other inheritance issue you saw it's probably
> safer to leave them as-is for now.
Also, Roger, I think omap5 needs a similar patch too, right?
At least pyra has omap5 with 4GB and SATA connector.
> FWIW,
>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Sorry missed that as I just pushed out the fix.
Regards,
Tony
next prev parent reply other threads:[~2020-03-13 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 9:47 [PATCH v2] ARM: dts: dra7: Add bus_dma_limit for L3 bus Roger Quadros
2020-03-13 14:41 ` Tony Lindgren
2020-03-13 15:05 ` Robin Murphy
2020-03-13 15:15 ` Tony Lindgren [this message]
2020-03-16 8:35 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313151516.GB37466@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rogerq@ti.com \
--cc=stable@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.