From: Matthias Kaehlcke <mka@chromium.org>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org,
Leonard Crestez <leonard.crestez@nxp.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v3] thermal: devfreq_cooling: Use PM QoS to set frequency limits
Date: Fri, 13 Mar 2020 09:55:35 -0700 [thread overview]
Message-ID: <20200313165535.GI144492@google.com> (raw)
In-Reply-To: <20200312113416.v3.1.I146403d05b9ec82f48b807efd416a57f545b447a@changeid>
On Thu, Mar 12, 2020 at 11:34:20AM -0700, Matthias Kaehlcke wrote:
> Now that devfreq supports limiting the frequency range of a device
> through PM QoS make use of it instead of disabling OPPs that should
> not be used.
>
> The switch from disabling OPPs to PM QoS introduces a subtle behavioral
> change in case of conflicting requests (min > max): PM QoS gives
> precedence to the MIN_FREQUENCY request, while higher OPPs disabled
> with dev_pm_opp_disable() would override MIN_FREQUENCY.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
I just noticed that I forgot to add Chanwoo's 'Reviewed-by' tag from v2.
Dunno if patchwork will allow this, but I can try:
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
next prev parent reply other threads:[~2020-03-13 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 18:34 [PATCH v3] thermal: devfreq_cooling: Use PM QoS to set frequency limits Matthias Kaehlcke
2020-03-13 16:55 ` Matthias Kaehlcke [this message]
2020-03-18 8:07 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313165535.GI144492@google.com \
--to=mka@chromium.org \
--cc=amit.kucheria@verdurent.com \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.