From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D5CC10DCE for ; Fri, 13 Mar 2020 17:16:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE1D02074C for ; Fri, 13 Mar 2020 17:16:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GfpGJJf8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726808AbgCMRQo (ORCPT ); Fri, 13 Mar 2020 13:16:44 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:55802 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726756AbgCMRQo (ORCPT ); Fri, 13 Mar 2020 13:16:44 -0400 Received: by mail-wm1-f66.google.com with SMTP id 6so10826244wmi.5 for ; Fri, 13 Mar 2020 10:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Eqg2D57NGypJeQM7MhiMjBD9eTQ+XWnQ6tOgh9VYzPg=; b=GfpGJJf8jdD5hvEZ9qPjhmJSoxo3e4jgo5CXvygHAM+2QJPUnQGxgH3uES2Kynkpd4 T6ATW927TaBZFCRVrNO170pUUV2oW1VQbb+Pexs0ZoOzJkDFAd5UyC6AZMYRUVFm095y IkcVD4f+FvTY8CtYEgV2DY2o1mbRUANwOHxkBIP37vtgNzFrkkQDbvXS+mWOsrsn5DGP gEO8LlEKRjsHdzu32a8Zv2sKCjnNA9JMK1m96aENNsalwtpPCqB7Vq/otY1b4E8n+Q21 glAgkPcq3G2Hd8vv/mEHOpfMtESQYAYkl9W6BYLtnfQ1hAid0M6CcWidFLKlq36v9zAc LL0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Eqg2D57NGypJeQM7MhiMjBD9eTQ+XWnQ6tOgh9VYzPg=; b=W/mWuUkHy1U6bvRlnj0wz0RoAENAAHBrg6xD4UQCggq4ZOjEhP2qbpvXRpwdA5mHuD 6DmCyeg6Zv1b7xKmVmc7SEgeWPO34PdSIyXbESNn4L8gxS6bKFERRUIa1uoKL3Ykger2 RFgN+PaWBrwjXKzbrWtmfaO8JrJ1P7OsJCViDXyYHtIKAKVL2vCvs83o+GlKN6puwvWt w6O5i7qWaVYmjvfgFkRO3ZY8vv2TiPZFi7mhB42eYKh5tAL/QLJBXzn/rwlnkbK2Po9K Sierjqt+ojWvkak2l3PDHUU6VCwyIu6fW604eV6D2kodU9s00cJ3ZUkhw2hSsoE+jrq+ cg5g== X-Gm-Message-State: ANhLgQ33sGYlYzR12WI5fMMm3mabNQJbEDQc1yBE0NbmU1pN5MJJVrnF +QyxWWMn2X5TmtSJyTfHVjwkyw== X-Google-Smtp-Source: ADFU+vumzHSTSx0NnmOYLAmGcl4NJn5zSn0aH51pn2PnfTIecwwRlYBGAj9fxcb0ea7+lXVvBBbhJA== X-Received: by 2002:a1c:7c08:: with SMTP id x8mr11581854wmc.84.1584119802734; Fri, 13 Mar 2020 10:16:42 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id b187sm14223421wmb.42.2020.03.13.10.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2020 10:16:42 -0700 (PDT) Date: Fri, 13 Mar 2020 17:16:38 +0000 From: Quentin Perret To: Lukasz Luba Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Morten.Rasmussen@arm.com, Dietmar.Eggemann@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, liviu.dudau@arm.com, lorenzo.pieralisi@arm.com, patrick.bellasi@matbug.net, orjan.eide@arm.com, rdunlap@infradead.org Subject: Re: [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() Message-ID: <20200313171638.GB236432@google.com> References: <20200309134117.2331-1-lukasz.luba@arm.com> <20200309134117.2331-3-lukasz.luba@arm.com> <20200313101524.GA150397@google.com> <3ac8ebf8-9db0-d168-8b80-f7f5ba345f86@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ac8ebf8-9db0-d168-8b80-f7f5ba345f86@arm.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Friday 13 Mar 2020 at 17:11:45 (+0000), Lukasz Luba wrote: > --------------------------------->8---------------- > dev_pm_opp_of_register_em > ... > nr_opp = dev_pm_opp_get_opp_count(dev); > if (nr_opp <= 0) { > ret = -EINVAL; > goto fail; > } > > ... > ret = em_register_perf_domain() > if (ret) > goto fail; > > return 0; > > fail: > dev_dbg(cpu_dev, "Couldn't register Energy Model %d\n", ret); > return ret > ------------------------8<----------------- That works for me. Thanks, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF08BC10DCE for ; Fri, 13 Mar 2020 17:19:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C11D4206B1 for ; Fri, 13 Mar 2020 17:19:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qTXO1ubu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="GfpGJJf8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C11D4206B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YzJ9IGN1YzX7CqZzbmu8u5i1kU44Sk/5Z1pflw3d7c0=; b=qTXO1ubuHx552t ZwW1JOA/FZX650pLBnTOKy8p+njHnrMe2XcHxZgmhyPQRsqYKewsaSCsGoyt+30z4CLjW9RBOJknE Z2FfEymErovskms4LsJFpp9Ajxr/DBr276+8i+CDko+WRL4ehlBPPskladJHICMNoYNwV+VV608Uu BkIg6rxwdFuD7SVm9vD5Zlzsmrhn4IX2s9Iv7oAkjFkNVCR71YqQc18JmgnRijPEWif4Lojic1euR 8sW3EVppeQ+hHLJya1XXm3T7RhNgLjpH6NJLO9em/NlonzpxEyenTcNpx2NlSGw0OdzKXA6VlqNov hUKvCYJSwiL81hddisyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCnwD-0001JR-Mr; Fri, 13 Mar 2020 17:17:46 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCnvQ-0001Gt-KO for linux-mediatek@lists.infradead.org; Fri, 13 Mar 2020 17:17:08 +0000 Received: by mail-wm1-x344.google.com with SMTP id 11so10817495wmo.2 for ; Fri, 13 Mar 2020 10:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Eqg2D57NGypJeQM7MhiMjBD9eTQ+XWnQ6tOgh9VYzPg=; b=GfpGJJf8jdD5hvEZ9qPjhmJSoxo3e4jgo5CXvygHAM+2QJPUnQGxgH3uES2Kynkpd4 T6ATW927TaBZFCRVrNO170pUUV2oW1VQbb+Pexs0ZoOzJkDFAd5UyC6AZMYRUVFm095y IkcVD4f+FvTY8CtYEgV2DY2o1mbRUANwOHxkBIP37vtgNzFrkkQDbvXS+mWOsrsn5DGP gEO8LlEKRjsHdzu32a8Zv2sKCjnNA9JMK1m96aENNsalwtpPCqB7Vq/otY1b4E8n+Q21 glAgkPcq3G2Hd8vv/mEHOpfMtESQYAYkl9W6BYLtnfQ1hAid0M6CcWidFLKlq36v9zAc LL0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Eqg2D57NGypJeQM7MhiMjBD9eTQ+XWnQ6tOgh9VYzPg=; b=bgLtPSFExEXoj98dI923VbqyYMuHxY2fSLmf4Blc6ZtamNS4DuNz9SZ2s5fKMqDQMJ 4doszPpAyQvhCWfMzpihdljDxr6ut0L1eBRKCP4blXOIV3/djGhc5glLjJ2KM0LRfMtE iFZ1IcZEFmiKT2UIV6MvINiXHrJ/LXmHlR5IV38ow26t0xC+TwWKBDGLpgjPXVHL0jjM qfPblRgIHU4Fs55YMXCPgdkafQPwlt7pmzVQa/dX6benJTj77IoyQd+daxOQZYCRzrfZ KKxbnIMUwWOTrjGqBATxoaLQNar1QS2e9CmmuPbrHNRyOom5dKm2cn9pPcJhM3bJclqF SSvA== X-Gm-Message-State: ANhLgQ3r3/YU3H2RuvjOwua8NBhhLib2ee70cjo/tPvKx74A/E1k1NVE QoiEBz4GkXNmkwyRf8LFP4ULNA== X-Google-Smtp-Source: ADFU+vumzHSTSx0NnmOYLAmGcl4NJn5zSn0aH51pn2PnfTIecwwRlYBGAj9fxcb0ea7+lXVvBBbhJA== X-Received: by 2002:a1c:7c08:: with SMTP id x8mr11581854wmc.84.1584119802734; Fri, 13 Mar 2020 10:16:42 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id b187sm14223421wmb.42.2020.03.13.10.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2020 10:16:42 -0700 (PDT) Date: Fri, 13 Mar 2020 17:16:38 +0000 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() Message-ID: <20200313171638.GB236432@google.com> References: <20200309134117.2331-1-lukasz.luba@arm.com> <20200309134117.2331-3-lukasz.luba@arm.com> <20200313101524.GA150397@google.com> <3ac8ebf8-9db0-d168-8b80-f7f5ba345f86@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3ac8ebf8-9db0-d168-8b80-f7f5ba345f86@arm.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200313_101656_797755_F552302B X-CRM114-Status: UNSURE ( 6.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Friday 13 Mar 2020 at 17:11:45 (+0000), Lukasz Luba wrote: > --------------------------------->8---------------- > dev_pm_opp_of_register_em > ... > nr_opp = dev_pm_opp_get_opp_count(dev); > if (nr_opp <= 0) { > ret = -EINVAL; > goto fail; > } > > ... > ret = em_register_perf_domain() > if (ret) > goto fail; > > return 0; > > fail: > dev_dbg(cpu_dev, "Couldn't register Energy Model %d\n", ret); > return ret > ------------------------8<----------------- That works for me. Thanks, Quentin _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B0A2C10DCE for ; Fri, 13 Mar 2020 17:21:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19B21206B1 for ; Fri, 13 Mar 2020 17:21:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iz401dxJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="GfpGJJf8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19B21206B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MYoXHCneeQzVeep26EfKK/T1rCzN4P8sqYZrKX6GQfI=; b=iz401dxJCvj0I3 O1CGYkyrqinqoW8EtSDFa4REn/q8Yin+Cm34rhoVJ44nEbSFToKVTzZ71uqHHmCWeiEmf/0rlUHa+ JjKStQDIRyjc/oSZjOAbCgOJN50g80v9bKlnPKbfdHJ48w+3RhlLkTiPWv7tGtTS315I69yUSOwSE YrB2fuFCSqVIDZVhIlx0yCRm+s02goWG2RSHSztDRX6bSRMl2zrDP6/O29JqiNvelAic/e+QGr9MG /v6+HZ87vwkRlynU/qftwfTy9nWQ9LrVCST99wI4f6qHM/A0fwef4LDPFSvZqbmh3Izu20XmUihBw t7K+Z+p1uDHlGYgHAbtA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCo0B-0003Br-6C; Fri, 13 Mar 2020 17:21:39 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCnvQ-0001Gs-E2 for linux-arm-kernel@lists.infradead.org; Fri, 13 Mar 2020 17:17:10 +0000 Received: by mail-wm1-x341.google.com with SMTP id a141so11140792wme.2 for ; Fri, 13 Mar 2020 10:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Eqg2D57NGypJeQM7MhiMjBD9eTQ+XWnQ6tOgh9VYzPg=; b=GfpGJJf8jdD5hvEZ9qPjhmJSoxo3e4jgo5CXvygHAM+2QJPUnQGxgH3uES2Kynkpd4 T6ATW927TaBZFCRVrNO170pUUV2oW1VQbb+Pexs0ZoOzJkDFAd5UyC6AZMYRUVFm095y IkcVD4f+FvTY8CtYEgV2DY2o1mbRUANwOHxkBIP37vtgNzFrkkQDbvXS+mWOsrsn5DGP gEO8LlEKRjsHdzu32a8Zv2sKCjnNA9JMK1m96aENNsalwtpPCqB7Vq/otY1b4E8n+Q21 glAgkPcq3G2Hd8vv/mEHOpfMtESQYAYkl9W6BYLtnfQ1hAid0M6CcWidFLKlq36v9zAc LL0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Eqg2D57NGypJeQM7MhiMjBD9eTQ+XWnQ6tOgh9VYzPg=; b=VSbME8ZH9/IKkBjI7Ruug/6HYLEUn+srZjLH/b9uV9+ae1G7zN3VnJrvnRbQPvomd8 6eQZdQXSeuj1PSfqLwQYa/IoBhh5NvTxnM8RzwDhuCtUxB50+QpOEOjsj5EOUqJ9DaMm 8JchZdlvPYwgzZQtKtZQdTxdlepjpn/FMq11PfMLrzqbNSwNr2c0yMQiVoPytvNWSn3z 9UpQ5odiEUpLSGgCLiyXT5Ia8LA1jRBBtDOw8L5+CF3hRckv7Ef6OPCOjkFXC308ZUei 4/+fNhavhpyGB0Q47/3RzMVMQ49ukvJqkpmbKMHx1MOXb0gD6ZPJ9VGjv9kEle7Ld5+w +zew== X-Gm-Message-State: ANhLgQ2bUwyvhDChYf+VUVGDIUp0ZnF0CXdEzcsCP2fCTid0teNNonGh u8lgXClWmajfbwY5Lg0M+Y6ZHdluPAuEew== X-Google-Smtp-Source: ADFU+vumzHSTSx0NnmOYLAmGcl4NJn5zSn0aH51pn2PnfTIecwwRlYBGAj9fxcb0ea7+lXVvBBbhJA== X-Received: by 2002:a1c:7c08:: with SMTP id x8mr11581854wmc.84.1584119802734; Fri, 13 Mar 2020 10:16:42 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id b187sm14223421wmb.42.2020.03.13.10.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2020 10:16:42 -0700 (PDT) Date: Fri, 13 Mar 2020 17:16:38 +0000 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() Message-ID: <20200313171638.GB236432@google.com> References: <20200309134117.2331-1-lukasz.luba@arm.com> <20200309134117.2331-3-lukasz.luba@arm.com> <20200313101524.GA150397@google.com> <3ac8ebf8-9db0-d168-8b80-f7f5ba345f86@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3ac8ebf8-9db0-d168-8b80-f7f5ba345f86@arm.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200313_101656_800077_C9032BE7 X-CRM114-Status: UNSURE ( 8.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Friday 13 Mar 2020 at 17:11:45 (+0000), Lukasz Luba wrote: > --------------------------------->8---------------- > dev_pm_opp_of_register_em > ... > nr_opp = dev_pm_opp_get_opp_count(dev); > if (nr_opp <= 0) { > ret = -EINVAL; > goto fail; > } > > ... > ret = em_register_perf_domain() > if (ret) > goto fail; > > return 0; > > fail: > dev_dbg(cpu_dev, "Couldn't register Energy Model %d\n", ret); > return ret > ------------------------8<----------------- That works for me. Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37F88C10DCE for ; Sun, 15 Mar 2020 23:19:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0835920409 for ; Sun, 15 Mar 2020 23:19:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="GfpGJJf8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0835920409 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5431E6E267; Sun, 15 Mar 2020 23:19:12 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B7966EC3D for ; Fri, 13 Mar 2020 17:16:44 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id r7so8295968wmg.0 for ; Fri, 13 Mar 2020 10:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Eqg2D57NGypJeQM7MhiMjBD9eTQ+XWnQ6tOgh9VYzPg=; b=GfpGJJf8jdD5hvEZ9qPjhmJSoxo3e4jgo5CXvygHAM+2QJPUnQGxgH3uES2Kynkpd4 T6ATW927TaBZFCRVrNO170pUUV2oW1VQbb+Pexs0ZoOzJkDFAd5UyC6AZMYRUVFm095y IkcVD4f+FvTY8CtYEgV2DY2o1mbRUANwOHxkBIP37vtgNzFrkkQDbvXS+mWOsrsn5DGP gEO8LlEKRjsHdzu32a8Zv2sKCjnNA9JMK1m96aENNsalwtpPCqB7Vq/otY1b4E8n+Q21 glAgkPcq3G2Hd8vv/mEHOpfMtESQYAYkl9W6BYLtnfQ1hAid0M6CcWidFLKlq36v9zAc LL0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Eqg2D57NGypJeQM7MhiMjBD9eTQ+XWnQ6tOgh9VYzPg=; b=DR3rp6uHmKAGLONSZCVvnIXZKENdPavchUW7T1deeTwQHmUpmJb6Tbxi3y5FAPjKFA LQFlmULiY4CQ/2Qu6KDpLYZHQPTKaou0WiXNPYNwdRgDteckmBNSsiTdK1lpLMyUZMZo pxg1pLxw30OXsXOw5ylfAnHlv5fZJcBwnKIfSm6/nXx4teXe1Z2pQLHWwKbb+hv3CEF2 nbLW3mScqNhLNCZP1zjPwqkpl2bO008JZ09iDU3wSvOxVb65OVTmaZOv9ja5QEH7z3s/ laaecch3foDFVuRrTlZEW+G9eF9HZQAK9E1Ya6/qWe7Yz6yfRLImmGEU1+twHmLiUJEe 7jBQ== X-Gm-Message-State: ANhLgQ1N9bIcjgIadFiG+9S+qcSAGhCii0aP/ktDsl89uxFp29o+eanx EtMsdiZ6Kly2Vzr/1AP4O6t8PA== X-Google-Smtp-Source: ADFU+vumzHSTSx0NnmOYLAmGcl4NJn5zSn0aH51pn2PnfTIecwwRlYBGAj9fxcb0ea7+lXVvBBbhJA== X-Received: by 2002:a1c:7c08:: with SMTP id x8mr11581854wmc.84.1584119802734; Fri, 13 Mar 2020 10:16:42 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id b187sm14223421wmb.42.2020.03.13.10.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2020 10:16:42 -0700 (PDT) Date: Fri, 13 Mar 2020 17:16:38 +0000 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() Message-ID: <20200313171638.GB236432@google.com> References: <20200309134117.2331-1-lukasz.luba@arm.com> <20200309134117.2331-3-lukasz.luba@arm.com> <20200313101524.GA150397@google.com> <3ac8ebf8-9db0-d168-8b80-f7f5ba345f86@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3ac8ebf8-9db0-d168-8b80-f7f5ba345f86@arm.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Approved-At: Sun, 15 Mar 2020 23:19:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org, viresh.kumar@linaro.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, Morten.Rasmussen@arm.com, amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, orjan.eide@arm.com, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-omap@vger.kernel.org, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, rdunlap@infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Friday 13 Mar 2020 at 17:11:45 (+0000), Lukasz Luba wrote: > --------------------------------->8---------------- > dev_pm_opp_of_register_em > ... > nr_opp = dev_pm_opp_get_opp_count(dev); > if (nr_opp <= 0) { > ret = -EINVAL; > goto fail; > } > > ... > ret = em_register_perf_domain() > if (ret) > goto fail; > > return 0; > > fail: > dev_dbg(cpu_dev, "Couldn't register Energy Model %d\n", ret); > return ret > ------------------------8<----------------- That works for me. Thanks, Quentin _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel