From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v3] drm/bochs: downgrade pci_request_region failure from error to warning Date: Fri, 13 Mar 2020 19:16:02 +0100 Message-ID: <20200313181602.GA16474@ravnborg.org> References: <20200313084152.2734-1-kraxel@redhat.com> <20200313090338.GA31815@ravnborg.org> <20200313143530.6aoagldak3kpe3xv@sirius.home.kraxel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200313143530.6aoagldak3kpe3xv@sirius.home.kraxel.org> Sender: linux-kernel-owner@vger.kernel.org To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, marmarek@invisiblethingslab.com, David Airlie , open list , "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" List-Id: virtualization@lists.linuxfoundation.org On Fri, Mar 13, 2020 at 03:35:30PM +0100, Gerd Hoffmann wrote: > Hi, > > > > + if (pci_request_region(pdev, 0, "bochs-drm") != 0) > > > + DRM_WARN("Cannot request framebuffer, boot fb still active?\n"); > > So you could use drm_WARN() which is what is preferred these days. > > Nope, this isn't yet in -fixes. Ups, did not see this was for -fixes. My ack stands without ths change then. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C29FCC2BB1D for ; Fri, 13 Mar 2020 18:16:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A3DF20674 for ; Fri, 13 Mar 2020 18:16:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A3DF20674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E0C1A89F3C; Fri, 13 Mar 2020 18:16:08 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 421F789ED6 for ; Fri, 13 Mar 2020 18:16:07 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 9D2E320039; Fri, 13 Mar 2020 19:16:03 +0100 (CET) Date: Fri, 13 Mar 2020 19:16:02 +0100 From: Sam Ravnborg To: Gerd Hoffmann Subject: Re: [PATCH v3] drm/bochs: downgrade pci_request_region failure from error to warning Message-ID: <20200313181602.GA16474@ravnborg.org> References: <20200313084152.2734-1-kraxel@redhat.com> <20200313090338.GA31815@ravnborg.org> <20200313143530.6aoagldak3kpe3xv@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200313143530.6aoagldak3kpe3xv@sirius.home.kraxel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=TKvIToawjpI_eSArduEA:9 a=CjuIK1q_8ugA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" , marmarek@invisiblethingslab.com, dri-devel@lists.freedesktop.org, open list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Mar 13, 2020 at 03:35:30PM +0100, Gerd Hoffmann wrote: > Hi, > > > > + if (pci_request_region(pdev, 0, "bochs-drm") != 0) > > > + DRM_WARN("Cannot request framebuffer, boot fb still active?\n"); > > So you could use drm_WARN() which is what is preferred these days. > > Nope, this isn't yet in -fixes. Ups, did not see this was for -fixes. My ack stands without ths change then. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel