From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DATE_IN_PAST_06_12, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 605E2C0044D for ; Sun, 15 Mar 2020 01:54:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C3C7206D5 for ; Sun, 15 Mar 2020 01:54:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="3yK5v0Qp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727669AbgCOByh (ORCPT ); Sat, 14 Mar 2020 21:54:37 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:36040 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727524AbgCOByg (ORCPT ); Sat, 14 Mar 2020 21:54:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Q6HsoUxqZ7cmilY5PPiATijboZRquEoRu5alamEt44k=; b=3yK5v0Qp+MHG/GuiZ60Qk0oBVb MKcypxiAuuNzqfvH051si8SedtaM2/MqWvVoykupp3bc5cOwUSyuWTjGpvOc/w4irOCfSerVv38h6 Gd5aCkf05VRj4Gj6OOFc+2N91oRC+r6aGAaecNnk0McZ4z70UXSXBU4KCYUIjZFqtNHA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jDBfy-0001cP-OX; Sat, 14 Mar 2020 19:38:22 +0100 Date: Sat, 14 Mar 2020 19:38:22 +0100 From: Andrew Lunn To: Russell King Cc: Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org, Vivien Didelot Subject: Re: [PATCH net-next 3/8] net: dsa: mv88e6xxx: configure interface settings in mac_config Message-ID: <20200314183822.GG5388@lunn.ch> References: <20200314101431.GF25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Mar 14, 2020 at 10:15:38AM +0000, Russell King wrote: > Only configure the interface settings in mac_config(), leaving the > speed and duplex settings to mac_link_up to deal with. > > Signed-off-by: Russell King > @@ -603,33 +613,26 @@ static void mv88e6xxx_mac_config(struct dsa_switch *ds, int port, > const struct phylink_link_state *state) > { > struct mv88e6xxx_chip *chip = ds->priv; > - int speed, duplex, link, pause, err; > + int err; > > + /* FIXME: is this the correct test? If we're in fixed mode on an > + * internal port, why should we process this any different from > + * PHY mode? On the other hand, the port may be automedia between > + * an internal PHY and the serdes... > + */ > - err = mv88e6xxx_port_setup_mac(chip, port, link, speed, duplex, pause, > - state->interface); > + /* FIXME: should we force the link down here - but if we do, how > + * do we restore the link force/unforce state? The driver layering > + * gets in the way. > + */ > + err = mv88e6xxx_port_config_interface(chip, port, state->interface); Hi Russell I'm not too keen on these FIXMEs, but i don't have time at the moment to take a closer look. Reviewed-by: Andrew Lunn Andrew